DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 10/18] net/ixgbe: flush all the filters
Date: Wed, 11 Jan 2017 07:51:35 +0000	[thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA0201EAED@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <5c8bebb9-e44d-6a27-0e08-73d291721e21@intel.com>

Hi,yigit

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Saturday, January 7, 2017 12:40 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 10/18] net/ixgbe: flush all the filters
> 
> On 12/30/2016 7:53 AM, Wei Zhao wrote:
> > Add support for flush all the filters in SW.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >
> > ---
> >
> > v2:
> > --change flush filter function call relationship
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 118
> ++++++++++++++++++++++++++++++++++++++-
> >  drivers/net/ixgbe/ixgbe_ethdev.h |   9 +++
> >  drivers/net/ixgbe/ixgbe_fdir.c   |  24 ++++++++
> >  drivers/net/ixgbe/ixgbe_pf.c     |   1 +
> >  4 files changed, 150 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index d68de65..0de1318 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -61,6 +61,8 @@
> >  #include <rte_random.h>
> >  #include <rte_dev.h>
> >  #include <rte_hash_crc.h>
> > +#include <rte_flow.h>
> > +#include <rte_flow_driver.h>
> >
> >  #include "ixgbe_logs.h"
> >  #include "base/ixgbe_api.h"
> > @@ -386,7 +388,8 @@ static int ixgbe_dev_udp_tunnel_port_del(struct
> rte_eth_dev *dev,
> >  					 struct rte_eth_udp_tunnel
> *udp_tunnel);  static int
> > ixgbe_filter_restore(struct rte_eth_dev *dev);  static void
> > ixgbe_l2_tunnel_conf(struct rte_eth_dev *dev);
> > -
> > +static int ixgbe_flow_flush(struct rte_eth_dev *dev,
> > +		struct rte_flow_error *error);
> 
> I think it is good idea to move all rte_flow related code into a new file, as
> done in i40e (i40e_flow.c)? What do you think, can it be done?

I will do  as your suggestion in v3.

> 
> <...>


  reply	other threads:[~2017-01-11  7:51 UTC|newest]

Thread overview: 149+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30  7:52 [dpdk-dev] [PATCH v2 00/18] net/ixgbe: Consistent filter API Wei Zhao
2016-12-30  7:52 ` [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter Wei Zhao
2017-01-03 14:33   ` Dai, Wei
2017-01-04  1:46     ` Zhao1, Wei
2017-01-06 16:28   ` Ferruh Yigit
2017-01-10  5:33     ` Zhao1, Wei
2017-01-12  8:12   ` [dpdk-dev] [PATCH v3 00/18] net/ixgbe: Consistent filter API Wei Zhao
2017-01-12  8:13   ` [dpdk-dev] [PATCH v3 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 04/18] net/ixgbe: restore n-tuple filter Add support for restoring n-tuple filter in SW Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 4/9] " Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 13/18] net/ixgbe: parse TCP SYN filter check if the rule is a TCP SYN rule, and get the SYN info Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 14/18] net/ixgbe: parse L2 tunnel filter check if the rule is a L2 tunnel rule, and get the L2 tunnel info Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-12  8:13     ` [dpdk-dev] [PATCH v3 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-12  8:40     ` [dpdk-dev] [PATCH v4 00/18] net/ixgbe: Consistent filter API Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 04/18] net/ixgbe: restore n-tuple filter Add support for restoring n-tuple filter in SW Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 13/18] net/ixgbe: parse TCP SYN filter check if the rule is a TCP SYN rule, and get the SYN info Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 14/18] net/ixgbe: parse L2 tunnel filter check if the rule is a L2 tunnel rule, and get the L2 tunnel info Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-12  8:40       ` [dpdk-dev] [PATCH v4 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-12  9:17       ` [dpdk-dev] [PATCH v5 00/18] net/ixgbe: Consistent filter API Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 04/18] net/ixgbe: restore n-tuple filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-12 15:40           ` Ferruh Yigit
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-12 15:39           ` Ferruh Yigit
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 13/18] net/ixgbe: parse TCP SYN filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 14/18] net/ixgbe: parse L2 tunnel filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-12  9:17         ` [dpdk-dev] [PATCH v5 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-12 11:38         ` [dpdk-dev] [PATCH v5 00/18] net/ixgbe: Consistent filter API Xing, Beilei
2017-01-13  6:27           ` Dai, Wei
2017-01-12 15:43         ` Ferruh Yigit
2017-01-13  8:12         ` [dpdk-dev] [PATCH v6 " Wei Zhao
2017-01-13  8:12           ` [dpdk-dev] [PATCH v6 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-13  8:12           ` [dpdk-dev] [PATCH v6 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-13  8:12           ` [dpdk-dev] [PATCH v6 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-13  8:12           ` [dpdk-dev] [PATCH v6 04/18] net/ixgbe: restore n-tuple filter Wei Zhao
2017-01-13  8:12           ` [dpdk-dev] [PATCH v6 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 13/18] net/ixgbe: parse TCP SYN filter Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 14/18] net/ixgbe: parse L2 tunnel filter Wei Zhao
2017-01-13 11:18             ` Ferruh Yigit
2017-01-16 13:03             ` Adrien Mazarguil
2017-01-16 16:39               ` Ferruh Yigit
2017-01-16 18:26                 ` Adrien Mazarguil
2017-01-17  9:27                 ` Zhao1, Wei
2017-01-17 10:03                   ` Ferruh Yigit
2017-01-18  1:59                     ` Zhao1, Wei
2017-01-18 17:49                       ` Ferruh Yigit
2017-01-25 12:17                         ` Ferruh Yigit
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-13  8:13           ` [dpdk-dev] [PATCH v6 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-13 15:54           ` [dpdk-dev] [PATCH v6 00/18] net/ixgbe: Consistent filter API Ferruh Yigit
2017-01-15  2:44             ` Lu, Wenzhuo
2017-01-18 11:04             ` Thomas Monjalon
2016-12-30  7:52 ` [dpdk-dev] [PATCH v2 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-02  9:59   ` Xing, Beilei
2017-01-03  3:14     ` Zhao1, Wei
2017-01-03 14:28   ` Dai, Wei
2017-01-04  2:03     ` Zhao1, Wei
2017-01-06 16:31   ` Ferruh Yigit
2017-01-10  5:30     ` Zhao1, Wei
2016-12-30  7:52 ` [dpdk-dev] [PATCH v2 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-02 10:06   ` Xing, Beilei
2016-12-30  7:52 ` [dpdk-dev] [PATCH v2 04/18] net/ixgbe: restore n-tuple filter Wei Zhao
2016-12-30  7:52 ` [dpdk-dev] [PATCH v2 05/18] net/ixgbe: restore ether type filter Wei Zhao
2016-12-30  7:52 ` [dpdk-dev] [PATCH v2 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2016-12-30  7:52 ` [dpdk-dev] [PATCH v2 07/18] net/ixgbe: restore flow director filter Wei Zhao
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-02 10:18   ` Xing, Beilei
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-06 16:40   ` Ferruh Yigit
2017-01-11  7:51     ` Zhao1, Wei [this message]
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-02 10:41   ` Xing, Beilei
2017-01-02 10:45   ` Xing, Beilei
2017-01-06 16:55   ` Ferruh Yigit
2017-01-11  8:27     ` Zhao1, Wei
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-06 17:11   ` Ferruh Yigit
2017-01-11  8:54     ` Zhao1, Wei
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter Wei Zhao
2017-01-06 17:19   ` Ferruh Yigit
2017-01-10  5:46     ` Zhao1, Wei
2017-01-11  9:11     ` Zhao1, Wei
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 14/18] net/ixgbe: parse L2 tunnel filter Wei Zhao
2017-01-03 14:07   ` Adrien Mazarguil
2017-01-05  3:12     ` Zhao1, Wei
2017-01-05  8:52       ` Adrien Mazarguil
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-02 15:24   ` Xing, Beilei
2017-01-03  3:05     ` Zhao1, Wei
2017-01-03  3:19     ` Zhao1, Wei
2017-01-03 14:08   ` Adrien Mazarguil
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-03  2:04   ` Xing, Beilei
2017-01-03  3:11     ` Zhao1, Wei
     [not found]   ` <94479800C636CB44BD422CB454846E013158D036@SHSMSX101.ccr.corp.intel.com>
2017-01-03  3:09     ` Zhao1, Wei
2017-01-03  5:24   ` Xing, Beilei
2017-01-06 17:26   ` Ferruh Yigit
2017-01-10  5:50     ` Zhao1, Wei
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 17/18] net/ixgbe: destroy " Wei Zhao
2016-12-30  7:53 ` [dpdk-dev] [PATCH v2 18/18] net/ixgbe: flush all the filter list Wei Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA0201EAED@PGSMSX103.gar.corp.intel.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).