From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all filters
Date: Mon, 6 Mar 2017 07:44:14 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA02056712@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <30c77873-18e6-9d2e-65d2-201c534ec554@intel.com>
Hi, Ferruh
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Saturday, February 18, 2017 12:01 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: add mac type check for all
> filters
>
> On 2/13/2017 7:35 AM, Wei Zhao wrote:
> > All kinds of filter need to hardware mac type check to make sure the
> > hardware support that type of fliter.
> > If not, it may cause serious issue.
> >
> > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> > Fixes: 672be56d76a2 ("net/ixgbe: parse n-tuple filter")
> > Fixes: eb3539fc8550 ("net/ixgbe: parse ethertype filter")
> > Fixes: 429f6ebb42cc ("net/ixgbe: parse TCP SYN filter")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_flow.c | 129
> > +++++++++++++++++++++--------------------
> > 1 file changed, 65 insertions(+), 64 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > b/drivers/net/ixgbe/ixgbe_flow.c index 5a634d3..f414fa8 100644
> > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > @@ -84,11 +84,12 @@ cons_parse_ntuple_filter(const struct rte_flow_attr
> *attr,
> > struct rte_eth_ntuple_filter *filter,
> > struct rte_flow_error *error);
> > static int
> > -ixgbe_parse_ntuple_filter(const struct rte_flow_attr *attr,
> > - const struct rte_flow_item pattern[],
> > - const struct rte_flow_action actions[],
> > - struct rte_eth_ntuple_filter *filter,
> > - struct rte_flow_error *error);
> > +ixgbe_parse_ntuple_filter(struct rte_eth_dev *dev,
> > + const struct rte_flow_attr *attr,
> > + const struct rte_flow_item pattern[],
> > + const struct rte_flow_action actions[],
> > + struct rte_eth_ntuple_filter *filter,
> > + struct rte_flow_error *error);
>
> Hi Wei,
>
> You don't need these function declarations at all. What do you think
> removing these first, in a separate patch, and won't need to update them
> here?
>
> Also it is possible to remove all function declarations if you move
> "ixgbe_flow_ops" at the end of the file, that would be something I prefer,
> but it is your call.
>
> Thanks,
> Ferruh
Sorry for late reply, I have just find your mail just now.
I think your suggestion is very good from code style, but this patch is a fix patch set for a P2 issue.
So, it is not focus on code style. code style can be changed in
a separate patch if we need to and not mix them together?
next prev parent reply other threads:[~2017-03-06 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 7:35 Wei Zhao
2017-02-17 16:01 ` Ferruh Yigit
2017-03-06 7:44 ` Zhao1, Wei [this message]
2017-03-08 8:54 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA02056712@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).