From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check
Date: Thu, 27 Apr 2017 06:07:08 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA02081351@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B59B4DA@shsmsx102.ccr.corp.intel.com>
Hi, wenzhuo
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Friday, April 21, 2017 10:35 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Zhao1, Wei <wei.zhao1@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type
> check
>
> Hi Wei,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Thursday, April 20, 2017 11:28 AM
> > To: dev@dpdk.org
> > Cc: Zhao1, Wei
> > Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type
> > check
> >
> > Remove a useless item type check for fdir flow rule.
> >
> > Fixes: 11777435c72 ("net/ixgbe: parse flow director filter")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_flow.c | 9 +--------
> > 1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > b/drivers/net/ixgbe/ixgbe_flow.c index 7ce740e..11d8cc9 100644
> > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > @@ -2346,16 +2346,9 @@ ixgbe_parse_fdir_filter_tunnel(const struct
> > rte_flow_attr *attr,
> > RTE_FLOW_ERROR_TYPE_ITEM,
> > item, "Not supported by fdir filter");
> > return -rte_errno;
> > - } else if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> > - memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> > - rte_flow_error_set(error, EINVAL,
> > - RTE_FLOW_ERROR_TYPE_ITEM,
> > - item, "Not supported by fdir filter");
> > - return -rte_errno;
> > }
> Seems the item type only can be END. Why not remove the VLAN check
> either?
Ok， I will commit a new v2 for this.
>
> > +
> > /* check if the next not void item is END */
> > - index++;
> > - NEXT_ITEM_OF_PATTERN(item, pattern, index);
> > if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> > memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> > rte_flow_error_set(error, EINVAL,
> > --
> > 2.9.3
next prev parent reply other threads:[~2017-04-27 6:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 3:27 Wei Zhao
2017-04-20 3:27 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
2017-04-21 2:48 ` Lu, Wenzhuo
2017-04-27 6:01 ` Zhao1, Wei
2017-04-21 2:35 ` [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
2017-04-27 6:07 ` Zhao1, Wei [this message]
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 " Wei Zhao
2017-04-27 6:34 ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix a error type check for flow type Wei Zhao
2017-04-27 7:14 ` Lu, Wenzhuo
2017-04-27 7:15 ` [dpdk-dev] [PATCH v2 1/2] net/ixgbe: remove a useless item type check Lu, Wenzhuo
2017-04-27 9:17 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA02081351@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).