From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix checksum valid flags error
Date: Tue, 2 May 2017 08:40:25 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA02083F85@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B59EA99@shsmsx102.ccr.corp.intel.com>
Hi, wenzhuo
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Tuesday, May 2, 2017 4:14 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] net/e1000: fix checksum valid flags error
>
> Hi Wei,
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Tuesday, May 2, 2017 10:46 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo; Zhao1, Wei
> > Subject: [PATCH] net/e1000: fix checksum valid flags error
> >
> > This problem is caused by a missing set of E1000_RXCSUM_CRCOFL in
> > eth_igb_rx_init(), it should be set to enable SCTP packet
> > L4 checksum.If it is not set, the printf message in cksum fwd about L4
> > SCTP cksum flag is error.
> It's not quite clear what's the issue. Would you like to add more details?
> Thanks.
>
> >
> > Fixes: d15fcf76c8b7 ("net/e1000: move to drivers/net/")
> Seems it's not the right patch. Suppose this patch only moves the files.
I will fix it in v2.
>
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/e1000/igb_rxtx.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/e1000/igb_rxtx.c
> > b/drivers/net/e1000/igb_rxtx.c index b3b601b..6c2749b 100644
> > --- a/drivers/net/e1000/igb_rxtx.c
> > +++ b/drivers/net/e1000/igb_rxtx.c
> > @@ -2402,10 +2402,11 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
> >
> > /* Enable both L3/L4 rx checksum offload */
> > if (dev->data->dev_conf.rxmode.hw_ip_checksum)
> > - rxcsum |= (E1000_RXCSUM_IPOFL |
> E1000_RXCSUM_TUOFL);
> > + rxcsum |= (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL
> |
> > + E1000_RXCSUM_CRCOFL);
> > else
> > - rxcsum &= ~(E1000_RXCSUM_IPOFL |
> E1000_RXCSUM_TUOFL);
> > - E1000_WRITE_REG(hw, E1000_RXCSUM, rxcsum);
> > + rxcsum &= ~(E1000_RXCSUM_IPOFL |
> E1000_RXCSUM_TUOFL
> > |
> > + E1000_RXCSUM_CRCOFL);
> >
> > /* Setup the Receive Control Register. */
> > if (dev->data->dev_conf.rxmode.hw_strip_crc) {
> > --
> > 2.9.3
next prev parent reply other threads:[~2017-05-02 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 2:46 Wei Zhao
2017-05-02 8:13 ` Lu, Wenzhuo
2017-05-02 8:40 ` Zhao1, Wei [this message]
2017-05-02 8:42 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2017-05-31 3:03 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2017-05-31 3:35 ` Lu, Wenzhuo
2017-06-01 11:08 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA02083F85@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).