From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix flow RSS queue index check error
Date: Tue, 10 Apr 2018 01:54:54 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07D09830@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E706115318D355@SHSMSX103.ccr.corp.intel.com>
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Monday, April 9, 2018 9:57 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v2] net/i40e: fix flow RSS queue index check error
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, April 9, 2018 4:38 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH v2] net/i40e: fix flow RSS queue index check error
> >
> > There is an error in queue index check for RSS queue region
> > configuration.If the queue index is not continuous sequence for RSS,
> > but queue region index is continuous sequence, in this case we can not
> > use the old method for queue index check.
> > This patch also add comment for flow rss parse function in order to
> > explain some important info.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
> >
> > ---
> >
> > v2:
> > -merge this with another patch for function comment, add git log info.
> > ---
> > drivers/net/i40e/i40e_flow.c | 32 +++++++++++++++++++++-----------
> > 1 file changed, 21 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index
> > f4d08bb..40f15c2 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -4171,6 +4171,19 @@ i40e_flow_parse_rss_pattern(__rte_unused
> struct
> > rte_eth_dev *dev,
> > return 0;
> > }
> >
> > +/**
> > + * This function is used to parse rss queue index, total queue number
> > +and
> > + * hash functions, If the purpose of this configuration is for queue
> > +region
> > + * configuration, it will set queue_region_conf flag to TRUE, else to FALSE.
> > + * In queue region configuration, it also need to parse hardware
> > +flowtype
> > + * and user_priority from configuration, it will also cheeck the
> > +validity
> > + * of these parameters. For example, The queue region sizes should
> > + * be any of the following values: 1, 2, 4, 8, 16, 32, 64, the
> > + * hw_flowtype or PCTYPE max index should be 63, the user priority
> > + * max index should be 7, and so on. And also, queue index should be
> > + * continuous sequence and queue region index should be part of rss
> > + * queue index for this port.
> > + */
> > static int
> > i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
> > const struct rte_flow_action *actions, @@ -4240,6
> > +4253,14 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
> > return -rte_errno;
> > }
> > }
> > +
> > + if (rss_info->num < rss->num) {
> > + rte_flow_error_set(error, EINVAL,
> > + RTE_FLOW_ERROR_TYPE_ACTION,
> > + act,
> > + "no valid queues");
> > + return -rte_errno;
> > + }
> > }
> >
> > for (n = 0; n < conf_info->queue_region_number; n++) { @@ -
> 4264,17
> > +4285,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
> > return -rte_errno;
> > }
> >
> > - if (rss_info->num < rss->num ||
> > - rss->queue[0] < rss_info->queue[0] ||
> > - (rss->queue[0] + rss->num >
> > - rss_info->num + rss_info->queue[0]))
> {
> > - rte_flow_error_set(error, EINVAL,
> > - RTE_FLOW_ERROR_TYPE_ACTION,
> > - act,
> > - "no valid queues");
> > - return -rte_errno;
> > - }
>
> Is this a code clean?
> I didn't see anything wrong with the code you removed, but they just looks
> redundant.
> Btw why you still check (rss_info->num < rss->num) ?, previous, I think you
> already iterate all rss queue to make sure they are matched by a rss_info
> queue so it already proved rss_info->num >= rss->num.
what you said is reasonable, so I will commit v3 To delete this (rss_info->num < rss->num) check.
>
>
> > for (i = 0; i < info->queue_region_number; i++) {
> > if (info->region[i].queue_num == rss->num
> &&
> > info->region[i].queue_start_index ==
> > --
> > 2.7.5
next prev parent reply other threads:[~2018-04-10 1:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 5:37 [dpdk-stable] [PATCH] " Wei Zhao
2018-04-09 7:18 ` Zhang, Qi Z
2018-04-09 8:37 ` [dpdk-stable] [PATCH v2] " Wei Zhao
2018-04-09 13:57 ` Zhang, Qi Z
2018-04-10 1:54 ` Zhao1, Wei [this message]
2018-04-10 2:19 ` Zhao1, Wei
2018-04-10 10:45 ` Zhang, Qi Z
2018-04-11 2:53 ` Zhao1, Wei
2018-04-11 3:24 ` [dpdk-stable] [PATCH v3] net/i40e: add comment and clean code for flow RSS Wei Zhao
2018-04-11 12:30 ` Zhang, Qi Z
2018-04-12 0:12 ` [dpdk-stable] [dpdk-dev] " Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07D09830@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).