From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR
Date: Tue, 12 Jun 2018 03:18:10 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07DFC951@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B7E8415@shsmsx102.ccr.corp.intel.com>
Hi， wenzhuo
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Tuesday, June 12, 2018 10:42 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Tuesday, June 12, 2018 10:31 AM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> > Cc: stable@dpdk.org
> > Subject: RE: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR
> >
> > Hi, wenzhuo
> >
> > > -----Original Message-----
> > > From: Lu, Wenzhuo
> > > Sent: Tuesday, June 12, 2018 10:26 AM
> > > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> > > Cc: stable@dpdk.org
> > > Subject: RE: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR
> > >
> > > Hi Wei,
> > >
> > >
> > > > -----Original Message-----
> > > > From: Zhao1, Wei
> > > > Sent: Tuesday, June 5, 2018 5:12 PM
> > > > To: dev@dpdk.org
> > > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; stable@dpdk.org; Zhao1,
> > > > Wei <wei.zhao1@intel.com>
> > > > Subject: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR
> > > >
> > > > In IP mode FDIR, X550 can support not only 4 tuple parameters but
> > > > also vlan tci in protocol, so add this feature to flow parser.
> > > >
> > > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> > > >
> > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > > ---
>
> > >
> > > > item = next_no_void_pattern(pattern, item);
> > > > - if (item->type != RTE_FLOW_ITEM_TYPE_IPV4) {
> > > > + if (item->type != RTE_FLOW_ITEM_TYPE_IPV4 &&
> > > > + item->type != RTE_FLOW_ITEM_TYPE_VLAN)
> > > {
> > > > rte_flow_error_set(error,
> > > > EINVAL, RTE_FLOW_ERROR_TYPE_ITEM,
> > > > item, "Not supported by ntuple filter");
> > > Really confused. I see the above code is already wrapped by " if
> > > (item->type == RTE_FLOW_ITEM_TYPE_VLAN) {". You want to support
> > double vlan?
> >
> > No, I have get a report that some use the following mode
> > sendp([Ether(dst="A0:36:9F:BD:5D:B0")/Dot1Q(vlan=1)/IP(src="192.168.0.
> > 1",d st="192.168.0.2",tos=2,ttl=40)/UDP(dport=23,
> > sport=22)/Raw('x'*100)],iface="enp3s0f0",count=10)
> > to test fdir IP mode.
> > In order to support this, we need this patch.
> I can understand the change in ' ixgbe_parse_fdir_filter_normal' is to support
> this case.
> What I cannot understand is the above change. The original code is already
> for the case vlan + IPv4.
>
I will commit new v2 for your comment.
next prev parent reply other threads:[~2018-06-12 3:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 9:12 [dpdk-stable] [PATCH] app/testpmd: fix VLAN tci mask set error for FDIR Wei Zhao
2018-06-05 9:12 ` [dpdk-stable] [PATCH] net/ixgbe: add query rule stats support " Wei Zhao
2018-06-12 1:46 ` Lu, Wenzhuo
2018-06-12 1:51 ` Zhao1, Wei
2018-06-12 2:07 ` Lu, Wenzhuo
2018-06-13 8:07 ` [dpdk-stable] [PATCH v2] " Wei Zhao
2018-06-13 8:08 ` Wei Zhao
2018-06-14 0:36 ` Lu, Wenzhuo
2018-06-21 14:08 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2018-06-05 9:12 ` [dpdk-stable] [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR Wei Zhao
2018-06-12 2:25 ` Lu, Wenzhuo
2018-06-12 2:30 ` Zhao1, Wei
2018-06-12 2:41 ` Lu, Wenzhuo
2018-06-12 2:49 ` Zhao1, Wei
2018-06-12 3:18 ` Zhao1, Wei [this message]
2018-06-13 8:09 ` [dpdk-stable] [PATCH v2] " Wei Zhao
2018-06-14 0:37 ` Lu, Wenzhuo
2018-06-21 14:09 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2018-06-05 9:12 ` [dpdk-stable] [PATCH] net/ixgbe: fix tunnel id format error for FDIR Wei Zhao
2018-06-12 5:10 ` Lu, Wenzhuo
2018-06-12 7:49 ` Zhao1, Wei
2018-06-12 8:39 ` Lu, Wenzhuo
2018-06-12 8:43 ` Zhao1, Wei
2018-06-13 8:11 ` [dpdk-stable] [PATCH v2] " Wei Zhao
2018-06-14 0:38 ` Lu, Wenzhuo
2018-06-21 14:10 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2018-06-05 9:12 ` [dpdk-stable] [PATCH] net/ixgbe: fix tunnel type set " Wei Zhao
2018-06-13 8:11 ` [dpdk-stable] [PATCH v2] " Wei Zhao
2018-06-14 0:41 ` Lu, Wenzhuo
2018-06-14 1:51 ` Zhao1, Wei
2018-06-14 8:17 ` [dpdk-stable] [PATCH v3] " Wei Zhao
2018-06-15 0:50 ` Lu, Wenzhuo
2018-06-21 14:11 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2018-06-12 1:12 ` [dpdk-stable] [PATCH] app/testpmd: fix VLAN tci mask " Lu, Wenzhuo
2018-06-21 14:27 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07DFC951@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).