From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: fix mask bits register set error for FDIR
Date: Thu, 14 Jun 2018 01:52:10 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07DFD006@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B7E8F6B@shsmsx102.ccr.corp.intel.com>
Hi, wenzhuo
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Thursday, June 14, 2018 8:53 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/ixgbe: fix mask bits register set error for FDIR
>
> Hi Wei,
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Wednesday, June 13, 2018 4:12 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; stable@dpdk.org; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/ixgbe: fix mask bits register set error for FDIR
> >
> > MAC address bits in mask registers should be set to zero when the is
> > mac mask is 0xFF, otherwise if it is 0x0 these bits should be to 0x3F.
> >
> > Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for
> > X550")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_fdir.c | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_fdir.c
> > b/drivers/net/ixgbe/ixgbe_fdir.c index 3feb815..6d97aa3 100644
> > --- a/drivers/net/ixgbe/ixgbe_fdir.c
> > +++ b/drivers/net/ixgbe/ixgbe_fdir.c
> > @@ -394,9 +394,15 @@ fdir_set_input_mask_x550(struct rte_eth_dev
> *dev)
> > IXGBE_FDIRIP6M_TNI_VNI;
> >
> > if (mode == RTE_FDIR_MODE_PERFECT_TUNNEL) {
> > - mac_mask = info->mask.mac_addr_byte_mask;
> > - fdiripv6m |= (mac_mask <<
> > IXGBE_FDIRIP6M_INNER_MAC_SHIFT)
> > - & IXGBE_FDIRIP6M_INNER_MAC;
> > + mac_mask = info->mask.mac_addr_byte_mask & 0x3F;
> Better not use 0x3f, you can change it to "IXGBE_FDIRIP6M_INNER_MAC >>
> IXGBE_FDIRIP6M_INNER_MAC_SHIFT"
>
> > + if (mac_mask == 0x3F)
> > + fdiripv6m &= ~IXGBE_FDIRIP6M_INNER_MAC;
> > + else if (mac_mask == 0)
> > + fdiripv6m |= IXGBE_FDIRIP6M_INNER_MAC;
> > + else{
> > + PMD_INIT_LOG(ERR, "invalid
> mac_addr_byte_mask");
> > + return -EINVAL;
> I think every byte of the MAC address can be masked. So this is not the
> invalid case. We should support 0x1f, 0xf, 0x7... as before.
Ok, I will commit v3
>
> > + }
> >
> > switch (info->mask.tunnel_type_mask) {
> > case 0:
> > --
> > 2.7.5
next prev parent reply other threads:[~2018-06-14 1:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 8:12 Wei Zhao
2018-06-14 0:52 ` Lu, Wenzhuo
2018-06-14 1:52 ` Zhao1, Wei [this message]
2018-06-14 7:21 ` [dpdk-stable] [PATCH v2] " Wei Zhao
2018-06-15 2:30 ` [dpdk-stable] [PATCH v3] " Wei Zhao
2018-06-15 3:10 ` [dpdk-stable] [PATCH v4] " Wei Zhao
2018-06-15 6:08 ` [dpdk-stable] [PATCH v5] " Wei Zhao
2018-06-19 0:57 ` Lu, Wenzhuo
2018-06-21 14:12 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07DFD006@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).