From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: Luca Boccassi <bluca@debian.org>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set
Date: Mon, 8 Oct 2018 08:43:04 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07E4B7DE@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <20180727172607.16890-1-bluca@debian.org>
Hi, Luca Boccassi
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Luca Boccassi
> Sent: Saturday, July 28, 2018 1:26 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Luca Boccassi
> <bluca@debian.org>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set
>
> rx_drop_en is an optimization that does nothing on single-queue devices like
> e1000. Do not force applications that do not care to select per-devices
And aslo, eth_em_rx_queue_setup support set up of multiple queues for EM device.
> optimizations flags by returning an error, just log it and carry on.
rx_drop_en is a flag to enable receive packets drop when insufficient receive descriptors exist to write the packet into system memory.
if we delete this parameter check protection, it may be misleading some applications for this point, why does not give some requirement
for proper usage of this? I do not suggest for this change.
You can also refer to function eth_igb_rx_queue_setup(), igb device support rx_drop_en set, so we do not have a such parameter check.
>
> Fixes: 805803445a02 ("e1000: support EM devices (also known as
> e1000/e1000e)")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> drivers/net/e1000/em_rxtx.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c
> index a6b3e92a6..81dc41efb 100644
> --- a/drivers/net/e1000/em_rxtx.c
> +++ b/drivers/net/e1000/em_rxtx.c
> @@ -1416,12 +1416,13 @@ eth_em_rx_queue_setup(struct rte_eth_dev
> *dev,
> }
>
> /*
> - * EM devices don't support drop_en functionality
> + * EM devices don't support drop_en functionality.
> + * It's an optimization that does nothing on single-queue devices,
> + * so just log the issue and carry on.
> */
> if (rx_conf->rx_drop_en) {
> - PMD_INIT_LOG(ERR, "drop_en functionality not supported
> by "
> + PMD_INIT_LOG(NOTICE, "drop_en functionality not
> supported by "
> "device");
> - return -EINVAL;
> }
>
> /* Free memory prior to re-allocation if needed. */
> --
> 2.18.0
next prev parent reply other threads:[~2018-10-08 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 17:26 [dpdk-stable] " Luca Boccassi
2018-09-26 10:22 ` Luca Boccassi
2018-10-08 8:43 ` Zhao1, Wei [this message]
2018-10-08 14:14 ` [dpdk-stable] [dpdk-dev] " Luca Boccassi
2018-10-10 7:25 ` Zhao1, Wei
2018-10-10 17:57 ` Zhang, Qi Z
2018-10-08 9:49 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07E4B7DE@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).