From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Wang, Dong1" <dong1.wang@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-stable] [PATCH] examples/ipv4_multicast: remove useless mbuf info copy
Date: Wed, 21 Nov 2018 10:17:41 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07E76CB0@PGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <1542793757-52622-1-git-send-email-wei.zhao1@intel.com>
Add the background for this patch
https://mails.dpdk.org/archives/dev/2018-November/119391.html
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, November 21, 2018 5:49 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] examples/ipv4_multicast: remove useless mbuf info copy
>
> There is not need for these useless information and it had better be
> removed in oder not to confusing users.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> examples/ipv4_multicast/main.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/examples/ipv4_multicast/main.c
> b/examples/ipv4_multicast/main.c index 428ca46..1eef291 100644
> --- a/examples/ipv4_multicast/main.c
> +++ b/examples/ipv4_multicast/main.c
> @@ -254,18 +254,10 @@ mcast_out_pkt(struct rte_mbuf *pkt, int use_clone)
> /* prepend new header */
> hdr->next = pkt;
>
> -
> /* update header's fields */
> hdr->pkt_len = (uint16_t)(hdr->data_len + pkt->pkt_len);
> hdr->nb_segs = pkt->nb_segs + 1;
>
> - /* copy metadata from source packet*/
> - hdr->port = pkt->port;
> - hdr->vlan_tci = pkt->vlan_tci;
> - hdr->vlan_tci_outer = pkt->vlan_tci_outer;
> - hdr->tx_offload = pkt->tx_offload;
> - hdr->hash = pkt->hash;
> -
> __rte_mbuf_sanity_check(hdr, 1);
> return hdr;
> }
> --
> 2.7.5
next prev parent reply other threads:[~2018-11-21 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 9:49 Wei Zhao
2018-11-21 10:17 ` Zhao1, Wei [this message]
2018-12-19 21:28 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07E76CB0@PGSMSX101.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=dong1.wang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).