From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: David Harton <dharton@cisco.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef
Date: Fri, 8 Mar 2019 06:35:19 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07EC3163@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <20190306152355.1697-1-dharton@cisco.com>
Hi, David Harton
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton
> Sent: Wednesday, March 6, 2019 11:24 PM
> To: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>
> Cc: David Harton <dharton@cisco.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for
> ixgbvef
>
> ixgevf vlan strip and extend capabilities were removed when migrating to the
> bit flags implementation.
>
> Restoring the capbility to enable these offloads at configuration time.
>
> Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
> Signed-off-by: David Harton <dharton@cisco.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index e92a70fb3..95c32257c 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
> *dev)
> DEV_RX_OFFLOAD_TCP_CKSUM |
> DEV_RX_OFFLOAD_KEEP_CRC |
> DEV_RX_OFFLOAD_JUMBO_FRAME |
> + DEV_RX_OFFLOAD_VLAN_FILTER |
> + DEV_RX_OFFLOAD_VLAN_EXTEND |
> DEV_RX_OFFLOAD_SCATTER;
>
Why do we set DEV_RX_OFFLOAD_VLAN_EXTEND for ixgbevf ?
It seems Ixgbevf do not support this configuration. Only pf does.
But this ixgbe_get_rx_port_offloads () is used by both vf and pf.
> if (hw->mac.type == ixgbe_mac_82598EB)
> offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
>
> - if (ixgbe_is_vf(dev) == 0)
> - offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
> - DEV_RX_OFFLOAD_VLAN_EXTEND);
> -
> /*
> * RSC is only supported by 82599 and x540 PF devices in a non-SR-
> IOV
> * mode.
> --
> 2.19.1
next prev parent reply other threads:[~2019-03-08 6:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 15:23 David Harton
2019-03-07 13:11 ` Zhang, Qi Z
2019-03-07 14:01 ` David Harton (dharton)
2019-03-08 6:35 ` Zhao1, Wei [this message]
2019-03-08 12:38 ` David Harton (dharton)
2019-03-11 2:02 ` Zhao1, Wei
2019-03-08 20:34 ` [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf David Harton
2019-03-14 13:37 ` David Harton (dharton)
2019-03-14 13:37 ` David Harton (dharton)
2019-03-14 15:14 ` Zhang, Qi Z
2019-03-14 15:14 ` Zhang, Qi Z
2019-03-14 15:51 ` David Harton (dharton)
2019-03-14 15:51 ` David Harton (dharton)
2019-03-15 1:20 ` Zhang, Qi Z
2019-03-15 1:20 ` Zhang, Qi Z
2019-03-15 4:13 ` Zhao1, Wei
2019-03-15 4:13 ` Zhao1, Wei
2019-03-15 5:28 ` Zhao1, Wei
2019-03-15 5:28 ` Zhao1, Wei
2019-03-15 7:36 ` Zhang, Qi Z
2019-03-15 7:36 ` Zhang, Qi Z
2019-03-15 9:23 ` Ananyev, Konstantin
2019-03-15 9:23 ` Ananyev, Konstantin
2019-03-15 9:35 ` Zhao1, Wei
2019-03-15 9:35 ` Zhao1, Wei
2019-03-15 12:59 ` Ananyev, Konstantin
2019-03-15 12:59 ` Ananyev, Konstantin
2019-03-18 3:13 ` Zhao1, Wei
2019-03-18 3:13 ` Zhao1, Wei
2019-03-15 12:26 ` [dpdk-dev] [PATCH v3] " David Harton
2019-03-15 12:26 ` David Harton
2019-03-15 16:08 ` [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter " David Harton
2019-03-15 16:08 ` David Harton
2019-03-18 3:05 ` Zhao1, Wei
2019-03-18 3:05 ` Zhao1, Wei
2019-03-18 4:59 ` Zhang, Qi Z
2019-03-18 4:59 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07EC3163@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).