From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"pmatilai@redhat.com" <pmatilai@redhat.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] drivers/net:new PMD using tun/tap host interface
Date: Tue, 11 Oct 2016 20:57:27 +0000 [thread overview]
Message-ID: <A6C0D06C-6370-4776-9648-0C8936350203@intel.com> (raw)
In-Reply-To: <a18b8930-9bcf-a5df-7d7f-cff5bc239160@intel.com>
Regards,
Keith
> On Oct 11, 2016, at 7:28 AM, Yigit, Ferruh <ferruh.yigit@intel.com> wrote:
>
> On 10/4/2016 3:45 PM, Keith Wiles wrote:
>> +/*
>> + * Open a TAP interface device.
>> + */
>> +static int
>> +rte_pmd_tap_devinit(const char *name, const char *params)
>> +{
>> + int ret = 0;
>> + struct rte_kvargs *kvlist;
>> + struct tap_info tap_info;
>> +
>> + /* Setup default values */
>> + memset(&tap_info, 0, sizeof(tap_info));
>> +
>> + tap_info.speed = ETH_SPEED_NUM_10G;
>> + snprintf(tap_info.name, sizeof(tap_info.name), "dtap%d", tap_unit++);
>> +
>> + if ((params == NULL) || (params[0] == '\0')) {
>> + RTE_LOG(INFO, PMD, "Initializing pmd_tap for %s\n", name);
>> +
>> + ret = eth_dev_tap_create(name, &tap_info);
>> + goto leave;
>> + }
>> +
>> + RTE_LOG(INFO, PMD, "Initialize %s with params (%s)\n", name, params);
>> +
>> + kvlist = rte_kvargs_parse(params, valid_arguments);
>> + if (!kvlist) {
>> + ret = eth_dev_tap_create(name, &tap_info);
>> + goto leave;
>> + }
>> +
>> + if (rte_kvargs_count(kvlist, ETH_TAP_SPEED_ARG) == 1) {
>> + ret = rte_kvargs_process(kvlist, ETH_TAP_SPEED_ARG,
>> + &set_interface_speed, &tap_info);
>> + if (ret < 0)
>> + goto leave;
>> + } else
>> + set_interface_speed(NULL, NULL, &tap_info);
>> +
>> + if (rte_kvargs_count(kvlist, ETH_TAP_IFACE_ARG) == 1) {
>> + ret = rte_kvargs_process(kvlist, ETH_TAP_IFACE_ARG,
>> + &set_interface_name, &tap_info);
>> + if (ret < 0)
>> + goto leave;
>> + } else
>> + set_interface_name(NULL, NULL, (void *)&tap_info);
>
> Also there must be a eth_dev_tap_create() call after this point to use
> tap_info struct with custom values, right?
> "--vdev eth_tap0,iface=foo0" parameter shouldn't be working with this
> code, right?
Removed the extra code.
>
>> +
>> + rte_kvargs_free(kvlist);
>> +
>> +leave:
>> + if (ret == -1)
>> + RTE_LOG(INFO, PMD, "Failed to create pmd_tap for %s\n", name);
>> +
>> + return ret;
>> +}
>
next prev parent reply other threads:[~2016-10-11 20:57 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 14:10 [dpdk-dev] [PATCH 1/3] " Keith Wiles
2016-09-15 14:10 ` [dpdk-dev] [PATCH 2/3] docs:tun/tap PMD information Keith Wiles
2016-09-15 14:13 ` Wiles, Keith
2016-09-15 14:15 ` Wiles, Keith
2016-09-21 2:00 ` [dpdk-dev] [PATCH v3] drivers/net:new PMD using tun/tap host interface Keith Wiles
2016-10-04 14:45 ` [dpdk-dev] [PATCH v4] " Keith Wiles
2016-10-11 9:40 ` Ferruh Yigit
2016-10-11 11:30 ` Michał Mirosław
2016-10-11 20:56 ` Wiles, Keith
2016-10-12 8:14 ` Michał Mirosław
2016-10-11 11:49 ` Ferruh Yigit
2016-10-11 21:07 ` Wiles, Keith
2016-10-11 12:28 ` Ferruh Yigit
2016-10-11 20:57 ` Wiles, Keith [this message]
2016-10-11 21:51 ` [dpdk-dev] [PATCH v5] " Keith Wiles
2016-10-12 14:56 ` Ferruh Yigit
2016-10-12 18:19 ` Wiles, Keith
2016-10-12 19:57 ` Wiles, Keith
2016-10-12 20:54 ` [dpdk-dev] [PATCH v6] " Keith Wiles
2016-10-13 14:41 ` Ferruh Yigit
2016-10-13 15:36 ` [dpdk-dev] [PATCH v7] " Keith Wiles
2016-10-13 16:11 ` [dpdk-dev] [PATCH v8] " Keith Wiles
2016-10-13 16:33 ` Mcnamara, John
2016-10-13 22:03 ` [dpdk-dev] [PATCH v9] " Keith Wiles
2016-10-14 6:41 ` Mcnamara, John
2016-10-14 9:39 ` Ferruh Yigit
2016-11-21 12:56 ` Ferruh Yigit
2016-11-25 19:38 ` Aws Ismail
2016-11-29 21:36 ` Aws Ismail
2016-11-29 22:16 ` Wiles, Keith
2016-12-07 19:38 ` [dpdk-dev] [PATCH v10] drivers/net:new TUN/TAP device PMD Keith Wiles
2016-12-07 20:15 ` Aws Ismail
2016-12-09 18:16 ` Ferruh Yigit
2016-12-09 19:05 ` [dpdk-dev] [PATCH v11] " Keith Wiles
2016-12-12 12:39 ` Vasily Philipov
2016-12-12 14:24 ` [dpdk-dev] [PATCH v12] net/tap: new " Keith Wiles
2016-12-12 14:38 ` Keith Wiles
2016-12-12 19:13 ` Marc
2016-12-12 21:09 ` Wiles, Keith
2016-12-13 13:54 ` Ferruh Yigit
2017-01-20 12:14 ` Ferruh Yigit
2017-01-20 14:25 ` [dpdk-dev] [PATCH] net/tap: fix IFF_MULTI_QUEUE in older kernels not found Keith Wiles
2017-01-20 14:30 ` Keith Wiles
2017-01-20 16:11 ` Ferruh Yigit
2017-01-20 17:37 ` Thomas Monjalon
2016-09-15 14:10 ` [dpdk-dev] [PATCH 3/3] drivers/net:build support for new tap device driver Keith Wiles
2016-09-16 7:36 ` Panu Matilainen
2016-09-16 14:46 ` Wiles, Keith
2016-09-16 16:22 ` [dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface Keith Wiles
2016-09-18 13:25 ` Yuanhan Liu
2016-09-18 16:20 ` Wiles, Keith
2016-09-19 0:29 ` Yuanhan Liu
2016-09-19 15:56 ` Wiles, Keith
2016-09-20 3:54 ` Yuanhan Liu
2016-09-20 4:05 ` Yuanhan Liu
2016-09-21 1:32 ` Wiles, Keith
2016-09-21 2:13 ` Yuanhan Liu
2016-09-21 8:24 ` Thomas Monjalon
2016-09-21 23:55 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A6C0D06C-6370-4776-9648-0C8936350203@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pmatilai@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).