From: "Chen, Junjie J" <junjie.j.chen@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>,
"yliu@fridaylinux.org" <yliu@fridaylinux.org>,
"maxime.coquein@redhat.com" <maxime.coquein@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] doc: add driver limitation for vhost dequeue zero copy
Date: Tue, 13 Mar 2018 09:19:51 +0000 [thread overview]
Message-ID: <AA85A5A5E706C44BACB0BEFD5AC08BF631388E31@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <3d82fe68-5f76-7f38-ffb7-08cc4021da53@intel.com>
Hi Jianfeng.
> -----Original Message-----
> From: Tan, Jianfeng
> Sent: Monday, March 12, 2018 11:15 AM
> To: Chen, Junjie J <junjie.j.chen@intel.com>; yliu@fridaylinux.org;
> maxime.coquein@redhat.com
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v3] doc: add driver limitation for vhost dequeue zero copy
>
>
>
> On 3/9/2018 6:07 PM, Junjie Chen wrote:
> > In vhost-switch example, when binding nic to vfio-pci with iommu
> > enabled, dequeue zero copy cannot work in VM2NIC mode due to no iommu
> > dma mapping is setup for guest memory currently.
> >
> > Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> > ---
> > Changes in V3:
> > - update limitation to iommu
> > Changes in V2:
> > - add doc in vhost lib
> >
> > doc/guides/prog_guide/vhost_lib.rst | 5 +++++
> > doc/guides/sample_app_ug/vhost.rst | 5 ++++-
> > 2 files changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/doc/guides/prog_guide/vhost_lib.rst
> > b/doc/guides/prog_guide/vhost_lib.rst
> > index 18227b6..06d214f 100644
> > --- a/doc/guides/prog_guide/vhost_lib.rst
> > +++ b/doc/guides/prog_guide/vhost_lib.rst
> > @@ -83,6 +83,11 @@ The following is an overview of some key Vhost API
> functions:
> > of those segments, thus the fewer the segments, the quicker we will
> get
> > the mapping. NOTE: we may speed it by using tree searching in
> future.
> >
> > + * zero copy does not work when using driver with iommu mode
> > + currently, this
>
> Considering FreeBSD driver nic_uio does not support iommu, we can make
> "driver" more explicitly. For example,
>
> "driver with iommu mode" -> "vfio-pci with iommu mode"
Will update.
>
> > + is because we don't setup iommu dma mapping for guest memory.
>
> > For example, when you bind device to vfio-pci driver, you need to set driver to
> work in noiommu mode.
>
> Reword the above sentence a little bit:
> "If vfio-pci is a must in your case, insert vfio-pci kernel module in noiommu
> mode."
Will update, thanks.
> > +
> > - ``RTE_VHOST_USER_IOMMU_SUPPORT``
> >
> > IOMMU support will be enabled when this flag is set. It is
> > disabled by diff --git a/doc/guides/sample_app_ug/vhost.rst
> > b/doc/guides/sample_app_ug/vhost.rst
> > index a4bdc6a..f0bb169 100644
> > --- a/doc/guides/sample_app_ug/vhost.rst
> > +++ b/doc/guides/sample_app_ug/vhost.rst
> > @@ -147,7 +147,10 @@ retries on an RX burst, it takes effect only when rx
> retry is enabled. The
> > default value is 15.
> >
> > **--dequeue-zero-copy**
> > -Dequeue zero copy will be enabled when this option is given.
> > +Dequeue zero copy will be enabled when this option is given. it is
> > +worth to note that if NIC is binded to driver with iommu enabled,
> > +dequeue zero copy cannot work at VM2NIC mode (vm2vm=0) due to
> > +currently we don't setup iommu dma mapping for guest memory.
> >
> > **--vlan-strip 0|1**
> > VLAN strip option is removed, because different NICs have different
> > behaviors
next prev parent reply other threads:[~2018-03-13 9:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 14:44 [dpdk-dev] [PATCH] " Junjie Chen
2018-02-26 4:44 ` Tan, Jianfeng
2018-03-13 9:12 ` Kovacevic, Marko
2018-03-13 9:18 ` Chen, Junjie J
2018-02-27 9:21 ` [dpdk-dev] [PATCH v2] " Junjie Chen
2018-03-06 8:57 ` Maxime Coquelin
2018-03-09 5:17 ` Chen, Junjie J
2018-03-09 10:07 ` [dpdk-dev] [PATCH v3] " Junjie Chen
2018-03-12 3:15 ` Tan, Jianfeng
2018-03-13 9:19 ` Chen, Junjie J [this message]
2018-03-14 16:24 ` [dpdk-dev] [PATCH v4] " Junjie Chen
2018-03-19 6:56 ` Tan, Jianfeng
2018-03-29 12:14 ` Maxime Coquelin
2018-04-11 14:34 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AA85A5A5E706C44BACB0BEFD5AC08BF631388E31@SHSMSX101.ccr.corp.intel.com \
--to=junjie.j.chen@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquein@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).