From: "Wiles, Keith" <keith.wiles@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
Ori Kam <orika@mellanox.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/tap: fix reported number of Tx packets
Date: Wed, 10 Oct 2018 12:39:47 +0000 [thread overview]
Message-ID: <ABF9CF48-7FD0-4284-B197-32FD48BE2CB8@intel.com> (raw)
In-Reply-To: <1539154893-20548-1-git-send-email-rasland@mellanox.com>
> On Oct 10, 2018, at 2:01 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
>
> When writev fails to send packets it doesn't update the
> number of Tx packets, but it still num_tx is updated.
>
> the value that should be returned is the actual number
> of sent packets which is num_packets.
>
> Fixes: 02f96a0a ("net/tap: add TUN/TAP device PMD")
> CC: stable@dpdk.org
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Acked-by: Keith Wiles <keith.wiles@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 83c9288..228add2 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -707,7 +707,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> txq->stats.errs += nb_pkts - num_tx;
> txq->stats.obytes += num_tx_bytes;
>
> - return num_tx;
> + return num_packets;
> }
>
> static const char *
> --
> 2.7.4
>
Regards,
Keith
next prev parent reply other threads:[~2018-10-10 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 7:01 Raslan Darawsheh
2018-10-10 12:39 ` Wiles, Keith [this message]
2018-10-16 15:19 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ABF9CF48-7FD0-4284-B197-32FD48BE2CB8@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).