From: "Zhang, Xiao" <xiao.zhang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wang, Xiao W" <xiao.w.wang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [v2] drivers/net: fix dereference after null check coverity
Date: Wed, 17 Jul 2019 01:47:34 +0000 [thread overview]
Message-ID: <AF0377F445CB2540BB46FF359C1C1BBE0116CA49@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <ddba6032-2eda-4fa5-0ecc-a1a49de1bd78@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, July 16, 2019 10:45 PM
> To: Zhang, Xiao <xiao.zhang@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> stable@dpdk.org
> Subject: Re: [dpdk-stable] [v2] drivers/net: fix dereference after null check
> coverity
>
> On 7/16/2019 3:35 PM, Zhang, Xiao wrote:
> >
> >> -----Original Message-----
> >> From: Yigit, Ferruh
> >> Sent: Tuesday, July 16, 2019 10:26 PM
> >> To: Zhang, Xiao <xiao.zhang@intel.com>; dev@dpdk.org
> >> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
> >> <xiao.w.wang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Lu,
> >> Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> >> stable@dpdk.org
> >> Subject: Re: [dpdk-stable] [v2] drivers/net: fix dereference after
> >> null check coverity
> >>
> >> On 7/16/2019 1:19 PM, Zhang, Xiao wrote:
> >>>
> >>>> -----Original Message-----
> >>>> From: Yigit, Ferruh
> >>>> Sent: Tuesday, July 16, 2019 7:55 PM
> >>>> To: Zhang, Xiao <xiao.zhang@intel.com>; dev@dpdk.org
> >>>> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
> >>>> <xiao.w.wang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Lu,
> >>>> Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> >> <qiming.yang@intel.com>;
> >>>> stable@dpdk.org
> >>>> Subject: Re: [dpdk-stable] [v2] drivers/net: fix dereference after
> >>>> null check coverity
> >>>>
> >>>> On 7/15/2019 1:15 PM, Xiao Zhang wrote:
> >>>>> This patch tries to fix the coverity issues of dereference after
> >>>>> null check.
> >>>>> The addresses of receive queue start segment for ice, avf, i40e,
> >>>>> fm10k and ixgb were not checked before use. Add check to avoid
> >>>>> coverity issues.
> >>>>>
> >>>>> Coverity issue: 343452
> >>>>> Coverity issue: 343407
> >>>>> Fixes: c68a52b8 ("net/ice: support vector SSE in Rx") Coverity issue:
> >>>>> 343447
> >>>>> Fixes: 319c421f ("net/avf: enable SSE Rx Tx") Coverity issue:
> >>>>> 343422 Coverity issue: 343403
> >>>>> Fixes: ca74903b ("net/i40e: extract non-x86 specific code from
> >>>>> vector
> >>>>> driver") Coverity issue: 343416
> >>>>> Fixes: fe65e1e1 ("fm10k: add vector scatter Rx") Coverity issue:
> >>>>> 13245
> >>>>> Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from
> >>>>> vector
> >>>>> driver")
> >>>>> Cc: stable@dpdk.org
> >>>>>
> >>>>> Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
> >>>>
> >>>> In patchwork status of this patch is "Superseded" but I can't find
> >>>> the patch that supersedes this patch, is the current status correct?
> >>>
> >>> Sorry, the status of the patch should be "Rejected", I have updated
> >>> the
> >> status.
> >>>
> >>
> >> Thanks for updating, why it is rejected? (self-rejected ?)
> >
> > Yes, since this issues are for different devices, I was suggested better to split
> the patch base on the device or issue ID.
> >
>
> So there will be a new version, if so can you please update the patch status as
> "Change requested"?
>
> And I think it is better to make these suggestions publicly, at least put the a quick
> summary about the decision, so that other interested parties can be aware of it
> and/or comment on it.
OK, I will update the status and follow your suggestion in the future. Thanks.
prev parent reply other threads:[~2019-07-17 1:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 12:15 Xiao Zhang
2019-07-16 11:55 ` Ferruh Yigit
2019-07-16 12:19 ` Zhang, Xiao
2019-07-16 14:26 ` Ferruh Yigit
2019-07-16 14:35 ` Zhang, Xiao
2019-07-16 14:45 ` Ferruh Yigit
2019-07-17 1:47 ` Zhang, Xiao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AF0377F445CB2540BB46FF359C1C1BBE0116CA49@SHSMSX105.ccr.corp.intel.com \
--to=xiao.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).