From: "Kuusisaari, Juhamatti" <Juhamatti.Kuusisaari@coriant.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script execution check
Date: Fri, 20 Apr 2018 04:10:37 +0000 [thread overview]
Message-ID: <AM0PR04MB4291B5A9D2E57083553570109DB40@AM0PR04MB4291.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <c884e8f7-a1e0-529d-adc5-e63887913a67@intel.com>
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Thursday, April 19, 2018 4:25 PM
> To: Kuusisaari, Juhamatti <Juhamatti.Kuusisaari@coriant.com>;
> thomas@monjalon.net
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script
> execution check
>
> On 4/19/2018 1:00 PM, Juhamatti Kuusisaari wrote:
> > Handle properly a case where DPDK_MAINTAINER_PATH is set to point to a
> > directory.
> >
> > Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
> > ---
> > devtools/get-maintainer.sh | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/devtools/get-maintainer.sh b/devtools/get-maintainer.sh
> > index 1e9eabd..b916048 100755
> > --- a/devtools/get-maintainer.sh
> > +++ b/devtools/get-maintainer.sh
> > @@ -23,7 +23,8 @@ print_usage () {
> > }
> >
> > # Requires DPDK_GETMAINTAINER_PATH devel config option set -if [ ! -x
> > "$DPDK_GETMAINTAINER_PATH" ] ; then
> > +if [ ! -f "$DPDK_GETMAINTAINER_PATH" ] ||
> > + [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then
>
> This isn't an issue but is there a reason that for exact same check you go with
> single line check in checkpatches.sh and multi line check in this file?
The line was getting long, that is the reason.
> > print_usage >&2
> > echo
> > echo 'Cannot execute DPDK_GETMAINTAINER_PATH' >&2
> >
next prev parent reply other threads:[~2018-04-20 4:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 12:00 [dpdk-dev] [PATCH v2 1/2] " Juhamatti Kuusisaari
2018-04-19 12:00 ` [dpdk-dev] [PATCH v2 2/2] " Juhamatti Kuusisaari
2018-04-19 13:24 ` Ferruh Yigit
2018-04-20 4:10 ` Kuusisaari, Juhamatti [this message]
2018-04-19 13:21 ` [dpdk-dev] [PATCH v2 1/2] " Ferruh Yigit
2018-05-22 21:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB4291B5A9D2E57083553570109DB40@AM0PR04MB4291.eurprd04.prod.outlook.com \
--to=juhamatti.kuusisaari@coriant.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).