patches for DPDK stable branches
 help / color / mirror / Atom feed

From: Shahaf Shuler <shahafs@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] net/mlx5: fix init with zero Rx queues
Date: Wed, 8 May 2019 04:44:13 +0000	[thread overview]
Message-ID: <AM0PR0502MB37951163EE1373140F2EC6E4C3320@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <0df2fcb64b1ed5250aea42b65a5791c72291cf0b.1557056580.git.dekelp@mellanox.com>

Sunday, May 5, 2019 2:44 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH v3] net/mlx5: fix init with zero Rx queues
> 
> Recent patch [1] added, at the end of mlx5_dev_configure(), a call to
> mlx5_proc_priv_init(), initializing process_private data of eth_dev.
> This call is not reached if PMD is started with zero Rx queues.
> In this case mlx5_dev_configure() returns earlier due to the check:
> 	if (rxqs_n == priv->rxqs_n)
> 		return 0;
> In such a scenario, later references to uninitialized process_private data will
> result in segmentation fault.
> For example see in function txq_uar_init().
> 
> This patch changes the check logic. The following code is executed if (rxqs_n
> != priv->rxqs_n), and skipped otherwise.
> Function mlx5_proc_priv_init() is always invoked, to ensure process_private
> data is initialized.
> 
> [1]
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> es.dpdk.org%2Fpatch%2F52629%2F&amp;data=02%7C01%7Cshahafs%40mel
> lanox.com%7C18b3d5bb065348a57ef408d6d14f6b26%7Ca652971c7d2e4d9ba
> 6a4d149256f461b%7C0%7C0%7C636926536374830910&amp;sdata=7KXyV1U7
> 9P%2Bhc4HtZ8W05m95ZYyhY0m0Yc3A9NECvwo%3D&amp;reserved=0
> 
> Fixes: 120dc4a7dcd3 ("net/mlx5: remove device register remap")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, thanks.

     prev parent reply	other threads:[~2019-05-08  4:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <02664e0b50e375e0b0d4ee05c8ad554295b0ccde.1556794185.git.dekelp@mellanox.com>
2019-05-05 11:44 ` [dpdk-stable] " Dekel Peled
2019-05-08  4:44   ` Shahaf Shuler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR0502MB37951163EE1373140F2EC6E4C3320@AM0PR0502MB3795.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).