From: Shahaf Shuler <shahafs@mellanox.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>, Matan Azrad <matan@mellanox.com>
Subject: Re: [dpdk-stable] [PATCH 06/12] net/mlx4: fix incorrect rxq errors stat
Date: Tue, 5 Mar 2019 08:19:27 +0000 [thread overview]
Message-ID: <AM0PR0502MB379567D7EC075640C64CC2EEC3720@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1551698315-2611-7-git-send-email-david.marchand@redhat.com>
Monday, March 4, 2019 1:18 PM, David Marchand:
> Subject: [PATCH 06/12] net/mlx4: fix incorrect rxq errors stat
>
> Transmit errors must not be reported in q_errors[] which is for reception.
>
> Fixes: 7fae69eeff13 ("mlx4: new poll mode driver")
> Cc: stable@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>
> Cc: Shahaf Shuler <shahafs@mellanox.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/mlx4/mlx4_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/mlx4/mlx4_ethdev.c
> b/drivers/net/mlx4/mlx4_ethdev.c index 4dae67a..41c46d3 100644
> --- a/drivers/net/mlx4/mlx4_ethdev.c
> +++ b/drivers/net/mlx4/mlx4_ethdev.c
> @@ -661,7 +661,6 @@ int mlx4_fw_version_get(struct rte_eth_dev *dev,
> char *fw_ver, size_t fw_size)
> if (idx < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> tmp.q_opackets[idx] += txq->stats.opackets;
> tmp.q_obytes[idx] += txq->stats.obytes;
> - tmp.q_errors[idx] += txq->stats.odropped;
> }
> tmp.opackets += txq->stats.opackets;
> tmp.obytes += txq->stats.obytes;
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> --
> 1.8.3.1
next prev parent reply other threads:[~2019-03-05 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1551698315-2611-1-git-send-email-david.marchand@redhat.com>
2019-03-04 11:18 ` [dpdk-stable] [PATCH 01/12] net/af_packet: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 02/12] net/avp: " David Marchand
2019-03-04 12:18 ` Legacy, Allain
2019-03-04 11:18 ` [dpdk-stable] [PATCH 03/12] net/bnxt: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 04/12] net/cxgbe: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 05/12] net/kni: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 06/12] net/mlx4: " David Marchand
2019-03-05 8:19 ` Shahaf Shuler [this message]
2019-03-04 11:18 ` [dpdk-stable] [PATCH 07/12] net/mlx5: " David Marchand
2019-03-05 8:18 ` Shahaf Shuler
2019-03-04 11:18 ` [dpdk-stable] [PATCH 08/12] net/null: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 09/12] net/pcap: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 10/12] net/ring: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 11/12] net/szedata2: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 12/12] net/tap: " David Marchand
2019-03-04 13:58 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB379567D7EC075640C64CC2EEC3720@AM0PR0502MB3795.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).