From: Shahaf Shuler <shahafs@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: dev <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 1/1] net/mlx5: fix memory region cleanup routine
Date: Sun, 14 Apr 2019 06:58:28 +0000 [thread overview]
Message-ID: <AM0PR0502MB3795C43E2812F21139F98575C32A0@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <42204664-A008-4CE9-BE60-0D32F734CF78@mellanox.com>
Friday, April 12, 2019 8:55 PM, Yongseok Koh:
> Subject: Re: [dpdk-stable] [PATCH 1/1] net/mlx5: fix memory region cleanup
> routine
>
>
> > On Apr 12, 2019, at 8:45 AM, Viacheslav Ovsiienko
> <viacheslavo@mellanox.com> wrote:
> >
> > mlx5 driver has a global list of Memory Regions created by device, and
> > there is a ml5_mr_release() routine which makes a memory cleanup at
> > device closing. The head of device MR list was fetched outside the
> > rwlock protected section. Also some noticed typos are fixed.
> >
> > Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> > ---
>
> Nice catch, Slava
> Can you please submit the same fix for mlx4?
>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Slava - please merge both mlx4 and mlx5 into the same patch.
Keep Koh's acked-by.
I will take the v2.
>
> Thanks
>
> > drivers/net/mlx5/mlx5_mr.c | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c
> > index 44b6591..a3732d4 100644
> > --- a/drivers/net/mlx5/mlx5_mr.c
> > +++ b/drivers/net/mlx5/mlx5_mr.c
> > @@ -466,7 +466,7 @@ struct mr_update_mp_data { }
> >
> > /**
> > - * Releass resources of detached MR having no online entry.
> > + * Release resources of detached MR having no online entry.
> > *
> > * @param dev
> > * Pointer to Ethernet device.
> > @@ -516,7 +516,7 @@ struct mr_update_mp_data { }
> >
> > /**
> > - * Create a new global Memroy Region (MR) for a missing virtual address.
> > + * Create a new global Memory Region (MR) for a missing virtual address.
> > * This API should be called on a secondary process, then a request is
> > sent to
> > * the primary process in order to create a MR for the address. As the
> > global MR
> > * list is on the shared memory, following LKey lookup should succeed
> > unless the @@ -562,7 +562,7 @@ struct mr_update_mp_data { }
> >
> > /**
> > - * Create a new global Memroy Region (MR) for a missing virtual address.
> > + * Create a new global Memory Region (MR) for a missing virtual address.
> > * Register entire virtually contiguous memory chunk around the address.
> > * This must be called from the primary process.
> > *
> > @@ -673,7 +673,7 @@ struct mr_update_mp_data {
> > bmp_mem = RTE_PTR_ALIGN_CEIL(mr + 1, RTE_CACHE_LINE_SIZE);
> > mr->ms_bmp = rte_bitmap_init(ms_n, bmp_mem, bmp_size);
> > if (mr->ms_bmp == NULL) {
> > - DEBUG("port %u unable to initialize bitamp for a new MR of"
> > + DEBUG("port %u unable to initialize bitmap for a new MR of"
> > " address (%p).",
> > dev->data->port_id, (void *)addr);
> > rte_errno = EINVAL;
> > @@ -811,7 +811,7 @@ struct mr_update_mp_data { }
> >
> > /**
> > - * Create a new global Memroy Region (MR) for a missing virtual address.
> > + * Create a new global Memory Region (MR) for a missing virtual address.
> > * This can be called from primary and secondary process.
> > *
> > * @param dev
> > @@ -1600,7 +1600,7 @@ struct mr_update_mp_data {
> > mlx5_mr_release(struct rte_eth_dev *dev) {
> > struct mlx5_priv *priv = dev->data->dev_private;
> > - struct mlx5_mr *mr_next = LIST_FIRST(&priv->mr.mr_list);
> > + struct mlx5_mr *mr_next;
> >
> > /* Remove from memory callback device list. */
> > rte_rwlock_write_lock(&mlx5_shared_data->mem_event_rwlock);
> > @@ -1610,6 +1610,7 @@ struct mr_update_mp_data {
> > mlx5_mr_dump_dev(dev);
> > rte_rwlock_write_lock(&priv->mr.rwlock);
> > /* Detach from MR list and move to free list. */
> > + mr_next = LIST_FIRST(&priv->mr.mr_list);
> > while (mr_next != NULL) {
> > struct mlx5_mr *mr = mr_next;
> >
> > --
> > 1.8.3.1
> >
next prev parent reply other threads:[~2019-04-14 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 15:45 Viacheslav Ovsiienko
2019-04-12 17:55 ` Yongseok Koh
2019-04-14 6:58 ` Shahaf Shuler [this message]
2019-04-15 8:45 ` Slava Ovsiienko
2019-04-18 18:54 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB3795C43E2812F21139F98575C32A0@AM0PR0502MB3795.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).