From: Matan Azrad <matan@mellanox.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD
Date: Fri, 8 Nov 2019 10:29:10 +0000 [thread overview]
Message-ID: <AM0PR0502MB401929ED325A07DC86B7538FD27B0@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <0eea9d34-4201-2035-b266-d9b9e60e5dc5@solarflare.com>
From: Andrew Rybchenko
> Sent: Friday, November 8, 2019 12:12 PM
> To: Matan Azrad <matan@mellanox.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; ferruh.yigit@intel.com; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; Thomas Monjalon
> <thomas@monjalon.net>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads
> set by PMD
>
> On 11/7/19 9:56 AM, Matan Azrad wrote:
> > Hi
> >
> > From: Andrew Rybchenko
> >> On 11/6/19 9:58 AM, Matan Azrad wrote:
> >>>
> >>>
> >>> From: Andrew Rybchenko
> >>>> On 11/5/19 5:05 PM, Matan Azrad wrote:
> >>>>> From: Andrew Rybchenko
> >>>>>> On 11/3/19 6:16 PM, Matan Azrad wrote
> >>>>>>> From: Andrew Rybchenko
> >>>>>>>> On 11/3/19 9:57 AM, Matan Azrad wrote:
> >>>>>>>>> Hi
> >>>>>>>>>
> >>>>>>>>> From: Andrew Rybchenko
> >>>>>>>>>> On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula
> >>>>>>>>>> wrote:
> >>>>>>>>>>>> From: Pavan Nikhilesh Bhagavatula
> >>>>>>>>>>>>> Hi Matan,
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>> Hi Pavan
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> From: Pavan Nikhilesh
> >>>>>>>>>>>>>> <pbhagavatula@marvell.com>
> >>>>>>>>>>>>>>> Some PMDs cannot work when certain offloads are
> >>>>>>>>>>>>>>> enable/disabled, as a workaround PMDs auto
> >>>>>>>>>>>>>>> enable/disable offloads internally and expose it through
> >>>>>>>>>>>>>>> dev->data-dev_conf.rxmode.offloads.
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> After device specific dev_configure is called compare
> >>>>>>>>>>>>>>> the requested offloads to the offloads exposed by the
> >>>>>>>>>>>>>>> PMD and, if the PMD failed to enable a given offload
> >>>>>>>>>>>>>>> then log it and return -EINVAL from
> >>>>>>>>>>>>>>> rte_eth_dev_configure, else if the PMD failed to disable
> >>>>>>>>>>>>>>> a given offload log and continue with
> rte_eth_dev_configure.
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>> rte_eth_dev_configure can be called more than 1 time in
> >>>>>>>>>>>>>> the device life time, How can you know what is the
> >>>>>>>>>>>>>> minimum offload configurations required by the port after
> >>>>>>>>>>>>>> the first call?
> >>>>>>>>>>>>>> Maybe putting it in dev info is better, what do you think?
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>> We only return -EINVAL in the case where we enable an
> >>>>>>>>>>>>> offload advertised by dev_info and the port still fails to
> >>>>>>>>>>>>> enable it.
> >>>>>>>>>>>> Are you sure it is ok that devices may disable\enable
> >>>>>>>>>>>> offloads under the hood without user notification?
> >>>>>>>>>>> Some devices already do it. The above check adds validation
> >>>>>>>>>>> for the same.
> >>>>>>>>>> The problem is that some offloads cannot be disabled.
> >>>>>>>>> Yes, I understand it.
> >>>>>>>>>
> >>>>>>>>>> If application does not request Rx checksum offload since it
> >>>>>>>>>> does use it, it is not a problem to report it.
> >>>>>>>>> Yes, for RX checksum I tend to agree that application doesn't
> >>>>>>>>> care if the
> >>>>>>>> PMD will calculate the checksum in spite of the offload is
> >>>>>>>> disabled.
> >>>>>>>>>
> >>>>>>>>> But what's about other offloads: For example in RX: LRO,
> >>>>>>>>> CRC_KEEP, VLAN_STRIP, JUMBO If the PMD will stay them on
> while
> >>>>>>>>> the app is disabling it, It can cause a problems to the
> >>>>>>>> application (affects the packet length).
> >>>>>>>>
> >>>>>>>> Yes, I agree that some offloads are critical to be disabled,
> >>>>>>>> but RSS_HASH discussed in the changeset is not critical.
> >>>>>>>
> >>>>>>> So, are you agree It should not be checked globally for all the
> >>>>>>> offloads in
> >>>>>> ethdev layer?
> >>>>>>
> >>>>>> If offload is not requested, but enabled (since PMD cannot
> >>>>>> disable it), right not it will not fail configure, but warn about
> >>>>>> it in logs.
> >>>>>>
> >>>>>
> >>>>> In this case warning print is not enough since it can be critical
> >>>>> for the
> >>>> application for some offloads.
> >>>>> It can be very weird for the application to see that some offload
> >>>>> are on
> >>>> while the application doesn't expect them to be on.
> >>>>> it even can cause app crash(at least for the RX offload I wrote
> >>>>> above).
> >>>>
> >>>> The patch improves the situation. Earlier it was silent, now it
> >>>> will be at least visible.
> >>>
> >>> We can do it visible inside the limited PMDs.
> >>
> >> Why?
> >
> > Because this is not according to what application should understand from
> the ethdev API.
>
> It does not answer why it should be inside the limited PMDs instead of
> ethdev layer.
Why not?
Application doesn't expect to it and it may affect it.
> >>>> I'm afraid that in 19.11 release cycle we cannot change it to fail
> >>>> dev_configure. I think it will be too destructive. Future
> >>>> improvement should be discussed separately.
> >>>
> >>> So we can remove this ethdev patch now and let the PMD to do it
> >>> until we will find better solution later.
> >>
> >> Sorry, but I don't think so.
> >>
> >>>>>>> It even be more problematic if the dynamic offload field in mbuf
> >>>>>>> is not exist at all.
> >>>>>
> >>>>> Any answer here?
> >>>
> >>> A Rx offload requires dynamic mbuf field cannot stay visible while
> >>> the app disabling it. Because the dynamic mbuf field probably is not
> >>> set in the mbuf. May cause problems.
> >>>
> >>>> Please, clarify the question.
> >>>>
> >
> > No answer here.
>
> Sorry, but I don't understand the problem.
> If there is no dynamic field, it will not be set.
Why not? The offload is enabled for the PMD perspective.
> If there is dynamic field, it is the same as regular fields.
>
> >>>>>>>>
> >>>>>>>>> For example in TX: TSO, VLAN, MULTI_SEG.....
> >>>>>>>>
> >>>>>>>> Tx is not that critical since application should not request
> >>>>>>>> these offloads per- packet. Tx offloads are mainly required to
> >>>>>>>> ensure that application may request the offload per packet and
> >>>>>>>> it will be done.
> >>>>>>>
> >>>>>>> yes, you right, In TX it looks less critical (for now).
> >>>>>>>
> >>>>>>>>
> >>>>>>>>>> Of course, it could be a problem if the offload is used, but
> >>>>>>>>>> application wants to disable it, for example, for debugging
> >>>>>>>>>> purposes. In this case, the solution is to mask offloads on
> >>>>>>>>>> application level, which is not ideal as well.
> >>>>>>>>> Why not ideal?
> >>>>>>>>
> >>>>>>>> It eats CPU cycles.
> >>>>>>>
> >>>>>>> Sorry, I don't understand your use case here.
> >>>>>>
> >>>>>> If application wants to try code path without, for example, Rx
> >>>>>> checksum offload, it could be insufficient to disable the offload
> >>>>>> right now, but also required to cleanup offload results flags in
> >>>>>> each mbuf (if PMD does not support the offload disabling).
> >>>>>
> >>>>> What is "right now"? Configuration time?
> >>>>
> >>>> Right now is the current state of some drivers in DPDK tree.
> >>>>
> >>>
> >>> OK. I think the offload configuration is in configuration time. No
> >>> data-path.
> >>>
> >>>>> If application will know that PMD cannot disable the rx-checksum
> >>>>> in configuration time, It can plan to not clean this flag in mbuf
> >>>>> for each rx
> >>>> mbuf.
> >>>>
> >>>> Yes and application has a way to know it - take a look at
> >>>> dev->data->dev_conf.rxmode.offloads.
> >>>
> >>> As I understand, before this patch, this field used for ethdev layer
> >>> knowledge to track on the application Rx offload configuration. Am I
> >>> wrong?
> >>
> >> I think it is just Rx offloads configuration.
> >> It is better to have real offloads here since it is used on Rx queue
> >> setup to mask already enabled offloads.
> >
> > And in DPDK or any SW management controls a device, the configuration
> must be set by the user.
> > So, it should reflect the user configuration as is.
>
> It is ideal world which is unfortunately too far from real life.
> There is always a trade off. It is possible to define too restrictive interface
> which will enforce complicated implementation with bad performance
> characteristics for no real value.
>
> In any case, the patch simply makes the difference visible.
> It does not enforce any rules except to fail configure if requested offload is
> not enabled which is a strong violation of the interface. If you don't like it, we
> can discuss the point. In the area of not requested but enabled offloads, it
> just adds logs. No changes in behaviour. I'm strongly against making it hard
> failure in 19.11 since it is too late for the decision. We can discuss it later
> separately from the patch.
>
While I don't agree with the patch and the idea here, we can continue discuss later.
I think we understand the ideas of both of us and we can dig to it later.
> >>> And If the meaning is the PMD configuration set (which weirdly can
> >>> be different from what application want) I think it should be an
> >>> error - because app doesn't follow the API.
> >>
> >> Which app? Which API?
> >
> > App - the dpdk application which configures an offload that cannot be
> masked.
> > API - The Rx offload field in the ethdev data (which weirdly means what
> was configured by the PMD).
>
> See above.
>
> >>>>> It looks me like PMD limitation which can be solved by 2
> >>>>> options: 1. Capability information which say to the app what
> >>>>> offload may not be disabled.
> >>>>> 2. Add limitation in the PMD documentation and print warning\error
> >>>>> massage from the PMD.
> >>>>
> >>>> Yes, right now we are going way (2).
> >>>>
> >>>>>>>>> If application can know the limitation of offloads disabling
> >>>>>>>>> (for example to
> >>>>>>>> read capability on it)
> >>>>>>>>> The application has all information to take decisions.
> >>>>>>>>>
> >>>>>>>>>> Anyway, the patch just tries to highlight difference of
> >>>>>>>>>> applied from requested. So, it is a step forward. Also, the
> >>>>>>>>>> patch will fail configure if an offload is requested, but not
> >>>>>>>> enabled.
> >>>>>>>>>>
> >>>>>>>>>>>> Can't it break applications? Why does the device expose
> >>>>>>>>>>>> unsupported offloads in dev info? Does it update the
> >>>>>>>>>>>> running offload usynchronically? Race?
> >>>>>>>>>>>> Can you explain also your specific use case?
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>>> Matan
> >>>>>>>
> >>>>>
> >>>
> >
next prev parent reply other threads:[~2019-11-08 10:29 UTC|newest]
Thread overview: 245+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 20:47 [dpdk-dev] [PATCH v2 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 1/7] ethdev: add set ptype function pbhagavatula
2019-08-23 9:44 ` Andrew Rybchenko
2019-10-01 14:54 ` Jerin Jacob
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-08-23 1:19 ` Stephen Hemminger
2019-08-27 13:44 ` Andrew Rybchenko
2019-08-23 9:49 ` Andrew Rybchenko
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 3/7] ethdev: add flow action type " pbhagavatula
2019-08-23 10:00 ` Andrew Rybchenko
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-01 14:43 ` Jerin Jacob
2019-10-01 15:40 ` Ajit Khaparde
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-08-23 10:03 ` Andrew Rybchenko
2019-10-01 14:48 ` Jerin Jacob
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-08-23 10:10 ` Andrew Rybchenko
2019-09-29 21:19 ` [dpdk-dev] [PATCH v3 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-09-29 21:19 ` [dpdk-dev] [PATCH v3 1/7] ethdev: add set ptype function pbhagavatula
2019-09-29 21:19 ` [dpdk-dev] [PATCH v3 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-09-29 21:19 ` [dpdk-dev] [PATCH v3 3/7] ethdev: add flow action type " pbhagavatula
2019-09-29 21:19 ` [dpdk-dev] [PATCH v3 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-09-29 21:19 ` [dpdk-dev] [PATCH v3 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-09-29 21:19 ` [dpdk-dev] [PATCH v3 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-09-29 21:19 ` [dpdk-dev] [PATCH v3 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-09-30 17:47 ` Aaron Conole
2019-10-01 5:02 ` Pavan Nikhilesh Bhagavatula
2019-10-01 6:34 ` [dpdk-dev] [PATCH v4 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-01 6:34 ` [dpdk-dev] [PATCH v4 1/7] ethdev: add set ptype function pbhagavatula
2019-10-01 7:04 ` Andrew Rybchenko
2019-10-01 6:34 ` [dpdk-dev] [PATCH v4 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-01 6:34 ` [dpdk-dev] [PATCH v4 3/7] ethdev: add flow action type " pbhagavatula
2019-10-01 6:34 ` [dpdk-dev] [PATCH v4 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-01 6:34 ` [dpdk-dev] [PATCH v4 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-01 6:34 ` [dpdk-dev] [PATCH v4 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-01 6:34 ` [dpdk-dev] [PATCH v4 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-01 6:41 ` [dpdk-dev] [PATCH v5 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-01 6:41 ` [dpdk-dev] [PATCH v5 1/7] ethdev: add set ptype function pbhagavatula
2019-10-01 6:41 ` [dpdk-dev] [PATCH v5 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-01 6:41 ` [dpdk-dev] [PATCH v5 3/7] ethdev: add flow action type " pbhagavatula
2019-10-01 6:41 ` [dpdk-dev] [PATCH v5 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-01 7:10 ` Andrew Rybchenko
2019-10-01 11:50 ` Hemant Agrawal
2019-10-01 6:41 ` [dpdk-dev] [PATCH v5 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-01 7:11 ` Andrew Rybchenko
2019-10-01 6:41 ` [dpdk-dev] [PATCH v5 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-01 6:41 ` [dpdk-dev] [PATCH v5 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-01 18:52 ` [dpdk-dev] [PATCH v6 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-01 18:52 ` [dpdk-dev] [PATCH v6 1/7] ethdev: add set ptype function pbhagavatula
2019-10-01 18:52 ` [dpdk-dev] [PATCH v6 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-01 18:52 ` [dpdk-dev] [PATCH v6 3/7] ethdev: add flow action type " pbhagavatula
2019-10-01 18:52 ` [dpdk-dev] [PATCH v6 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-01 18:52 ` [dpdk-dev] [PATCH v6 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-01 18:52 ` [dpdk-dev] [PATCH v6 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-01 18:52 ` [dpdk-dev] [PATCH v6 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-02 3:47 ` [dpdk-dev] [PATCH v5 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-02 3:47 ` [dpdk-dev] [PATCH v7 1/7] ethdev: add set ptype function pbhagavatula
2019-10-02 13:37 ` Andrew Rybchenko
2019-10-02 13:41 ` Andrew Rybchenko
2019-10-02 3:47 ` [dpdk-dev] [PATCH v7 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-02 3:47 ` [dpdk-dev] [PATCH v7 3/7] ethdev: add flow action type " pbhagavatula
2019-10-02 3:47 ` [dpdk-dev] [PATCH v7 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-02 3:47 ` [dpdk-dev] [PATCH v7 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-02 9:52 ` Jerin Jacob
2019-10-02 3:47 ` [dpdk-dev] [PATCH v7 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-02 3:47 ` [dpdk-dev] [PATCH v7 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-02 21:36 ` [dpdk-dev] [PATCH v8 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-02 21:36 ` [dpdk-dev] [PATCH v8 1/7] ethdev: add set ptype function pbhagavatula
2019-10-03 7:40 ` Andrew Rybchenko
2019-10-03 17:15 ` Pavan Nikhilesh Bhagavatula
2019-10-02 21:36 ` [dpdk-dev] [PATCH v8 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-02 21:36 ` [dpdk-dev] [PATCH v8 3/7] ethdev: add flow action type " pbhagavatula
2019-10-02 21:36 ` [dpdk-dev] [PATCH v8 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-02 21:36 ` [dpdk-dev] [PATCH v8 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-02 21:36 ` [dpdk-dev] [PATCH v8 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-02 21:36 ` [dpdk-dev] [PATCH v8 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-07 6:51 ` [dpdk-dev] [PATCH v9 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-07 6:51 ` [dpdk-dev] [PATCH v9 1/7] ethdev: add set ptype function pbhagavatula
2019-10-08 14:48 ` Andrew Rybchenko
2019-10-07 6:51 ` [dpdk-dev] [PATCH v9 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-07 6:51 ` [dpdk-dev] [PATCH v9 3/7] ethdev: add flow action type " pbhagavatula
2019-10-07 6:51 ` [dpdk-dev] [PATCH v9 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-07 6:51 ` [dpdk-dev] [PATCH v9 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-07 6:51 ` [dpdk-dev] [PATCH v9 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-07 6:51 ` [dpdk-dev] [PATCH v9 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-09 15:33 ` [dpdk-dev] [PATCH v10 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-09 15:33 ` [dpdk-dev] [PATCH v10 1/7] ethdev: add set ptype function pbhagavatula
2019-10-10 8:46 ` Andrew Rybchenko
2019-10-09 15:33 ` [dpdk-dev] [PATCH v10 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-09 15:33 ` [dpdk-dev] [PATCH v10 3/7] ethdev: add flow action type " pbhagavatula
2019-10-09 15:33 ` [dpdk-dev] [PATCH v10 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-09 15:33 ` [dpdk-dev] [PATCH v10 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-09 15:33 ` [dpdk-dev] [PATCH v10 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-09 15:33 ` [dpdk-dev] [PATCH v10 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-10 10:51 ` [dpdk-dev] [PATCH v11 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-10 10:51 ` [dpdk-dev] [PATCH v11 1/7] ethdev: add set ptype function pbhagavatula
2019-10-10 10:51 ` [dpdk-dev] [PATCH v11 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-10 10:51 ` [dpdk-dev] [PATCH v11 3/7] ethdev: add flow action type " pbhagavatula
2019-10-10 10:51 ` [dpdk-dev] [PATCH v11 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-10 10:51 ` [dpdk-dev] [PATCH v11 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-10 10:51 ` [dpdk-dev] [PATCH v11 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-10 10:51 ` [dpdk-dev] [PATCH v11 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-17 12:02 ` [dpdk-dev] [PATCH v12 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-17 12:02 ` [dpdk-dev] [PATCH v12 1/7] ethdev: add set ptype function pbhagavatula
2019-10-17 12:02 ` [dpdk-dev] [PATCH v12 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-17 12:02 ` [dpdk-dev] [PATCH v12 3/7] ethdev: add flow action type " pbhagavatula
2019-10-17 12:02 ` [dpdk-dev] [PATCH v12 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-17 12:02 ` [dpdk-dev] [PATCH v12 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-17 12:02 ` [dpdk-dev] [PATCH v12 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-17 12:02 ` [dpdk-dev] [PATCH v12 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-17 17:43 ` [dpdk-dev] [PATCH v12 0/7] ethdev: add new Rx offload flags Ferruh Yigit
2019-10-18 7:32 ` Andrew Rybchenko
2019-10-18 9:42 ` Ferruh Yigit
2019-10-18 10:31 ` Andrew Rybchenko
2019-10-21 15:06 ` Ferruh Yigit
2019-10-25 14:33 ` [dpdk-dev] [PATCH v13 0/6] " pbhagavatula
2019-10-25 14:33 ` [dpdk-dev] [PATCH v13 1/6] ethdev: add set ptype function pbhagavatula
2019-10-25 14:33 ` [dpdk-dev] [PATCH v13 2/6] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-25 14:33 ` [dpdk-dev] [PATCH v13 3/6] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-25 14:56 ` Andrew Rybchenko
2019-10-25 14:33 ` [dpdk-dev] [PATCH v13 4/6] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-25 14:33 ` [dpdk-dev] [PATCH v13 5/6] examples/l2fwd: disable ptype parsing pbhagavatula
2019-10-25 14:33 ` [dpdk-dev] [PATCH v13 6/6] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-10-29 5:03 ` [dpdk-dev] [PATCH v14 0/6] ethdev: add new Rx offload flags pbhagavatula
2019-10-29 5:03 ` [dpdk-dev] [PATCH v14 1/7] ethdev: add set ptype function pbhagavatula
2019-10-29 5:03 ` [dpdk-dev] [PATCH v14 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-29 7:13 ` Andrew Rybchenko
2019-10-29 5:03 ` [dpdk-dev] [PATCH v14 3/7] ethdev: log offloads that can't be disabled by PMD pbhagavatula
2019-10-29 7:05 ` Andrew Rybchenko
2019-10-29 8:33 ` Pavan Nikhilesh Bhagavatula
2019-10-29 8:42 ` Andrew Rybchenko
2019-10-29 5:03 ` [dpdk-dev] [PATCH v14 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-29 7:21 ` Andrew Rybchenko
2019-10-29 5:03 ` [dpdk-dev] [PATCH v14 5/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-29 5:03 ` [dpdk-dev] [PATCH v14 6/7] examples/l2fwd: disable ptype parsing pbhagavatula
2019-10-29 5:03 ` [dpdk-dev] [PATCH v14 7/7] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-10-29 15:37 ` [dpdk-dev] [PATCH v15 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-29 15:37 ` [dpdk-dev] [PATCH v15 1/7] ethdev: add set ptype function pbhagavatula
2019-10-31 13:39 ` Thomas Monjalon
2019-10-29 15:37 ` [dpdk-dev] [PATCH v15 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-31 13:43 ` Thomas Monjalon
2019-10-29 15:37 ` [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD pbhagavatula
2019-10-29 16:53 ` Andrew Rybchenko
2019-10-29 17:25 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-10-31 13:45 ` [dpdk-dev] " Thomas Monjalon
2019-10-31 13:58 ` Thomas Monjalon
2019-10-31 16:44 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-11-01 22:50 ` Thomas Monjalon
2019-10-31 15:13 ` [dpdk-dev] " Matan Azrad
2019-10-31 15:18 ` Pavan Nikhilesh Bhagavatula
2019-10-31 15:50 ` Matan Azrad
2019-10-31 16:33 ` Pavan Nikhilesh Bhagavatula
2019-11-01 11:04 ` Andrew Rybchenko
2019-11-03 6:57 ` Matan Azrad
2019-11-03 12:12 ` Andrew Rybchenko
2019-11-03 15:16 ` Matan Azrad
2019-11-05 12:48 ` Andrew Rybchenko
2019-11-05 14:05 ` Matan Azrad
2019-11-05 14:37 ` Andrew Rybchenko
2019-11-06 6:58 ` Matan Azrad
2019-11-06 8:12 ` Andrew Rybchenko
2019-11-07 6:56 ` Matan Azrad
2019-11-08 10:12 ` Andrew Rybchenko
2019-11-08 10:29 ` Matan Azrad [this message]
2019-11-08 11:24 ` Andrew Rybchenko
2019-11-08 11:48 ` Matan Azrad
2019-11-08 12:09 ` Andrew Rybchenko
2019-11-08 12:59 ` Thomas Monjalon
2019-10-29 15:37 ` [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-31 14:03 ` Thomas Monjalon
2019-10-31 16:51 ` Pavan Nikhilesh Bhagavatula
2019-11-01 11:11 ` Andrew Rybchenko
2019-11-01 22:22 ` Thomas Monjalon
2019-11-01 17:49 ` Liron Himi
2019-11-03 12:06 ` Andrew Rybchenko
2019-11-03 14:06 ` [dpdk-dev] [EXT] " Liron Himi
2019-10-29 15:37 ` [dpdk-dev] [PATCH v15 5/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-31 14:05 ` Thomas Monjalon
2019-10-29 15:37 ` [dpdk-dev] [PATCH v15 6/7] examples/l2fwd: disable ptype parsing pbhagavatula
2019-10-29 15:37 ` [dpdk-dev] [PATCH v15 7/7] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-10-31 10:33 ` Iremonger, Bernard
2019-11-06 18:13 ` Pavan Nikhilesh Bhagavatula
2019-11-06 19:17 ` [dpdk-dev] [PATCH v16 0/8] ethdev: add new Rx offload flags pbhagavatula
2019-11-06 19:17 ` [dpdk-dev] [PATCH v16 1/8] ethdev: add set ptype function pbhagavatula
2019-11-07 18:28 ` Ferruh Yigit
2019-11-08 9:05 ` Andrew Rybchenko
2019-11-08 9:52 ` Ferruh Yigit
2019-11-08 10:24 ` Andrew Rybchenko
2019-11-08 11:05 ` Ferruh Yigit
2019-11-08 11:40 ` Andrew Rybchenko
2019-11-06 19:17 ` [dpdk-dev] [PATCH v16 2/8] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-11-07 17:24 ` Ferruh Yigit
2019-11-10 14:43 ` Pavan Nikhilesh Bhagavatula
2019-11-06 19:17 ` [dpdk-dev] [PATCH v16 3/8] ethdev: add validation to offloads set by PMD pbhagavatula
2019-11-07 16:51 ` Ferruh Yigit
2019-11-06 19:17 ` [dpdk-dev] [PATCH v16 4/8] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-11-07 16:48 ` Ferruh Yigit
2019-11-07 17:22 ` Ferruh Yigit
2019-11-08 8:48 ` Andrew Rybchenko
2019-11-14 14:01 ` Ferruh Yigit
2019-11-06 19:17 ` [dpdk-dev] [PATCH v16 5/8] examples/eventdev_pipeline: split port init sequence pbhagavatula
2019-11-06 19:18 ` [dpdk-dev] [PATCH v16 6/8] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-11-06 19:18 ` [dpdk-dev] [PATCH v16 7/8] examples/l2fwd: disable ptype parsing pbhagavatula
2019-11-07 17:59 ` Ferruh Yigit
2019-11-07 18:30 ` Ferruh Yigit
2019-11-06 19:18 ` [dpdk-dev] [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-11-07 11:57 ` Iremonger, Bernard
2019-11-07 12:27 ` Iremonger, Bernard
2019-11-07 14:36 ` Pavan Nikhilesh Bhagavatula
2019-11-07 15:00 ` Iremonger, Bernard
2019-11-07 18:40 ` Ferruh Yigit
2019-11-07 18:55 ` Jerin Jacob
2019-11-07 19:40 ` Ferruh Yigit
2019-11-08 4:13 ` Jerin Jacob
2019-11-08 13:54 ` Ananyev, Konstantin
2019-11-08 15:01 ` Jerin Jacob
2019-11-11 4:56 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-11-11 5:02 ` Jerin Jacob
2019-11-11 10:44 ` Ferruh Yigit
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 00/10] ethdev: add new Rx offload flags pbhagavatula
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 01/10] ethdev: add set ptype function pbhagavatula
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 02/10] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-11-13 18:04 ` Ferruh Yigit
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 03/10] ethdev: add validation to offloads set by PMD pbhagavatula
2019-11-13 18:10 ` Ferruh Yigit
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-11-11 15:05 ` Ferruh Yigit
2019-11-11 15:10 ` Pavan Nikhilesh Bhagavatula
2019-11-13 18:02 ` Ferruh Yigit
2019-11-14 12:52 ` Ferruh Yigit
2019-11-14 12:57 ` Jerin Jacob
2019-11-14 13:24 ` Andrew Rybchenko
2019-11-14 13:59 ` Ferruh Yigit
2019-11-14 14:14 ` Ferruh Yigit
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 05/10] examples/eventdev_pipeline: split port init sequence pbhagavatula
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 06/10] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 07/10] examples/l2fwd: disable ptype parsing pbhagavatula
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-11-11 14:51 ` Ferruh Yigit
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 09/10] app/testpmd: disable packet type parsing by default pbhagavatula
2019-11-11 14:54 ` Ferruh Yigit
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 10/10] app/testpmd: add RSS hash offload to port Rx offload cmd pbhagavatula
2019-11-11 15:45 ` [dpdk-dev] [PATCH v17 00/10] ethdev: add new Rx offload flags Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB401929ED325A07DC86B7538FD27B0@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).