From: Matan Azrad <matan@mellanox.com>
To: Jeff Guo <jia.guo@intel.com>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"helin.zhang@intel.com" <helin.zhang@intel.com>,
"shaopeng.he@intel.com" <shaopeng.he@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] eal: fix lock issue for hot-unplug
Date: Tue, 6 Nov 2018 06:22:44 +0000 [thread overview]
Message-ID: <AM0PR0502MB401957A51BA517C038AC4D74D2CB0@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1541484436-91320-2-git-send-email-jia.guo@intel.com>
Hi Jeff
Can you detail more in the commit log that we can understand the deadlock scenario. And how does this commit fix it?
> -----Original Message-----
> From: Jeff Guo <jia.guo@intel.com>
> Sent: Tuesday, November 6, 2018 8:07 AM
> To: konstantin.ananyev@intel.com; anatoly.burakov@intel.com; Thomas
> Monjalon <thomas@monjalon.net>; bernard.iremonger@intel.com;
> jingjing.wu@intel.com; wenzhuo.lu@intel.com
> Cc: ferruh.yigit@intel.com; dev@dpdk.org; jia.guo@intel.com;
> helin.zhang@intel.com; Matan Azrad <matan@mellanox.com>;
> shaopeng.he@intel.com
> Subject: [PATCH 1/3] eal: fix lock issue for hot-unplug
>
> This patch will add missing unlock for hot-unplug handler, without this patch
> potential dead lock will occur when device be hotplug-in after device be hot-
> unplugged.
>
> Fixes: 0fc54536b14a ("eal: add failure handling for hot-unplug")
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
> lib/librte_eal/linuxapp/eal/eal_dev.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_dev.c
> b/lib/librte_eal/linuxapp/eal/eal_dev.c
> index d589c69..2830c86 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_dev.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_dev.c
> @@ -258,7 +258,7 @@ dev_uev_handler(__rte_unused void *param)
> if (bus == NULL) {
> RTE_LOG(ERR, EAL, "Cannot find bus (%s)\n",
> busname);
> - return;
> + goto failure_handle_err;
> }
>
> dev = bus->find_device(NULL, cmp_dev_name, @@
> -266,19 +266,23 @@ dev_uev_handler(__rte_unused void *param)
> if (dev == NULL) {
> RTE_LOG(ERR, EAL, "Cannot find device (%s)
> on "
> "bus (%s)\n", uevent.devname,
> busname);
> - return;
> + goto failure_handle_err;
> }
>
> ret = bus->hot_unplug_handler(dev);
> - rte_spinlock_unlock(&failure_handle_lock);
> if (ret) {
> RTE_LOG(ERR, EAL, "Can not handle hot-
> unplug "
> "for device (%s)\n", dev->name);
> - return;
> }
> + rte_spinlock_unlock(&failure_handle_lock);
> }
> rte_dev_event_callback_process(uevent.devname,
> uevent.type);
> }
> +
> + return;
> +
> +failure_handle_err:
> + rte_spinlock_unlock(&failure_handle_lock);
> }
>
> int __rte_experimental
> --
> 2.7.4
next prev parent reply other threads:[~2018-11-06 6:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 6:07 [dpdk-dev] [PATCH 0/3] fix vfio hot-unplug issue Jeff Guo
2018-11-06 6:07 ` [dpdk-dev] [PATCH 1/3] eal: fix lock issue for hot-unplug Jeff Guo
2018-11-06 6:22 ` Matan Azrad [this message]
2018-11-07 5:49 ` Jeff Guo
2018-11-08 7:08 ` Matan Azrad
2018-11-06 6:07 ` [dpdk-dev] [PATCH 2/3] vfio: fix to add handler lock " Jeff Guo
2018-11-06 6:23 ` Matan Azrad
2018-11-07 6:15 ` Jeff Guo
2018-11-08 7:20 ` Matan Azrad
2018-11-08 8:30 ` Jeff Guo
2018-11-06 6:07 ` [dpdk-dev] [PATCH 3/3] app/testpmd: fix callback issue " Jeff Guo
2018-11-06 6:36 ` Matan Azrad
2018-11-07 7:30 ` Jeff Guo
2018-11-07 11:05 ` Ananyev, Konstantin
2018-11-08 7:28 ` Matan Azrad
2018-11-08 8:49 ` Jeff Guo
2018-11-08 9:35 ` Matan Azrad
2018-11-09 3:55 ` Jeff Guo
2018-11-09 5:24 ` Matan Azrad
2018-11-09 6:17 ` Jeff Guo
[not found] ` <AM0PR0502MB401938411A7E2BA9E76576A2D2C00@AM0PR0502MB4019.eurprd05.prod.outlook.com>
2018-11-12 1:35 ` Thomas Monjalon
2018-11-14 9:32 ` Jeff Guo
2018-11-15 9:18 ` [dpdk-dev] [PATCH V2 0/3] fix vfio hot-unplug issue Jeff Guo
2018-11-15 9:18 ` Jeff Guo
2018-11-18 16:19 ` Thomas Monjalon
2018-11-15 9:18 ` [dpdk-dev] [PATCH V2 1/3] eal: fix lock issue for hot-unplug Jeff Guo
2018-11-15 9:18 ` [dpdk-dev] [PATCH V2 2/3] vfio: fix to add handler lock " Jeff Guo
2018-11-15 9:18 ` [dpdk-dev] [PATCH V2 3/3] app/testpmd: fix callback issue " Jeff Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB401957A51BA517C038AC4D74D2CB0@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=anatoly.burakov@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=shaopeng.he@intel.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).