From: Raslan Darawsheh <rasland@mellanox.com>
To: Shiri Kuzin <shirik@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>, Ori Kam <orika@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] common/mlx5: fix MAC addresses flush
Date: Wed, 29 Jul 2020 15:12:29 +0000 [thread overview]
Message-ID: <AM0PR05MB67072543174A6CF272CC3DD7C2700@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1596032940-20138-1-git-send-email-shirik@mellanox.com>
Hi,
> -----Original Message-----
> From: Shiri Kuzin <shirik@mellanox.com>
> Sent: Wednesday, July 29, 2020 5:29 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; stable@dpdk.org
> Subject: [PATCH] common/mlx5: fix MAC addresses flush
>
> mlx5_nl_mac_addr_flush should flush all allocated MAC
> addresses.
>
> The MAC addresses array size should be of size
> MLX5_MAX_MAC_ADDRESSES, but currently we return without
> flushing the addresses if size is MLX5_MAX_MAC_ADDRESSES.
>
> This was fixed by not allowing an array larger than
> MLX5_MAX_MAC_ADDRESSES.
>
> Fixes: e9a8ac59b6e2 ("common/mlx5: fix MAC addresses assert")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shiri Kuzin <shirik@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/common/mlx5/linux/mlx5_nl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/mlx5/linux/mlx5_nl.c
> b/drivers/common/mlx5/linux/mlx5_nl.c
> index 8ab7f6b..0ecd9c7 100644
> --- a/drivers/common/mlx5/linux/mlx5_nl.c
> +++ b/drivers/common/mlx5/linux/mlx5_nl.c
> @@ -790,7 +790,7 @@ struct mlx5_nl_ifindex_data {
> {
> int i;
>
> - if (n <= 0 || n >= MLX5_MAX_MAC_ADDRESSES)
> + if (n <= 0 || n > MLX5_MAX_MAC_ADDRESSES)
> return;
>
> for (i = n - 1; i >= 0; --i) {
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-07-29 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 14:29 Shiri Kuzin
2020-07-29 15:12 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB67072543174A6CF272CC3DD7C2700@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=shirik@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).