patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Joyce Kong (Arm Technology China)" <Joyce.Kong@arm.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] config: enable more than 128 cores for Arm64 platform
Date: Thu, 22 Nov 2018 07:01:47 +0000	[thread overview]
Message-ID: <AM0PR08MB3587251EE163822D41F5762392DB0@AM0PR08MB3587.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20181121113422.GA31379@jerin>

> -----Original Message-----
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Sent: Wednesday, November 21, 2018 7:35 PM
> To: Joyce Kong (Arm Technology China) <Joyce.Kong@arm.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; stable@dpdk.org
> Subject: Re: [PATCH v2] config: enable more than 128 cores for Arm64
> platform
>
> -----Original Message-----
> > Date: Wed, 21 Nov 2018 19:27:12 +0800
> > From: Joyce Kong <joyce.kong@arm.com>
> > To: dev@dpdk.org
> > CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
> > Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, stable@dpdk.org
> > Subject: [PATCH v2] config: enable more than 128 cores for Arm64
> > platform
> > X-Mailer: git-send-email 2.7.4
> >
> >
> > When running dpdk applications on cores whose ids are bigger than
> > original max_core setting, eal error as below:
> > EAL: Detected 104 lcore(s)
> > EAL: Detected 2 NUMA nodes
> > EAL: invalid core list
> > -l CORELIST core indexes between 0 and 128
> >
> > The fix is to increase max_core to 256 on Arm64 platform.
> >
> > Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> >  config/arm/meson.build                     | 2 +-
> >  config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > b755138..020df09 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -51,7 +51,7 @@ flags_cavium = [
> >         ['RTE_MACHINE', '"thunderx"'],
> >         ['RTE_CACHE_LINE_SIZE', 128],
> >         ['RTE_MAX_NUMA_NODES', 2],
> > -       ['RTE_MAX_LCORE', 96],
> > +       ['RTE_MAX_LCORE', 256],
>
> This change makes thunderx config to 256 cores not armv8.
> For generic config, it needs to be under "flags_generic"
> not under "flags_cavium". Just like you did for updating defconfig_arm64-
> armv8a-linuxapp-gcc config instead of defconfig_arm64-thunderx-linuxapp-
> gcc
>

Config to 256 cores for both flags_generic and flags_cavium in V3.
For thunderx, it will do meson build according to flasg_cavium instead of flags_generic.
And there is no inheritance relationship between the two flags.

> >         ['RTE_MAX_VFIO_GROUPS', 128],
> >         ['RTE_USE_C11_MEM_MODEL', false]]  flags_dpaa = [ diff --git
> > a/config/defconfig_arm64-armv8a-linuxapp-gcc
> > b/config/defconfig_arm64-armv8a-linuxapp-gcc
> > index 1842744..a6ed90c 100644
> > --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> > +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> > @@ -6,3 +6,4 @@
> >
> >  CONFIG_RTE_TOOLCHAIN="gcc"
> >  CONFIG_RTE_TOOLCHAIN_GCC=y
> > +CONFIG_RTE_MAX_LCORE=256
> > --
> > 2.7.4
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2018-11-22  7:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1542798625-46722-1-git-send-email-joyce.kong@arm.com>
2018-11-21 11:10 ` [dpdk-stable] [PATCH v1 1/2] config: enable more than 128 cores for Arm platform Joyce Kong
2018-11-21 11:10 ` [dpdk-stable] [PATCH v1 2/2] config: enable more than 128 cores for meson build Joyce Kong
2018-11-21 11:27 ` [dpdk-stable] [PATCH v2] config: enable more than 128 cores for Arm64 platform Joyce Kong
2018-11-21 11:34   ` Jerin Jacob
2018-11-22  7:01     ` Joyce Kong (Arm Technology China) [this message]
2018-11-22  7:01 ` [dpdk-stable] [PATCH v3] " Joyce Kong
2018-11-22  7:08   ` Jerin Jacob
2018-11-22  7:43     ` Joyce Kong (Arm Technology China)
2018-11-22  7:37   ` [dpdk-stable] [PATCH v4] " Joyce Kong
2018-11-22 11:04     ` Jerin Jacob
2018-11-23  0:49       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR08MB3587251EE163822D41F5762392DB0@AM0PR08MB3587.eurprd08.prod.outlook.com \
    --to=joyce.kong@arm.com \
    --cc=Gavin.Hu@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).