From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "shaguna@chelsio.com" <shaguna@chelsio.com>,
"kumaras@chelsio.com" <kumaras@chelsio.com>,
"indranil@chelsio.com" <indranil@chelsio.com>,
"nirranjan@chelsio.com" <nirranjan@chelsio.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources
Date: Thu, 14 Jun 2018 05:44:29 +0000 [thread overview]
Message-ID: <AM2PR04MB07531E9D037AD5FD5D011A80897D0@AM2PR04MB0753.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <8334e31d-da73-0d55-ba1f-3b91102048e1@intel.com>
Hi Ferruh,
On 6/8/2018 6:58 PM, Rahul Lakkireddy wrote:
> diff --git a/drivers/net/cxgbe/cxgbe_filter.h
> b/drivers/net/cxgbe/cxgbe_filter.h
> new file mode 100644
> index 000000000..d69c79e80
> --- /dev/null
> +++ b/drivers/net/cxgbe/cxgbe_filter.h
> @@ -0,0 +1,97 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2014-2018 Chelsio Communications.
> + * All rights reserved.
> + */
> +
Hi Rahul,
This is a new file and copyright starts from 2014, is this intentional?
And @Thomas, @Hemant, are we allowed to have copyright start date in the past for new files?
[Hemant] It is good to ask the submitter to re-check on the copyright year. But they can decide which copyright year they want to put on the files.
Typically copyright start can be when the part of the code originated/written first time irrespective of submission to DPDK.
Some companies also requires that you keep on updating the copyright year when you are changing the code. While others think that git history is sufficient to keep that track, you need not to update the copyright year.
Regards,
Hemant
next prev parent reply other threads:[~2018-06-14 5:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 17:58 [dpdk-dev] [PATCH 0/7] cxgbe: add support to offload flows via rte_flow Rahul Lakkireddy
2018-06-08 17:58 ` [dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources Rahul Lakkireddy
2018-06-13 16:41 ` Ferruh Yigit
2018-06-13 16:59 ` Thomas Monjalon
2018-06-13 17:40 ` Wiles, Keith
2018-06-14 5:44 ` Hemant Agrawal [this message]
2018-06-08 17:58 ` [dpdk-dev] [PATCH 2/7] net/cxgbe: parse and validate flows Rahul Lakkireddy
2018-06-08 17:58 ` [dpdk-dev] [PATCH 3/7] net/cxgbe: add control queue to communicate filter requests Rahul Lakkireddy
2018-06-08 17:58 ` [dpdk-dev] [PATCH 4/7] net/cxgbe: implement flow create operation Rahul Lakkireddy
2018-06-08 17:58 ` [dpdk-dev] [PATCH 5/7] net/cxgbe: implement flow destroy operation Rahul Lakkireddy
2018-06-08 17:58 ` [dpdk-dev] [PATCH 6/7] net/cxgbe: implement flow query operation Rahul Lakkireddy
2018-06-08 17:58 ` [dpdk-dev] [PATCH 7/7] net/cxgbe: implement flow flush operation Rahul Lakkireddy
2018-06-13 16:42 ` [dpdk-dev] [PATCH 0/7] cxgbe: add support to offload flows via rte_flow Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR04MB07531E9D037AD5FD5D011A80897D0@AM2PR04MB0753.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=indranil@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=shaguna@chelsio.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).