From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Neil Horman <nhorman@tuxdriver.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] dpaa: Augment linker line to include needed libraries for dpaa
Date: Tue, 27 Feb 2018 03:55:20 +0000 [thread overview]
Message-ID: <AM2PR04MB07534A2A329687D8CEA4F74089C00@AM2PR04MB0753.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20180226192001.30220-1-nhorman@tuxdriver.com>
HI Neil,
Thanks for the patch. This issue was identified and fixed in the following patches (yet to be merged)
V1:http://dpdk.org/dev/patchwork/patch/35366/
V2: http://dpdk.org/dev/patchwork/patch/35369/
Regards,
Hemant
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman
> Sent: Tuesday, February 27, 2018 12:50 AM
> To: dev@dpdk.org
> Cc: Neil Horman <nhorman@tuxdriver.com>; Thomas Monjalon
> <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@intel.com>; Hemant
> Agrawal <hemant.agrawal@nxp.com>
> Subject: [dpdk-dev] [PATCH] dpaa: Augment linker line to include needed
> libraries for dpaa
> Importance: High
>
> When preforming a shared library build, if the dpaa pmd is configured, the build
> fails when linking testpmd. This occurs because the makefile fails to include
> dependent libraries dpaa_mempool and dpaa_bus.
>
> Fix is to simply include them in the makefile. We could perhaps fix this more
> generally by using the copy-dt-needed-entries linker option, but doing so has a
> significant effect on link order, which may be undesireable. Given this is fairly
> isolated, and that we have precident for this (see rte.app.mk), just add the
> needed libraries for this specific app
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Thomas Monjalon <thomas@monjalon.net>
> CC: Ferruh Yigit <ferruh.yigit@intel.com>
> CC: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> app/test-pmd/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index
> ed588ab6d..77a02ca0d 100644
> --- a/app/test-pmd/Makefile
> +++ b/app/test-pmd/Makefile
> @@ -45,7 +45,7 @@ LDLIBS += -lrte_pmd_bond endif
>
> ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y)
> -LDLIBS += -lrte_pmd_dpaa
> +LDLIBS += -lrte_pmd_dpaa -lrte_bus_dpaa -lrte_mempool_dpaa
> endif
>
> ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
> --
> 2.14.3
prev parent reply other threads:[~2018-02-27 3:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 19:20 Neil Horman
2018-02-27 3:55 ` Hemant Agrawal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR04MB07534A2A329687D8CEA4F74089C00@AM2PR04MB0753.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).