From: Shachar Beiser <shacharbe@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Shahaf Shuler" <shahafs@mellanox.com>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix verification of device context
Date: Wed, 26 Jul 2017 09:21:27 +0000 [thread overview]
Message-ID: <AM2PR05MB0689C04ADEBFC4C4204F3647C0B90@AM2PR05MB0689.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20170726090613.GT19852@6wind.com>
Hi ,
When I say close I mean : " mlx5_dev_close" . This function set the priv->ctx to NULL.
We think this patch is required because we have an open bug of seg fault while accessing priv->ctx == NULL.
-Shachar Beiser.
-----Original Message-----
From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
Sent: Wednesday, July 26, 2017 12:06 PM
To: Shachar Beiser <shacharbe@mellanox.com>
Cc: dev@dpdk.org; Nélio Laranjeiro <nelio.laranjeiro@6wind.com>; stable@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix verification of device context
Hi Shachar,
On Wed, Jul 26, 2017 at 05:43:24AM +0000, Shachar Beiser wrote:
> Get interface name function lacks verification of device context.
> It might lead to segmentation fault when trying to query the name
> after the device is closed.fixing it by adding the missing
> verification
>
Thanks, however if by "close" you mean it may occur when applications use ethdev callbacks after a call to rte_eth_dev_close(), I do not think PMDs have to protect themselves against bad application behavior, otherwise there is no end to such fixes.
The reverse of rte_eth_dev_close() is not rte_eth_dev_configure() nor any other ethdev callback (see documentation), but a bus probe operation.
Perhaps I've missed something, so in case a crash occurs *while* calling
rte_eth_dev_close() I guess this patch is fine, but then please describe the reason.
> Fixes: cd89f22a1e9770 ("net/mlx5: remove unused interface name query")
This commit doesn't look like the root cause of that issue?
> Cc: stable@dpdk.org
>
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_ethdev.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> b/drivers/net/mlx5/mlx5_ethdev.c index b70b7b9..6e67461 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -173,6 +173,10 @@ struct priv *
> char match[IF_NAMESIZE] = "";
>
> {
> + if (priv->ctx == NULL) {
> + DEBUG("The device is closed, cannot query interface name ");
> + return -1;
> + }
MKSTR() is at the beginning of this block because it defines a new variable (path). For coding style consistency you should not put any code before variable declarations, or at least insert an empty line between them. Otherwise you could move this check to the parent block.
> MKSTR(path, "%s/device/net", priv->ctx->device->ibdev_path);
>
> dir = opendir(path);
> --
> 1.8.3.1
>
I think this patch is not necessary unless proved otherwise, have you
actually observed a crash addressed by it?
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2017-07-26 9:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 5:43 Shachar Beiser
2017-07-26 9:06 ` Adrien Mazarguil
2017-07-26 9:21 ` Shachar Beiser [this message]
[not found] ` <cover.1501075226.git.gaetan.rivet@6wind.com>
2017-07-26 13:30 ` [dpdk-stable] [PATCH 1/6] ethdev: fix device state on detach Gaetan Rivet
[not found] ` <cover.1501076035.git.gaetan.rivet@6wind.com>
2017-07-26 13:35 ` [dpdk-stable] [PATCH v2 " Gaetan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR05MB0689C04ADEBFC4C4204F3647C0B90@AM2PR05MB0689.eurprd05.prod.outlook.com \
--to=shacharbe@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).