From: Mordechay Haimovsky <motih@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: add Rx interrupts
Date: Wed, 13 Dec 2017 13:12:10 +0000 [thread overview]
Message-ID: <AM4PR05MB1907E71C658DE2AB0B0A9ACBD2350@AM4PR05MB1907.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20171211173403.58ec6d86@xeon-e3>
Thank you Stephen,
Will gather more review inputs and send a fix.
Moti
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, December 12, 2017 3:34 AM
> To: Mordechay Haimovsky <motih@mellanox.com>
> Cc: gaetan.rivet@6wind.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/failsafe: add Rx interrupts
>
> On Mon, 11 Dec 2017 14:41:47 +0200
> Moti Haimovsky <motih@mellanox.com> wrote:
>
> > + for (i = 0; i < n; i++) {
> > + rxq = (struct rxq *)events[i].epdata.data;
>
> Minor nit. events[i].epdata.data is "void *" therefore cast is unnecessary.
next prev parent reply other threads:[~2017-12-13 13:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 12:41 Moti Haimovsky
2017-12-12 1:34 ` Stephen Hemminger
2017-12-13 13:12 ` Mordechay Haimovsky [this message]
2018-01-04 15:01 ` [dpdk-dev] [PATCH v2] " Moti Haimovsky
2018-01-17 12:54 ` [dpdk-dev] [PATCH V3] " Moti Haimovsky
2018-01-19 9:32 ` [dpdk-dev] [PATCH v4] " Moti Haimovsky
2018-01-19 9:32 ` Moti Haimovsky
2018-01-19 14:11 ` Gaëtan Rivet
2018-01-23 18:43 ` [dpdk-dev] [PATCH v5 0/3] net/failsafe: add Rx interrupts support Moti Haimovsky
2018-01-23 18:43 ` [dpdk-dev] [PATCH v5 1/3] net/failsafe: regiter as an Rx interrupt mode PMD Moti Haimovsky
2018-01-23 18:43 ` [dpdk-dev] [PATCH v5 2/3] net/failsafe: slaves Rx interrupts registration Moti Haimovsky
2018-01-24 16:12 ` [dpdk-dev] [PATCH v6 0/3] net/failsafe: add Rx interrupts support Moti Haimovsky
2018-01-24 16:12 ` [dpdk-dev] [PATCH v6 1/3] net/failsafe: register as an Rx interrupt mode PMD Moti Haimovsky
2018-01-24 16:12 ` [dpdk-dev] [PATCH v6 2/3] net/failsafe: slaves Rx interrupts registration Moti Haimovsky
2018-01-25 8:07 ` [dpdk-dev] [PATCH v7 0/3] net/failsafe: add Rx interrupts support Moti Haimovsky
2018-01-25 8:07 ` [dpdk-dev] [PATCH v7 1/3] net/failsafe: register as an Rx interrupt mode PMD Moti Haimovsky
2018-01-25 11:36 ` Gaëtan Rivet
2018-01-25 8:07 ` [dpdk-dev] [PATCH v7 2/3] net/failsafe: slaves Rx interrupts registration Moti Haimovsky
2018-01-25 11:49 ` Gaëtan Rivet
2018-01-25 8:07 ` [dpdk-dev] [PATCH v7 3/3] net/failsafe: add Rx interrupts Moti Haimovsky
2018-01-25 11:58 ` Gaëtan Rivet
2018-01-25 16:19 ` [dpdk-dev] [PATCH v8 0/3] net/failsafe: add Rx interrupts support Moti Haimovsky
2018-01-25 16:19 ` [dpdk-dev] [PATCH v8 1/3] net/failsafe: register as an Rx interrupt mode PMD Moti Haimovsky
2018-01-25 16:19 ` [dpdk-dev] [PATCH v8 2/3] net/failsafe: slaves Rx interrupts registration Moti Haimovsky
2018-01-25 16:19 ` [dpdk-dev] [PATCH v8 3/3] net/failsafe: add Rx interrupts Moti Haimovsky
2018-01-25 16:53 ` [dpdk-dev] [PATCH v8 0/3] net/failsafe: add Rx interrupts support Gaëtan Rivet
2018-01-26 18:22 ` Ferruh Yigit
2018-01-24 16:12 ` [dpdk-dev] [PATCH v6 3/3] net/failsafe: add Rx interrupts Moti Haimovsky
2018-01-23 18:43 ` [dpdk-dev] [PATCH v5 " Moti Haimovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB1907E71C658DE2AB0B0A9ACBD2350@AM4PR05MB1907.eurprd05.prod.outlook.com \
--to=motih@mellanox.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).