From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx: remove pedantic definition for icc
Date: Wed, 23 Oct 2019 08:32:49 +0000 [thread overview]
Message-ID: <AM4PR05MB3265014B0A8E73405BA54641D26B0@AM4PR05MB3265.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1571819023-11692-1-git-send-email-rasland@mellanox.com>
> -----Original Message-----
> From: Raslan Darawsheh <rasland@mellanox.com>
> Sent: Wednesday, October 23, 2019 11:24
> To: Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/mlx: remove pedantic definition for icc
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
PS. The further considering of PEDANTIC removal at all is supposed.
> ---
> drivers/net/mlx4/Makefile | 5 ++++-
> drivers/net/mlx5/Makefile | 5 ++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile index
> 25d7c75..0abdc8d 100644
> --- a/drivers/net/mlx4/Makefile
> +++ b/drivers/net/mlx4/Makefile
> @@ -67,7 +67,10 @@ endif
>
> # User-defined CFLAGS.
> ifeq ($(CONFIG_RTE_LIBRTE_MLX4_DEBUG),y)
> -CFLAGS += -pedantic -UNDEBUG -DPEDANTIC
> +CFLAGS += -pedantic -UNDEBUG
> +ifneq ($(CONFIG_RTE_TOOLCHAIN), "icc")
> +CFLAGS += -DPEDANTIC
> +endif
> AUTO_CONFIG_CFLAGS += -Wno-pedantic
> else
> CFLAGS += -DNDEBUG -UPEDANTIC
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile index
> 04de93a..0369ee6 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -83,7 +83,10 @@ endif
>
> # User-defined CFLAGS.
> ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DEBUG),y)
> -CFLAGS += -pedantic -UNDEBUG -DPEDANTIC
> +CFLAGS += -pedantic -UNDEBUGi
> +ifneq ($(CONFIG_RTE_TOOLCHAIN), "icc")
> +CFLAGS += -DPEDANTIC
> +endif
> AUTO_CONFIG_CFLAGS += -Wno-pedantic
> else
> CFLAGS += -DNDEBUG -UPEDANTIC
> --
> 2.7.4
prev parent reply other threads:[~2019-10-23 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 8:23 Raslan Darawsheh
2019-10-23 8:32 ` Slava Ovsiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB3265014B0A8E73405BA54641D26B0@AM4PR05MB3265.eurprd05.prod.outlook.com \
--to=viacheslavo@mellanox.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).