From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2 01/13] net/mlx5: add representor recognition on kernels 5.x
Date: Tue, 26 Mar 2019 07:33:19 +0000 [thread overview]
Message-ID: <AM4PR05MB32651E9A9AC2566CAE43B6FAD25F0@AM4PR05MB3265.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20190325110743.6e98ff03@shemminger-XPS-13-9360>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, March 25, 2019 20:08
> To: Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org; Shahaf Shuler <shahafs@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH v2 01/13] net/mlx5: add representor
> recognition on kernels 5.x
>
> On Mon, 25 Mar 2019 17:03:22 +0000
> Viacheslav Ovsiienko <viacheslavo@mellanox.com> wrote:
>
> > + if (switch_id_set) {
> > + if (info.port_name_new) {
> > + /* New representors naming schema. */
> > + if (port_name_set) {
> > + info.master = (info.port_name == -1);
> > + info.representor = (info.port_name != -1);
> > + }
> > + } else {
> > + /* Legacy representors naming schema. */
> > + info.master = (!port_name_set || num_vf_set);
> > + info.representor = port_name_set && !num_vf_set;
> > + }
> > + }
> > + assert(!(data.master && data.representor));
> > memcpy(arg, &info, sizeof(info));
> > return 0;
>
> Since assert() is often removed in non-debug envirionments,
Assert should be removed (compiled out) in non-debug environments. If not (suddenly) - it must be resolved.
> why not add a log message and return an error instead?
Because there is no code producing assert wrong condition. No valid combination of entry values to produce master&&representor. It is intended by design. We do not expect master&&representor condition at all. It should never happen. Otherwise, we should notify the developer (because design is corrupted somewhere - and definitely it is not a runtime/user problem). So, assert seems to be the most relevant entity here.
>>instead?
We could add error/log in parallel, not instead of.
With best regards,
Slava
next prev parent reply other threads:[~2019-03-26 7:33 UTC|newest]
Thread overview: 217+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 18:02 [dpdk-dev] [RFC 00/10] net/mlx5: add support for multiport IB devices Viacheslav Ovsiienko
2019-02-28 18:02 ` [dpdk-dev] [RFC 01/10] net/mlx5: add multiport IB device port structure Viacheslav Ovsiienko
2019-02-28 18:02 ` [dpdk-dev] [RFC 02/10] net/mlx5: modify get ifindex routine for multiport IB Viacheslav Ovsiienko
2019-02-28 18:02 ` [dpdk-dev] [RFC 03/10] net/mlx5: add getting IB ports number " Viacheslav Ovsiienko
2019-02-28 18:02 ` [dpdk-dev] [RFC 04/10] net/mlx5: add multiport IB device support to probing Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 05/10] net/mlx5: add IB shared context alloc/free functions Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 06/10] net/mlx5: switch to the names in the shared IB context Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 07/10] net/mlx5: switch to the shared Protection Domain Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 08/10] net/mlx5: switch to the shared context IB attributes Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 09/10] net/mlx5: switch to the shared IB device context Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 10/10] net/mlx5: provide IB port for the object being created Viacheslav Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 00/14] net/mlx5: add support for multiport IB devices Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 01/14] net/mlx5: add representor recognition on kernels 5.x Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:13 ` Shahaf Shuler
2019-03-21 12:13 ` Shahaf Shuler
2019-03-21 15:08 ` Stephen Hemminger
2019-03-21 15:08 ` Stephen Hemminger
2019-03-21 15:31 ` Slava Ovsiienko
2019-03-21 15:31 ` Slava Ovsiienko
2019-03-21 19:08 ` Stephen Hemminger
2019-03-21 19:08 ` Stephen Hemminger
2019-03-22 8:15 ` Slava Ovsiienko
2019-03-22 8:15 ` Slava Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 02/14] net/mlx5: introduce multiport IB device shared structure Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 03/14] net/mlx5: modify get ifindex routine for multiport IB Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:58 ` Slava Ovsiienko
2019-03-21 12:58 ` Slava Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 04/14] net/mlx5: add getting IB ports number " Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 05/14] net/mlx5: add multiport IB device support to probing Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:54 ` Slava Ovsiienko
2019-03-21 12:54 ` Slava Ovsiienko
2019-03-21 12:57 ` Slava Ovsiienko
2019-03-21 12:57 ` Slava Ovsiienko
2019-03-24 9:00 ` Shahaf Shuler
2019-03-24 9:00 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 06/14] net/mlx5: add IB shared context alloc/free functions Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 07/14] net/mlx5: switch to the names in the shared IB context Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 08/14] net/mlx5: switch to the shared Protection Domain Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 09/14] net/mlx5: switch to the shared context IB attributes Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 10/14] net/mlx5: switch to the shared IB device context Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 11/14] net/mlx5: provide IB port for the object being created Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 12/14] net/mlx5: update install/uninstall int handler routines Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 14:01 ` Slava Ovsiienko
2019-03-21 14:01 ` Slava Ovsiienko
2019-03-24 9:07 ` Shahaf Shuler
2019-03-24 9:07 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 13/14] net/mlx5: update event handler for multiport IB devices Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 14:08 ` Slava Ovsiienko
2019-03-21 14:08 ` Slava Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 14/14] net/mlx5: add source vport match to the ingress rules Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 14:11 ` Slava Ovsiienko
2019-03-21 14:11 ` Slava Ovsiienko
2019-03-24 9:13 ` Shahaf Shuler
2019-03-24 9:13 ` Shahaf Shuler
2019-03-25 7:44 ` Slava Ovsiienko
2019-03-25 7:44 ` Slava Ovsiienko
2019-03-21 12:13 ` [dpdk-dev] [PATCH 00/14] net/mlx5: add support for multiport IB devices Shahaf Shuler
2019-03-21 12:13 ` Shahaf Shuler
2019-03-21 12:58 ` Slava Ovsiienko
2019-03-21 12:58 ` Slava Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 " Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 01/13] net/mlx5: add representor recognition on kernels 5.x Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 18:06 ` Stephen Hemminger
2019-03-25 18:06 ` Stephen Hemminger
2019-03-25 18:07 ` Stephen Hemminger
2019-03-25 18:07 ` Stephen Hemminger
2019-03-26 7:33 ` Slava Ovsiienko [this message]
2019-03-26 7:33 ` Slava Ovsiienko
2019-03-26 12:20 ` Shahaf Shuler
2019-03-26 12:20 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 02/13] net/mlx5: modify get ifindex routine for multiport IB Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 11:47 ` Shahaf Shuler
2019-03-26 11:47 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 03/13] net/mlx5: add getting IB ports number " Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 04/13] net/mlx5: add multiport IB device support to probing Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 12:02 ` Shahaf Shuler
2019-03-26 12:02 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 05/13] net/mlx5: add IB shared context alloc/free functions Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 12:10 ` Shahaf Shuler
2019-03-26 12:10 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 06/13] net/mlx5: switch to the names in the shared IB context Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 07/13] net/mlx5: switch to the shared Protection Domain Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 08/13] net/mlx5: switch to the shared context IB attributes Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 09/13] net/mlx5: switch to the shared IB device context Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 10/13] net/mlx5: provide IB port for the object being created Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 11/13] net/mlx5: update install/uninstall int handler routines Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 12:14 ` Shahaf Shuler
2019-03-26 12:14 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 12/13] net/mlx5: update event handler for multiport IB devices Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 12:16 ` Shahaf Shuler
2019-03-26 12:16 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 13/13] net/mlx5: add source vport match to the ingress rules Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 12:21 ` Shahaf Shuler
2019-03-26 12:21 ` Shahaf Shuler
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 00/14] net/mlx5: add support for multiport IB devices Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 01/13] net/mlx5: add representor recognition on kernels 5.x Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 19:37 ` Shahaf Shuler
2019-03-26 19:37 ` Shahaf Shuler
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 02/13] net/mlx5: modify get ifindex routine for multiport IB Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 03/13] net/mlx5: add getting IB ports number " Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 04/13] net/mlx5: add multiport IB device support to probing Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 05/13] net/mlx5: add IB shared context alloc/free functions Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 19:35 ` Shahaf Shuler
2019-03-26 19:35 ` Shahaf Shuler
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 06/13] net/mlx5: switch to the names in the shared IB context Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 07/13] net/mlx5: switch to the shared Protection Domain Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 08/13] net/mlx5: switch to the shared context IB attributes Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 09/13] net/mlx5: switch to the shared IB device context Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 10/13] net/mlx5: provide IB port for the object being created Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 11/13] net/mlx5: update install/uninstall int handler routines Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 12/13] net/mlx5: update event handler for multiport IB devices Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 13/13] net/mlx5: add source vport match to the ingress rules Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 19:38 ` Shahaf Shuler
2019-03-26 19:38 ` Shahaf Shuler
2019-03-27 6:00 ` [dpdk-dev] [PATCH v3 00/14] net/mlx5: add support for multiport IB devices Shahaf Shuler
2019-03-27 6:00 ` Shahaf Shuler
2019-03-27 7:31 ` Slava Ovsiienko
2019-03-27 7:31 ` Slava Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 " Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 01/13] net/mlx5: add representor recognition on kernels 5.x Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 02/13] net/mlx5: modify get ifindex routine for multiport IB Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 03/13] net/mlx5: add getting IB ports number " Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 04/13] net/mlx5: add multiport IB device support to probing Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 05/13] net/mlx5: add IB shared context alloc/free functions Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 06/13] net/mlx5: switch to the names in the shared IB context Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 07/13] net/mlx5: switch to the shared Protection Domain Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 08/13] net/mlx5: switch to the shared context IB attributes Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 09/13] net/mlx5: switch to the shared IB device context Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-04-02 4:49 ` Shahaf Shuler
2019-04-02 4:49 ` Shahaf Shuler
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 10/13] net/mlx5: provide IB port for the object being created Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 11/13] net/mlx5: update install/uninstall int handler routines Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 12/13] net/mlx5: update event handler for multiport IB devices Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 13/13] net/mlx5: add source vport match to the ingress rules Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-28 9:21 ` [dpdk-dev] [PATCH v4 00/14] net/mlx5: add support for multiport IB devices Shahaf Shuler
2019-03-28 9:21 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB32651E9A9AC2566CAE43B6FAD25F0@AM4PR05MB3265.eurprd05.prod.outlook.com \
--to=viacheslavo@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).