DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ori Kam <orika@mellanox.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
	"Wenzhuo Lu" <wenzhuo.lu@intel.com>,
	"Jingjing Wu" <jingjing.wu@intel.com>,
	"Bernard Iremonger" <bernard.iremonger@intel.com>,
	"Mohammad Abdul Awal" <mohammad.abdul.awal@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add NVGRE encap/decap support
Date: Tue, 19 Jun 2018 07:08:10 +0000	[thread overview]
Message-ID: <AM4PR05MB34257A7A4BC0C0B3B4E39C14DB700@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <fa9dd97d19d075be2f173de0b98e46b468bafb4f.1529332365.git.nelio.laranjeiro@6wind.com>

Small comment,

> -----Original Message-----
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
>  app/test-pmd/cmdline.c                      | 113 +++++++++++++++++
>  app/test-pmd/cmdline_flow.c                 | 129 ++++++++++++++++++++
>  app/test-pmd/testpmd.c                      |  15 +++
>  app/test-pmd/testpmd.h                      |  15 +++
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  14 +++
>  5 files changed, 286 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 93573606f..711914e53 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> +
> +static void cmd_set_nvgre_parsed(void *parsed_result,
> +	__attribute__((unused)) struct cmdline *cl,
> +	__attribute__((unused)) void *data)
> +{
> +	struct cmd_set_nvgre_result *res = parsed_result;
> +	uint32_t tni = rte_cpu_to_be_32(res->tni) >> 8;

Is this also correct in case of big endian system? 
I think it will  remove part of the tni.

> +
> +	if (strcmp(res->nvgre, "nvgre") == 0)
> +		nvgre_encap_conf.select_vlan = 0;
> +	else if (strcmp(res->nvgre, "nvgre-with-vlan") == 0)
> +		nvgre_encap_conf.select_vlan = 1;
> +	if (strcmp(res->ip_version, "ipv4") == 0)
> +		nvgre_encap_conf.select_ipv4 = 1;
> +	else if (strcmp(res->ip_version, "ipv6") == 0)
> +		nvgre_encap_conf.select_ipv4 = 0;
> +	else
> +		return;
> +	memcpy(nvgre_encap_conf.tni, &tni, 3);

I don't think this will work as expected in big endian system.

> +	if (nvgre_encap_conf.select_ipv4) {
> +		IPV4_ADDR_TO_UINT(res->ip_src,
> nvgre_encap_conf.ipv4_src);
> +		IPV4_ADDR_TO_UINT(res->ip_dst,
> nvgre_encap_conf.ipv4_dst);
> +	} else {
> +		IPV6_ADDR_TO_ARRAY(res->ip_src,
> nvgre_encap_conf.ipv6_src);
> +		IPV6_ADDR_TO_ARRAY(res->ip_dst,
> nvgre_encap_conf.ipv6_dst);
> +	}
> +	if (nvgre_encap_conf.select_vlan)
> +		nvgre_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci);
> +	memcpy(nvgre_encap_conf.eth_src, res->eth_src.addr_bytes,
> +	       ETHER_ADDR_LEN);
> +	memcpy(nvgre_encap_conf.eth_dst, res->eth_dst.addr_bytes,
> +	       ETHER_ADDR_LEN);
> +}
> +
> --
> 2.17.1


Best,
Ori

  reply	other threads:[~2018-06-19  7:08 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 15:08 [dpdk-dev] [PATCH 0/2] implement VXLAN/NVGRE Encap/Decap in testpmd Nelio Laranjeiro
2018-06-14 15:08 ` [dpdk-dev] [PATCH 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-14 15:09 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-15  9:32   ` Iremonger, Bernard
2018-06-15 11:25     ` Nélio Laranjeiro
2018-06-18  8:52 ` [dpdk-dev] [PATCH v2 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nelio Laranjeiro
2018-06-18  9:05   ` Ferruh Yigit
2018-06-18  9:38     ` Nélio Laranjeiro
2018-06-18 14:40       ` Ferruh Yigit
2018-06-19  7:32         ` Nélio Laranjeiro
2018-06-18 14:36   ` [dpdk-dev] [PATCH v3 " Nelio Laranjeiro
2018-06-18 16:28     ` Iremonger, Bernard
2018-06-19  9:41       ` Nélio Laranjeiro
2018-06-21  7:13     ` [dpdk-dev] [PATCH v4 " Nelio Laranjeiro
2018-06-21  7:13       ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-26 10:51         ` Ori Kam
2018-06-26 12:43         ` Iremonger, Bernard
2018-06-21  7:13       ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-26 10:48         ` Ori Kam
2018-06-26 12:48         ` Iremonger, Bernard
2018-06-26 15:15           ` Nélio Laranjeiro
2018-06-22  7:42       ` [dpdk-dev] [PATCH v4 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Mohammad Abdul Awal
2018-06-22  8:31         ` Nélio Laranjeiro
2018-06-22  8:51           ` Mohammad Abdul Awal
2018-06-22  9:08             ` Nélio Laranjeiro
2018-06-22 10:19               ` Mohammad Abdul Awal
2018-06-26 15:15                 ` Nélio Laranjeiro
2018-06-27  8:53       ` [dpdk-dev] [PATCH v5 " Nelio Laranjeiro
2018-06-27  8:53         ` [dpdk-dev] [PATCH v5 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27  8:53         ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-27  9:53         ` [dpdk-dev] [PATCH v6 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nelio Laranjeiro
2018-06-27  9:53           ` [dpdk-dev] [PATCH v6 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27  9:53           ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-27 10:00           ` [dpdk-dev] [PATCH v6 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nélio Laranjeiro
2018-06-27 11:45           ` [dpdk-dev] [PATCH v7 " Nelio Laranjeiro
2018-06-27 11:45             ` [dpdk-dev] [PATCH v7 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27 11:45             ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-02 10:40             ` [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Mohammad Abdul Awal
2018-07-04 14:54               ` Ferruh Yigit
2018-07-05  9:37                 ` Nélio Laranjeiro
2018-07-05 14:33             ` [dpdk-dev] [PATCH v8 " Nelio Laranjeiro
2018-07-05 14:33               ` [dpdk-dev] [PATCH v8 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-07-05 15:03                 ` Mohammad Abdul Awal
2018-07-05 14:33               ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-05 15:07                 ` Mohammad Abdul Awal
2018-07-05 15:17                   ` Nélio Laranjeiro
2018-07-05 14:48               ` [dpdk-dev] [PATCH v8 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Adrien Mazarguil
2018-07-05 14:57               ` Mohammad Abdul Awal
2018-07-06  6:43               ` [dpdk-dev] [PATCH v9 " Nelio Laranjeiro
2018-07-06  6:43                 ` [dpdk-dev] [PATCH v9 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-07-06  6:43                 ` [dpdk-dev] [PATCH v9 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-18  8:31                 ` [dpdk-dev] [PATCH v9 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Ferruh Yigit
2018-06-18 14:36   ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-19  7:09     ` Ori Kam
2018-06-19  9:40       ` Nélio Laranjeiro
2018-06-18 14:36   ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-19  7:08     ` Ori Kam [this message]
2018-06-18  8:52 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN " Nelio Laranjeiro
2018-06-18 12:47   ` Mohammad Abdul Awal
2018-06-18 21:02   ` Stephen Hemminger
2018-06-19  9:44     ` Nélio Laranjeiro
2018-06-18  8:52 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-18 12:48   ` Mohammad Abdul Awal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR05MB34257A7A4BC0C0B3B4E39C14DB700@AM4PR05MB3425.eurprd05.prod.outlook.com \
    --to=orika@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=mohammad.abdul.awal@intel.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).