From: Ori Kam <orika@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix compilation for rdma-core v19
Date: Thu, 12 Jul 2018 10:53:31 +0000 [thread overview]
Message-ID: <AM4PR05MB342584BBB9173A96D4CEBEC7DB590@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180712065653.29801-1-shahafs@mellanox.com>
> -----Original Message-----
> From: Shahaf Shuler [mailto:shahafs@mellanox.com]
> Sent: Thursday, July 12, 2018 9:57 AM
> To: Yongseok Koh <yskoh@mellanox.com>
> Cc: dev@dpdk.org; ferruh.yigit@intel.com; stephen@networkplumber.org;
> stable@dpdk.org; Ori Kam <orika@mellanox.com>
> Subject: [PATCH] net/mlx5: fix compilation for rdma-core v19
>
> The flow counter support introduced by
> commit 9a761de8ea14 ("net/mlx5: flow counter support") was intend to
> work only with MLNX_OFED_4.3 as the upstream rdma-core
> libraries were lack such support.
>
> On rdma-core v19 the support for the flow counters was added but with
> different user APIs, hence causing compilation issues on the PMD.
>
> This patch fix the compilation errors by forcing the flow counters
> to be enabled only with MLNX_OFED APIs.
> Once MLNX_OFED and rdma-core APIs will be aligned, a proper patch to
> support the new API will be submitted.
>
> Fixes: 9a761de8ea14 ("net/mlx5: flow counter support")
> Cc: stable@dpdk.org
> Cc: orika@mellanox.com
>
> Reported-by:Stephen Hemminger <stephen@networkplumber.org>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> index 9e274964b4..d86c6bbab9 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -150,7 +150,7 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto-
> config-h.sh
> $Q sh -- '$<' '$@' \
> HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT \
> infiniband/verbs.h \
> - enum IBV_FLOW_SPEC_ACTION_COUNT \
> + type 'struct ibv_counter_set_init_attr' \
> $(AUTOCONF_OUTPUT)
> $Q sh -- '$<' '$@' \
> HAVE_RDMA_NL_NLDEV \
> --
> 2.12.0
Acked-by: Ori Kam <orika@mellanox.com>
next prev parent reply other threads:[~2018-07-12 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 6:56 Shahaf Shuler
2018-07-12 10:53 ` Ori Kam [this message]
2018-07-12 10:57 ` Shahaf Shuler
2018-07-17 14:59 ` Christian Ehrhardt
2018-07-23 7:30 Shahaf Shuler
2018-07-23 17:09 ` Luca Boccassi
2018-07-24 4:53 ` Shahaf Shuler
2018-07-24 8:15 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB342584BBB9173A96D4CEBEC7DB590@AM4PR05MB3425.eurprd05.prod.outlook.com \
--to=orika@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).