From: Ori Kam <orika@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
Dekel Peled <dekelp@mellanox.com>,
"rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd doc
Date: Thu, 6 Dec 2018 12:15:26 +0000 [thread overview]
Message-ID: <AM4PR05MB3425B6CBEBCA51C163DF582DDBA90@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1544097974-5507-1-git-send-email-dekelp@mellanox.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Thursday, December 6, 2018 2:06 PM
> To: wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> bernard.iremonger@intel.com
> Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>; Dekel Peled <dekelp@mellanox.com>;
> rahul.lakkireddy@chelsio.com
> Subject: [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd
> doc
>
> testpmd actions set_tp_src and set_tp_dst documentation adds the
> of_ prefix to action names, while the implementation doesn't add it.
>
> This patch removes the prefix from action names in testpmd
> documentation.
>
> Fixes: 9ccc94919500 ("ethdev: add flow API actions to modify TCP/UDP port
> numbers")
> Cc: rahul.lakkireddy@chelsio.com
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 056f8bb..9d4f107 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -3931,12 +3931,12 @@ This section lists supported actions and their
> attributes, if any.
>
> - ``ipv6_addr``: New IPv6 destination address.
>
> -- ``of_set_tp_src``: Set a new source port number in the outermost TCP/UDP
> +- ``set_tp_src``: Set a new source port number in the outermost TCP/UDP
> header.
>
> - ``port``: New TCP/UDP source port number.
>
> -- ``of_set_tp_dst``: Set a new destination port number in the outermost
> TCP/UDP
> +- ``set_tp_dst``: Set a new destination port number in the outermost TCP/UDP
> header.
>
> - ``port``: New TCP/UDP destination port number.
> --
> 1.8.3.1
Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
Ori
next prev parent reply other threads:[~2018-12-06 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 12:06 Dekel Peled
2018-12-06 12:15 ` Ori Kam [this message]
2018-12-06 12:18 ` Rahul Lakkireddy
2018-12-11 17:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB3425B6CBEBCA51C163DF582DDBA90@AM4PR05MB3425.eurprd05.prod.outlook.com \
--to=orika@mellanox.com \
--cc=bernard.iremonger@intel.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=shahafs@mellanox.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).