From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"santosh.shukla@caviumnetworks.com"
<santosh.shukla@caviumnetworks.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sunil Kumar Kori <sunil.kori@nxp.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH 2/4] bus/dpaa: fix registering dpaa mempool ops
Date: Mon, 5 Feb 2018 06:31:32 +0000 [thread overview]
Message-ID: <AM5PR0401MB24511D48B58A75CEAB5B350390FE0@AM5PR0401MB2451.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1517808117-28562-2-git-send-email-nipun.gupta@nxp.com>
> -----Original Message-----
> From: Nipun Gupta
> Sent: Monday, February 5, 2018 10:52 AM
> To: thomas@monjalon.net; jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org; santosh.shukla@caviumnetworks.com; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Shreyansh Jain <shreyansh.jain@nxp.com>;
> Sunil Kumar Kori <sunil.kori@nxp.com>; Nipun Gupta
> <nipun.gupta@nxp.com>
> Subject: [PATCH 2/4] bus/dpaa: fix registering dpaa mempool ops
>
> Fixes: 2bd0d5b951a9 ("bus/dpaa: register platform HW mempool on
> runtime")
>
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
> drivers/bus/dpaa/dpaa_bus.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
> index 1946bbe..290b967 100644
> --- a/drivers/bus/dpaa/dpaa_bus.c
> +++ b/drivers/bus/dpaa/dpaa_bus.c
> @@ -495,10 +495,16 @@ int rte_dpaa_portal_fq_close(struct qman_fq *fq)
> ret = drv->probe(drv, dev);
> if (ret)
> DPAA_BUS_ERR("Unable to probe.\n");
> +
> break;
> }
> }
> - rte_mbuf_set_platform_mempool_ops(DPAA_MEMPOOL_OPS_NAME);
> +
> + /* Register DPAA mempool ops only if any DPAA device has
> + * been detected.
> + */
> + if (!TAILQ_EMPTY(&rte_dpaa_bus.device_list))
> +
> rte_mbuf_set_platform_mempool_ops(DPAA_MEMPOOL_OPS_NAME);
>
> svr_file = fopen(DPAA_SOC_ID_FILE, "r");
> if (svr_file) {
> --
> 1.9.1
>
Just a note: there is an extra line insertion in this patch which is not related to the patch fix. Though, I think that makes the code more readable as preceding if() for this new line is without {}.
Acked-by: Shreyansh Jain <Shreyansh.jain@nxp.com>
next prev parent reply other threads:[~2018-02-05 6:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 5:21 [dpdk-dev] [PATCH 1/4] bus/fslmc: fix registering dpaa2 " Nipun Gupta
2018-02-05 5:21 ` [dpdk-dev] [PATCH 2/4] bus/dpaa: fix registering dpaa " Nipun Gupta
2018-02-05 5:36 ` santosh
2018-02-05 6:31 ` Shreyansh Jain [this message]
2018-02-05 5:21 ` [dpdk-dev] [PATCH 3/4] event/dpaa: rename dpaa vdev with dpaa1 Nipun Gupta
2018-02-05 11:56 ` Hemant Agrawal
2018-02-05 5:21 ` [dpdk-dev] [PATCH 4/4] event/dpaa: fix portal allocation Nipun Gupta
2018-02-05 11:53 ` Hemant Agrawal
2018-02-05 6:32 ` [dpdk-dev] [PATCH 1/4] bus/fslmc: fix registering dpaa2 mempool ops Shreyansh Jain
2018-02-05 23:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR0401MB24511D48B58A75CEAB5B350390FE0@AM5PR0401MB2451.eurprd04.prod.outlook.com \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nipun.gupta@nxp.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=sunil.kori@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).