From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] raw/skeleton_rawdev: fix device start test
Date: Mon, 5 Feb 2018 16:25:59 +0000 [thread overview]
Message-ID: <AM5PR0401MB245164C9D5AE65C4B6ACABE690FE0@AM5PR0401MB2451.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <14198513.UUEtOtHhuI@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, February 5, 2018 7:41 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v3] raw/skeleton_rawdev: fix device start test
>
> 05/02/2018 12:31, Shreyansh Jain:
> > Device can only be started if firmware is loaded, as per Skeleton
> > rawdev driver semantics. This patch fixes original implementation
> > which attempted to start the device without loading firmware.
> >
> > Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases")
> > Cc: shreyansh.jain@nxp.com
> >
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> > ---
> > v3:
> > - Moving 'Fixes' below commit message
> > - patch headline made specific
> >
> > v2:
> > - Fixed headline from drivers/raw to raw/skeleton_rawdev
>
> Actually, it should be raw/skeleton because it is shorter
> and it is what was chosen for previous commits :)
Yes, that is shorter but not correct as per directory name. And, I thought I had made a mistake in previous commit.
In hindsight, my choice for driver name itself was not correct - I had thought of type_subtype but it doesn't sound right now that it is directory. I will change that in next release, I guess.
I will send v4 with 'raw/skeleton'.
next prev parent reply other threads:[~2018-02-05 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 11:16 [dpdk-dev] [PATCH] drivers/raw: fix incorrect device start Shreyansh Jain
2018-02-05 11:24 ` [dpdk-dev] [PATCH v2] raw/skeleton_rawdev: " Shreyansh Jain
2018-02-05 11:31 ` [dpdk-dev] [PATCH v3] raw/skeleton_rawdev: fix device start test Shreyansh Jain
2018-02-05 14:10 ` Thomas Monjalon
2018-02-05 16:25 ` Shreyansh Jain [this message]
2018-02-06 6:43 ` [dpdk-dev] [PATCH v4] raw/skeleton: " Shreyansh Jain
2018-02-06 16:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR0401MB245164C9D5AE65C4B6ACABE690FE0@AM5PR0401MB2451.eurprd04.prod.outlook.com \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).