From: Ori Kam <orika@mellanox.com>
To: Bernard Iremonger <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"beilei.xing@intel.com" <beilei.xing@intel.com>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
"declan.doherty@intel.com" <declan.doherty@intel.com>
Cc: "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH
Date: Tue, 31 Mar 2020 09:57:53 +0000 [thread overview]
Message-ID: <AM6PR05MB51762AE118D2D3D4C05AD95DDBC80@AM6PR05MB5176.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1585151755-15837-3-git-send-email-bernard.iremonger@intel.com>
Hi Bernard,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Bernard Iremonger
> Sent: Wednesday, March 25, 2020 5:56 PM
> To: dev@dpdk.org; beilei.xing@intel.com; qi.z.zhang@intel.com;
> declan.doherty@intel.com
> Cc: konstantin.ananyev@intel.com; Bernard Iremonger
> <bernard.iremonger@intel.com>
> Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP
> and AH
>
> parse RSS offload types ESP and AH
> add printf for rss_hf
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> app/test-pmd/cmdline.c | 4 +++-
> app/test-pmd/config.c | 6 ++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index a037a55..997f063 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result,
> i, -diag, strerror(-diag));
> }
> }
> - if (all_updated && !use_default)
> + if (all_updated && !use_default) {
> rss_hf = rss_conf.rss_hf;
> + printf("rss_hf %#"PRIx64"\n", rss_hf);
> + }
> }
>
> cmdline_parse_token_string_t cmd_config_rss_port =
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 8cf84cc..df52df9 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -106,6 +106,12 @@ const struct rss_type_info rss_type_table[] = {
> { "l3-dst-only", ETH_RSS_L3_DST_ONLY },
> { "l4-src-only", ETH_RSS_L4_SRC_ONLY },
> { "l4-dst-only", ETH_RSS_L4_DST_ONLY },
> + { "ipv4-esp", ETH_RSS_ESP },
> + { "ipv6-esp", ETH_RSS_ESP },
> + { "ipv4-udp-esp", ETH_RSS_ESP },
> + { "ipv6-udp-esp", ETH_RSS_ESP },
> + { "ipv4-ah", ETH_RSS_AH },
> + { "ipv6-ah", ETH_RSS_AH },
Why do you have all those variations since they don't have any affect.
I think it should be just like your first patch, only esp and ah.
For example the udp should look like this:
flow create 0 ingress pattern eth / end actions rss queues 0 1 end types udp esp end / end
Best,
Ori
> { NULL, 0 },
> };
>
> --
> 2.7.4
next prev parent reply other threads:[~2020-03-31 9:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 12:38 [dpdk-dev] [PATCH 0/3] configure RSS hash Bernard Iremonger
2020-03-18 12:38 ` [dpdk-dev] [PATCH 1/3] librte_ethdev: add RSS offload types for ESP and AH Bernard Iremonger
2020-03-18 12:38 ` [dpdk-dev] [PATCH 2/3] app/testpmd: handle RSS offload types " Bernard Iremonger
2020-03-18 12:38 ` [dpdk-dev] [PATCH 3/3] net/i40e: configure RSS hash from RSS action Bernard Iremonger
[not found] ` <e0bea82c974e4d238a6e318093818363@intel.com>
2020-03-24 9:47 ` Iremonger, Bernard
2020-03-25 15:55 ` [dpdk-dev] [PATCH v2 0/3] configure RSS hash Bernard Iremonger
2020-03-31 13:56 ` [dpdk-dev] [PATCH v3 " Bernard Iremonger
2020-04-15 11:14 ` [dpdk-dev] [PATCH v4 " Bernard Iremonger
2020-04-16 14:30 ` Ferruh Yigit
2020-04-15 11:14 ` [dpdk-dev] [PATCH v4 1/3] librte_ethdev: add RSS offload types for ESP and AH Bernard Iremonger
2020-04-16 1:14 ` Xing, Beilei
2020-04-16 14:30 ` Ferruh Yigit
2020-04-16 13:26 ` Dong Zhou
2020-04-16 14:30 ` Ferruh Yigit
2020-04-16 14:38 ` Iremonger, Bernard
2020-04-15 11:14 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: handle RSS offload types " Bernard Iremonger
2020-04-15 11:14 ` [dpdk-dev] [PATCH v4 3/3] net/i40e: add ESP patterns Bernard Iremonger
2020-04-16 1:13 ` Xing, Beilei
2020-03-31 13:56 ` [dpdk-dev] [PATCH v3 1/3] librte_ethdev: add RSS offload types for ESP and AH Bernard Iremonger
2020-04-15 2:09 ` Xing, Beilei
2020-03-31 13:56 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: handle RSS offload types " Bernard Iremonger
2020-04-02 11:49 ` Ori Kam
2020-03-31 13:56 ` [dpdk-dev] [PATCH v3 3/3] net/i40e: add ESP patterns Bernard Iremonger
2020-03-25 15:55 ` [dpdk-dev] [PATCH v2 1/3] librte_ethdev: add RSS offload types for ESP and AH Bernard Iremonger
2020-03-25 15:55 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types " Bernard Iremonger
2020-03-31 9:57 ` Ori Kam [this message]
2020-03-31 11:03 ` Iremonger, Bernard
2020-03-25 15:55 ` [dpdk-dev] [PATCH v2 3/3] net/i40e: add ESP patterns Bernard Iremonger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR05MB51762AE118D2D3D4C05AD95DDBC80@AM6PR05MB5176.eurprd05.prod.outlook.com \
--to=orika@mellanox.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).