From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Wiles, Keith" <keith.wiles@intel.com>,
Jakub Grajciar <jgrajcia@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [RFC v2] /net: memory interface (memif)
Date: Mon, 17 Dec 2018 04:26:01 +0000 [thread overview]
Message-ID: <AM6PR08MB3672884B64E69E30640F547D98BC0@AM6PR08MB3672.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <92C073C7-AB56-47BE-825B-C3CE30F73EAB@intel.com>
> >
> >> On Dec 10, 2018, at 4:06 AM, Jakub Grajciar <jgrajcia@cisco.com> wrote:
> >
> > I do not like being the coding style police, but that is most of the comments
> here and I will try to test this one later this week. Plus I am sure I missed some
> style problems, if you have not read the coding style for DPDK please have a
> read.
> >
> > http://doc.dpdk.org/guides/contributing/coding_style.html
> >
> > One comment, why did you include all of the code to handle memif instead
> of including the libmemif.a from VPP. I worry if libmemif is changed then we
> have a breakage. I do not mind the PMD being standalone and I do like not
> having the dependence.
Just for my understanding, do you mean to say we could include the libmemif.a as a binary in DPDK?
IMO, I would like to view DPDK as the device abstraction and VPP as the protocol stack built on top. From this perspective, it is good to have standalone memif in DPDK.
> >
> > As I did not dive into the code much it does look reasonable and I hope to
> give it a try later this week.
> >>
>
> A couple more items, do you plan on writing the documentation for the PMD
> and provide an example program?
+1, would be good to have a cover letter.
I would like to run this on Arm platforms, mostly in the beginning of Jan.
>
> Regards,
> Keith
next prev parent reply other threads:[~2018-12-17 4:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 9:14 [dpdk-dev] [PATCH v3] eal_interrupts: add option for pending callback unregister Jakub Grajciar
2018-12-10 9:42 ` [dpdk-dev] [RFC] /net: memory interface (memif) Jakub Grajciar
2018-12-10 10:06 ` [dpdk-dev] [RFC v2] " Jakub Grajciar
2018-12-10 10:42 ` Burakov, Anatoly
2018-12-10 10:50 ` Richardson, Bruce
2018-12-12 10:19 ` Burakov, Anatoly
2018-12-12 10:30 ` Bruce Richardson
2018-12-10 14:48 ` Wiles, Keith
2018-12-10 15:13 ` Wiles, Keith
2018-12-17 4:26 ` Honnappa Nagarahalli [this message]
2018-12-17 4:54 ` Honnappa Nagarahalli
2018-12-10 16:20 ` Stephen Hemminger
2018-12-11 7:39 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR08MB3672884B64E69E30640F547D98BC0@AM6PR08MB3672.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=keith.wiles@intel.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).