From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"Joyce Kong (Arm Technology China)" <Joyce.Kong@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
Bruce Richardson <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevant perf test case
Date: Mon, 17 Dec 2018 05:16:55 +0000 [thread overview]
Message-ID: <AM6PR08MB3672AD9C7530196E5B1DBBA398BC0@AM6PR08MB3672.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <VI1PR08MB3167EC78EA944CA3141E094D8FA10@VI1PR08MB3167.eurprd08.prod.outlook.com>
Adding other platform maintainers as it affects all platforms.
> -----Original Message-----
> From: Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>
> Sent: Thursday, December 13, 2018 7:30 PM
> To: Stephen Hemminger <stephen@networkplumber.org>; Joyce Kong (Arm
> Technology China) <Joyce.Kong@arm.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; thomas@monjalon.net;
> jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Subject: RE: [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevant
> perf test case
>
> Hi Stephen,
>
> Thanks for your comment and sharing the link!
> We are looking into it and it may take more time for performance profiling.
>
> Best Regards,
> Gavin
>
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Thursday, December 13, 2018 1:27 PM
> > To: Joyce Kong (Arm Technology China) <Joyce.Kong@arm.com>
> > Cc: dev@dpdk.org; nd <nd@arm.com>; thomas@monjalon.net;
> > jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; Honnappa
> > Nagarahalli <Honnappa.Nagarahalli@arm.com>; Gavin Hu (Arm Technology
> > China) <Gavin.Hu@arm.com>
> > Subject: Re: [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add
> > relevant perf test case
> >
> > On Thu, 13 Dec 2018 11:37:43 +0800
> > Joyce Kong <joyce.kong@arm.com> wrote:
> >
> > > v1: reimplement rwlock with __atomic builtins, and add a rwlock perf test
> > > on all available cores to benchmark the improvement.
> > >
> > > We tested the patches on three arm64 platforms, ThundeX2 gained 20%
> > > performance, Qualcomm gained 36% and the 4-Cortex-A72 Marvell
> > MACCHIATObin gained 19.6%.
> > > Below is the detailed test result on ThunderX2:
> > >
> > > *** rwlock_autotest without __atomic builtins *** Rwlock Perf Test
> > > on
> > > 128 cores...
> > > Core [0] count = 281
> > > Core [1] count = 252
> > > Core [2] count = 290
> > > Core [3] count = 259
> > > Core [4] count = 287
> > > ...
> > > Core [209] count = 3
> > > Core [210] count = 31
> > > Core [211] count = 120
> > > Total count = 18537
> > >
> > > *** rwlock_autotest with __atomic builtins *** Rwlock Perf Test on
> > > 128 cores...
> > > Core [0] count = 346
> > > Core [1] count = 355
> > > Core [2] count = 259
> > > Core [3] count = 285
> > > Core [4] count = 320
> > > ...
> > > Core [209] count = 2
> > > Core [210] count = 23
> > > Core [211] count = 63
> > > Total count = 22194
> > >
> > > Gavin Hu (1):
> > > rwlock: reimplement with __atomic builtins
> > >
> > > Joyce Kong (1):
> > > test/rwlock: add perf test case
> > >
> > > lib/librte_eal/common/include/generic/rte_rwlock.h | 16 ++---
> > > test/test/test_rwlock.c | 71 ++++++++++++++++++++++
> > > 2 files changed, 79 insertions(+), 8 deletions(-)
> > >
> >
> > Did you consider using a better algorithm not just better primitives.
> > See https://locklessinc.com/articles/locks/ for a more complete
> > discussion of alternatives like ticket locks.
next prev parent reply other threads:[~2018-12-17 5:16 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 3:37 Joyce Kong
2018-12-13 3:37 ` [dpdk-dev] [PATCH v1 1/2] test/rwlock: add " Joyce Kong
2018-12-19 23:34 ` Ananyev, Konstantin
2018-12-20 1:01 ` Gavin Hu (Arm Technology China)
2018-12-20 1:45 ` Honnappa Nagarahalli
2019-03-14 13:15 ` [dpdk-dev] [PATCH v3 0/3] rwlock: reimplement rwlock with atomic and add relevant " Joyce Kong
2019-03-14 13:15 ` Joyce Kong
2019-03-14 13:15 ` [dpdk-dev] [PATCH v3 1/3] rwlock: reimplement with atomic builtins Joyce Kong
2019-03-14 13:15 ` Joyce Kong
2019-03-14 15:54 ` Stephen Hemminger
2019-03-14 15:54 ` Stephen Hemminger
2019-03-15 3:04 ` Gavin Hu (Arm Technology China)
2019-03-15 3:04 ` Gavin Hu (Arm Technology China)
2019-03-15 11:41 ` Ananyev, Konstantin
2019-03-15 11:41 ` Ananyev, Konstantin
2019-03-19 8:31 ` Gavin Hu (Arm Technology China)
2019-03-19 8:31 ` Gavin Hu (Arm Technology China)
2019-03-14 13:15 ` [dpdk-dev] [PATCH v3 2/3] test/rwlock: add perf test case on all available cores Joyce Kong
2019-03-14 13:15 ` Joyce Kong
2019-03-14 13:15 ` [dpdk-dev] [PATCH v3 3/3] test/rwlock: amortize the cost of getting time Joyce Kong
2019-03-14 13:15 ` Joyce Kong
2019-03-14 15:02 ` Honnappa Nagarahalli
2019-03-14 15:02 ` Honnappa Nagarahalli
2019-03-20 6:25 ` [dpdk-dev] [PATCH v4 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case Joyce Kong
2019-03-20 6:25 ` Joyce Kong
2019-03-20 6:25 ` [dpdk-dev] [PATCH v4 1/3] rwlock: reimplement with atomic builtins Joyce Kong
2019-03-20 6:25 ` Joyce Kong
2019-03-21 18:43 ` Ananyev, Konstantin
2019-03-21 18:43 ` Ananyev, Konstantin
2019-03-25 9:18 ` Joyce Kong (Arm Technology China)
2019-03-25 9:18 ` Joyce Kong (Arm Technology China)
2019-03-20 6:25 ` [dpdk-dev] [PATCH v4 2/3] test/rwlock: add perf test case on all available cores Joyce Kong
2019-03-20 6:25 ` Joyce Kong
2019-03-21 18:44 ` Ananyev, Konstantin
2019-03-21 18:44 ` Ananyev, Konstantin
2019-03-20 6:25 ` [dpdk-dev] [PATCH v4 3/3] test/rwlock: amortize the cost of getting time Joyce Kong
2019-03-20 6:25 ` Joyce Kong
2019-03-21 18:44 ` Ananyev, Konstantin
2019-03-21 18:44 ` Ananyev, Konstantin
2019-03-25 9:14 ` [dpdk-dev] [PATCH v5 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case Joyce Kong
2019-03-25 9:14 ` Joyce Kong
2019-03-28 10:50 ` Thomas Monjalon
2019-03-28 10:50 ` Thomas Monjalon
2019-04-16 14:57 ` Kevin Traynor
2019-04-16 14:57 ` Kevin Traynor
2019-03-25 9:14 ` [dpdk-dev] [PATCH v5 1/3] rwlock: reimplement with atomic builtins Joyce Kong
2019-03-25 9:14 ` Joyce Kong
2019-03-25 9:14 ` [dpdk-dev] [PATCH v5 2/3] test/rwlock: add perf test case on all available cores Joyce Kong
2019-03-25 9:14 ` Joyce Kong
2019-03-25 9:14 ` [dpdk-dev] [PATCH v5 3/3] test/rwlock: amortize the cost of getting time Joyce Kong
2019-03-25 9:14 ` Joyce Kong
2018-12-13 3:37 ` [dpdk-dev] [PATCH v1 2/2] rwlock: reimplement with __atomic builtins Joyce Kong
2018-12-19 23:50 ` Ananyev, Konstantin
2018-12-13 5:27 ` [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevant perf test case Stephen Hemminger
2018-12-14 1:30 ` Gavin Hu (Arm Technology China)
2018-12-17 5:16 ` Honnappa Nagarahalli [this message]
2018-12-19 20:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR08MB3672AD9C7530196E5B1DBBA398BC0@AM6PR08MB3672.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).