From: Joyce Kong <Joyce.Kong@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>,
Ruifeng Wang <Ruifeng.Wang@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Paul Szczepanek <Paul.Szczepanek@arm.com>, nd <nd@arm.com>
Subject: RE: [PATCH v1] config/arm: correct cpu arch for cross build
Date: Tue, 7 Nov 2023 02:42:08 +0000 [thread overview]
Message-ID: <AS4PR08MB7712F6998479AADB2F579B1B92A9A@AS4PR08MB7712.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1979791.8hb0ThOEGa@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, November 6, 2023 11:38 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Cc: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>; nd
> <nd@arm.com>; Paul Szczepanek <Paul.Szczepanek@arm.com>; Joyce Kong
> <Joyce.Kong@arm.com>
> Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
>
> 06/11/2023 15:31, Joyce Kong:
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Monday, November 6, 2023 10:10 PM
> > > To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Joyce Kong
> > > <Joyce.Kong@arm.com>
> > > Cc: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>;
> > > dev@dpdk.org; nd <nd@arm.com>; Paul Szczepanek
> > > <Paul.Szczepanek@arm.com>
> > > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
> > >
> > > 18/10/2023 07:40, Joyce Kong:
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > 22/08/2023 09:47, Joyce Kong:
> > > > > > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > > > > > N2 is armv8.5-a arch.
> > > > > > The cpu field in the cross file doesn't take effect as
> > > > > > config/arm/meson.build controls machine_args for march.
> > > > > > Then correct the value in arm cross files to 'auto'.
> > > > >
> > > > > I don't get it.
> > > > > Why setting a value if it has no impact?
> > > > > Looks like something is overcomplicated.
> > > > >
> > > > We still have to declare them here because meson would check the 'cpu'
> > > line in the config file, otherwise it would report missing {'cpu'}.
> > >
> > > OK
> > >
> > > Then why not all cross files are set to auto?
> > >
> > Actually, I set all the Arm cross files to auto in this patch. Maybe I have to
> figure it out in the commit line?
>
> What about these ones?
>
> git grep 'cpu = ' config/arm | grep -v auto
>
> config/arm/arm64_altra_linux_gcc:cpu = 'armv8.2-a'
> config/arm/arm64_ampereone_linux_gcc:cpu = 'armv8.6-a'
> config/arm/arm64_bluefield3_linux_gcc:cpu = 'armv8.4-a'
> config/arm/arm64_cdx_linux_gcc:cpu = 'armv8-a'
> config/arm/arm64_hip10_linux_gcc:cpu = 'armv8-a'
>
>
Really sorry for missing them as I didn't update the version, I shall correct them in next patch.
next prev parent reply other threads:[~2023-11-07 2:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 7:47 Joyce Kong
2023-10-17 19:41 ` Thomas Monjalon
2023-10-18 5:40 ` Joyce Kong
2023-11-06 14:10 ` Thomas Monjalon
2023-11-06 14:31 ` Joyce Kong
2023-11-06 15:38 ` Thomas Monjalon
2023-11-07 2:42 ` Joyce Kong [this message]
2023-11-07 3:26 ` [PATCH v2] " Joyce Kong
2023-11-12 12:53 ` Thomas Monjalon
2023-11-20 8:51 ` Joyce Kong
2023-11-20 9:24 ` [PATCH v3] " Joyce Kong
2023-11-20 16:54 ` Thomas Monjalon
2023-11-22 7:10 ` Joyce Kong
2023-12-05 3:52 ` [PATCH v4 0/2] config changes " Joyce Kong
2023-12-05 3:52 ` [PATCH v4 1/2] config: correct cpu instruction set " Joyce Kong
2023-12-07 22:41 ` Stephen Hemminger
2023-12-08 2:51 ` Joyce Kong
2024-01-19 19:39 ` Pavan Nikhilesh Bhagavatula
2024-03-06 14:43 ` Thomas Monjalon
2023-12-05 3:52 ` [PATCH v4 2/2] config/arm: use common cpu arch for cross files Joyce Kong
2023-12-07 22:41 ` Stephen Hemminger
2024-01-19 19:40 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-02-18 17:56 ` Thomas Monjalon
2024-02-22 21:38 ` Wathsala Wathawana Vithanage
2024-03-06 14:43 ` Thomas Monjalon
2024-03-06 15:01 ` Wathsala Wathawana Vithanage
2024-03-06 15:04 ` Wathsala Wathawana Vithanage
2024-03-06 15:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR08MB7712F6998479AADB2F579B1B92A9A@AS4PR08MB7712.eurprd08.prod.outlook.com \
--to=joyce.kong@arm.com \
--cc=Paul.Szczepanek@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).