From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: luzhipeng <luzhipeng@cestc.cn>,
Jan Viktorin <viktorin@rehivetech.com>,
Bruce Richardson <bruce.richardson@intel.com>, nd <nd@arm.com>
Subject: RE: [PATCH v3] config/arm: add Phytium FT-2000+
Date: Tue, 5 Jul 2022 13:50:31 +0000 [thread overview]
Message-ID: <AS8PR08MB70805AE674C297B9290E38F89E819@AS8PR08MB7080.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20220705133057.3821347-1-thomas@monjalon.net>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, July 5, 2022 9:31 PM
> To: dev@dpdk.org
> Cc: luzhipeng <luzhipeng@cestc.cn>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Jan Viktorin <viktorin@rehivetech.com>; Bruce
> Richardson <bruce.richardson@intel.com>
> Subject: [PATCH v3] config/arm: add Phytium FT-2000+
>
> From: luzhipeng <luzhipeng@cestc.cn>
>
> Here adds configs for Phytium server.
>
> Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> I did some changes in this v3:
> - PHYTIUM -> Phytium (as on the website)
> - ft2000plus -> FT-2000+ (as found online)
> - alphabetical ordering
> - extra commas for future extensions
> - g++ as cpp Meson command
>
> Please tell how to write your name with spaces and capitals in the order [first
> name] [family name], thanks.
> ---
<snip>
> implementer_qualcomm = {
> 'description': 'Qualcomm',
> 'flags': [
> @@ -214,7 +228,7 @@ implementer_qualcomm = {
> '0xc00': {
> 'march': 'armv8-a',
> 'march_features': ['crc']
> - }
> + },
Unintentional change?
The change is valid, but not related to this patch.
Otherwise looks good to me.
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
> }
> }
>
> @@ -225,7 +239,8 @@ implementers = {
> '0x43': implementer_cavium,
> '0x48': implementer_hisilicon,
> '0x50': implementer_ampere,
> - '0x51': implementer_qualcomm
> + '0x51': implementer_qualcomm,
> + '0x70': implementer_phytium,
> }
>
> # SoC specific armv8 flags have the highest priority @@ -304,6 +319,13 @@
> soc_emag = {
> 'part_number': '0x0'
> }
>
> +soc_ft2000plus = {
> + 'description': 'Phytium FT-2000+',
> + 'implementer': '0x70',
> + 'part_number': '0x662',
> + 'numa': true
> +}
> +
> soc_graviton2 = {
> 'description': 'AWS Graviton2',
> 'implementer': '0x41',
> @@ -389,6 +411,7 @@ cn9k: Marvell OCTEON 9
> cn10k: Marvell OCTEON 10
> dpaa: NXP DPAA
> emag: Ampere eMAG
> +ft2000plus: Phytium FT-2000+
> graviton2: AWS Graviton2
> kunpeng920: HiSilicon Kunpeng 920
> kunpeng930: HiSilicon Kunpeng 930
> @@ -412,6 +435,7 @@ socs = {
> 'cn10k' : soc_cn10k,
> 'dpaa': soc_dpaa,
> 'emag': soc_emag,
> + 'ft2000plus': soc_ft2000plus,
> 'graviton2': soc_graviton2,
> 'kunpeng920': soc_kunpeng920,
> 'kunpeng930': soc_kunpeng930,
> --
> 2.36.1
next prev parent reply other threads:[~2022-07-05 13:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 6:24 [PATCH v2] config/arm: add PHYTIUM ft2000plus luzhipeng
2022-07-05 13:30 ` [PATCH v3] config/arm: add Phytium FT-2000+ Thomas Monjalon
2022-07-05 13:50 ` Ruifeng Wang [this message]
2022-07-05 13:57 ` Thomas Monjalon
2022-07-08 12:44 ` Thomas Monjalon
2022-07-05 14:25 ` Morten Brørup
2022-07-05 14:31 ` Morten Brørup
2022-07-06 1:02 ` luzhipeng
2022-07-06 1:28 ` luzhipeng
2022-07-06 6:59 ` Thomas Monjalon
2022-07-06 7:00 ` luzhipeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR08MB70805AE674C297B9290E38F89E819@AS8PR08MB7080.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=luzhipeng@cestc.cn \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).