From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Juraj Linkeš" <juraj.linkes@pantheon.tech>, nd <nd@arm.com>,
nd <nd@arm.com>
Subject: RE: [PATCH] config/arm: fix Neoverse N2 march flag
Date: Thu, 8 Jun 2023 14:20:13 +0000 [thread overview]
Message-ID: <AS8PR08MB7080E0B217B567981D6D04A69E50A@AS8PR08MB7080.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <PH0PR18MB4086D3ECA8512EB04B68AFA5DE50A@PH0PR18MB4086.namprd18.prod.outlook.com>
> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Sent: Thursday, June 8, 2023 8:59 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; jerinj@marvell.com; Bruce Richardson
> <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>; nd <nd@arm.com>
> Subject: RE: [PATCH] config/arm: fix Neoverse N2 march flag
>
>
>
> > -----Original Message-----
> > From: Ruifeng Wang <Ruifeng.Wang@arm.com>
> > Sent: Thursday, June 8, 2023 4:12 PM
> > To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin
> > Jacob Kollanukkaran <jerinj@marvell.com>; Bruce Richardson
> > <bruce.richardson@intel.com>
> > Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>; nd
> > <nd@arm.com>
> > Subject: [EXT] RE: [PATCH] config/arm: fix Neoverse N2 march flag
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > > -----Original Message-----
> > > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > > Sent: Thursday, June 8, 2023 3:28 PM
> > > To: jerinj@marvell.com; Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce
> > Richardson
> > > <bruce.richardson@intel.com>
> > > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > Subject: [PATCH] config/arm: fix Neoverse N2 march flag
> > >
> > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > The -march flag of Neoverse N2 should be `armv9-a` when used along
> > > with
> > -mcpu=neoverse-n2.
> > >
> > > Fixes: ea85ed1f6882 ("config/arm: increase nodes and cores for
> > > Neoverse
> > N2")
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > ---
> > > config/arm/meson.build | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > 43f6a551a2..d3b4b4917f
> > > 100644
> > > --- a/config/arm/meson.build
> > > +++ b/config/arm/meson.build
> > > @@ -89,7 +89,7 @@ part_number_config_arm = {
> > > 'march': 'armv8.4-a',
> > > },
> > > '0xd49': {
> > > - 'march': 'armv8.5-a',
> > > + 'march': 'armv9-a',
> > > 'march_features': ['sve2'],
> > > 'compiler_options': ['-mcpu=neoverse-n2'],
> > > 'flags': [
> > > @@ -630,7 +630,7 @@ if update_flags
> > > # probe supported archs and their features
> > > candidate_march = ''
> > > if part_number_config.has_key('march')
> > > - supported_marchs = ['armv8.6-a', 'armv8.5-a', 'armv8.4-a', 'armv8.3-a',
> > > + supported_marchs = ['armv9-a', 'armv8.6-a', 'armv8.5-a',
> >
> > march may fallback to armv8.6-a if compiler doesn't support armv9-a.
> > Is this fallback safe?
>
> Yeah, looks like we need to have a fallback arch if compiler doesn't support a given march
> Armv8.5-a in this case.
>
> > I think just remove march from N2 part_number_config is OK.
>
> I will remove the march from part number config for now.
> But we should work on defining a fallback arch in future as there will always be a
> compiler support mismatch.
Agree. Need to adapt this for v9-a.
>
> >
> > > + 'armv8.4-a', 'armv8.3-a',
> > > 'armv8.2-a', 'armv8.1-a', 'armv8-a']
> > > check_compiler_support = false
> > > foreach supported_march: supported_marchs
> > > --
> > > 2.25.1
next prev parent reply other threads:[~2023-06-08 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 7:27 pbhagavatula
2023-06-08 9:54 ` Srikanth Yalavarthi
2023-06-08 10:41 ` Ruifeng Wang
2023-06-08 12:58 ` Pavan Nikhilesh Bhagavatula
2023-06-08 14:20 ` Ruifeng Wang [this message]
2023-06-08 19:34 ` [PATCH v2] " pbhagavatula
2023-06-09 4:02 ` Ruifeng Wang
2023-06-12 17:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR08MB7080E0B217B567981D6D04A69E50A@AS8PR08MB7080.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).