DPDK patches and discussions
 help / color / mirror / Atom feed
From: Feifei Wang <Feifei.Wang2@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
Cc: David Hunt <david.hunt@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	nd <nd@arm.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	nd <nd@arm.com>
Subject: 回复: [PATCH v3 3/3] examples/l3fwd-power: enable PMD power monitor on Arm
Date: Fri, 11 Nov 2022 10:21:44 +0000	[thread overview]
Message-ID: <AS8PR08MB7718952E4E503F93C60F586AC8009@AS8PR08MB7718.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1834560.u6TykanW85@thomas>

Hi, Thomas
> -----邮件原件-----
> 发件人: Thomas Monjalon <thomas@monjalon.net>
> 发送时间: Friday, November 11, 2022 4:22 PM
> 收件人: Feifei Wang <Feifei.Wang2@arm.com>
> 抄送: David Hunt <david.hunt@intel.com>; dev@dpdk.org;
> david.marchand@redhat.com; stephen@networkplumber.org; nd
> <nd@arm.com>; Ruifeng Wang <Ruifeng.Wang@arm.com>; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>
> 主题: Re: [PATCH v3 3/3] examples/l3fwd-power: enable PMD power
> monitor on Arm
> 
> 11/11/2022 08:26, Feifei Wang:
> > For Arm aarch, power monitor uses WFE instruction to enable, which can
> > not exit automatically within the time limit. This means
> > 'rte_power_monitor_wakeup' API needs to be called to wake up sleep
> > cores if there is no store operation to monitored address.
> >
> > Furthermore, we disable power monitor feature on the main core so that
> > it can be used to wake up other sleeping cores after it exit from loop.
> >
> > Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Acked-by: David Hunt <david.hunt@intel.com>
> > ---
> > +#if defined(RTE_ARCH_ARM64)
> > +				/* Ensure the main lcore does not enter the
> power-monitor state,
> > +				 * so that it can be used to wake up other
> lcores on ARM.
> > +				 * This is due to WFE instruction has no
> timeout wake-up mechanism,
> > +				 * and if users want to exit actively, the main
> lcore is needed
> > +				 * to send SEV instruction to wake up other
> lcores.
> > +				 */
> > +				unsigned int main_lcore =
> rte_get_main_lcore();
> > +				if (lcore_id == main_lcore &&
> > +						pmgmt_type ==
> RTE_POWER_MGMT_TYPE_MONITOR)
> > +					continue;
> > +#endif
> 
> We need to have this logic abstracted in the API for all architectures.
> We cannot afford having such #ifdef per CPU in the application.

Thanks for the comment. I will move this into API.

Best Regards
Feifei
> 


  reply	other threads:[~2022-11-11 10:22 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25  6:42 [PATCH v1 0/3] Enable PMD power management " Feifei Wang
2022-08-25  6:42 ` [PATCH v1 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-08-25  6:42 ` [PATCH v1 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-08-25  6:42 ` [PATCH v1 3/3] examples/l3fwd-power: enable PMD power mgmt " Feifei Wang
2022-08-29 12:48   ` Hunt, David
2022-10-03  7:12     ` David Marchand
2022-10-11  7:56       ` 回复: " Feifei Wang
2022-10-20 20:41         ` Thomas Monjalon
2022-10-27  9:38           ` 回复: " Feifei Wang
2022-10-20 22:09   ` Stephen Hemminger
2022-10-27  9:43     ` 回复: " Feifei Wang
2022-11-07  7:04 ` [PATCH v2 0/3] Enable PMD power management " Feifei Wang
2022-11-07  7:04   ` [PATCH v2 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-07  7:04   ` [PATCH v2 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-11-07  7:04   ` [PATCH v2 3/3] examples/l3fwd-power: enable PMD power monitor " Feifei Wang
2022-11-07 16:01     ` Stephen Hemminger
2022-11-08  3:25       ` 回复: " Feifei Wang
2022-11-11  7:26 ` [PATCH v3 0/3] Enable PMD power management " Feifei Wang
2022-11-11  7:26   ` [PATCH v3 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-11  7:26   ` [PATCH v3 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-11-11  7:26   ` [PATCH v3 3/3] examples/l3fwd-power: enable PMD power monitor " Feifei Wang
2022-11-11  8:22     ` Thomas Monjalon
2022-11-11 10:21       ` Feifei Wang [this message]
2022-11-11 10:20 ` [PATCH v4 0/4] Enable PMD power management " Feifei Wang
2022-11-11 10:20   ` [PATCH v4 1/4] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-11 10:20   ` [PATCH v4 2/4] eal: add power mgmt support on Arm Feifei Wang
2022-11-11 10:20   ` [PATCH v4 3/4] power: add power monitor support check Feifei Wang
2022-11-11 10:20   ` [PATCH v4 4/4] examples/l3fwd-power: add power monitor wake up API Feifei Wang
2022-12-14  8:14 ` [PATCH v5 0/2] Enable PMD power management on Arm Feifei Wang
2022-12-14  8:14   ` [PATCH v5 1/2] eal: add 8 bits case for wait scheme Feifei Wang
2022-12-14  8:14   ` [PATCH v5 2/2] eal: add power mgmt support on Arm Feifei Wang
2023-02-17 16:23     ` Stephen Hemminger
2023-02-20  1:56       ` 回复: " Feifei Wang
2023-02-17  8:26   ` 回复: [PATCH v5 0/2] Enable PMD power management " Feifei Wang
2023-02-20  8:51 ` [PATCH v6 " Feifei Wang
2023-02-20  8:51   ` [PATCH v6 1/2] eal: add 8 bits case for wait scheme Feifei Wang
2023-02-20  8:51   ` [PATCH v6 2/2] eal: add power mgmt support on Arm Feifei Wang
2023-02-20 12:07   ` [PATCH v6 0/2] Enable PMD power management " David Marchand
2023-02-21  2:37     ` 回复: " Feifei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8PR08MB7718952E4E503F93C60F586AC8009@AS8PR08MB7718.eurprd08.prod.outlook.com \
    --to=feifei.wang2@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=david.hunt@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).