From: Andy Green <andy@warmcat.com>
To: dev@dpdk.org,Jasvinder Singh <jasvinder.singh@intel.com>
Cc: cristian.dumitrescu@intel.com
Subject: Re: [dpdk-dev] [PATCH] table: add dedicated params struct for cuckoo hash
Date: Tue, 08 May 2018 22:34:49 +0800 [thread overview]
Message-ID: <B025C4A8-9C5D-4873-940D-833F98AEB4B4@warmcat.com> (raw)
In-Reply-To: <20180508141718.18706-1-jasvinder.singh@intel.com>
On May 8, 2018 10:17:18 PM GMT+08:00, Jasvinder Singh <jasvinder.singh@intel.com> wrote:
>Add dedicated parameter structure for cuckoo hash. The cuckoo hash from
>librte_hash uses slightly different prototype for the hash function (no
>key_mask parameter, 32-bit seed and return value) that require either
>of the following approaches:
> 1/ Function pointer conversion: gcc 8.1 warning [1], misleading [2]
As I wrote earlier this is broken on master currently... gcc 8.0.1, shipping on Fedora 28, is able to appreciate the existing cast is completely wrong and build errors out. It's not a compiler version quirk so much as what is in master is actually broken.
> 2/ Union within the parameter structure: pollutes a very generic API
> parameter structure with some implementation dependent detail
> (i.e. key mask not available for one of the available
> implementations)
> 3/ Using opaque pointer for hash function: same issue from 2/
> 4/ Different parameter structure: avoid issue from 2/; hopefully,
> it won't be long before librte_hash implements the key mask feature,
> so the generic API structure could be used.
Unifying them in a single function pointer type is obviously best since they're trying to do the same thing.
> static int
>-check_params_create_hash_cuckoo(struct rte_table_hash_params *params)
>+check_params_create_hash_cuckoo(struct rte_table_hash_cuckoo_params
>*params)
...
> {
> if (params == NULL) {
> RTE_LOG(ERR, TABLE, "NULL Input Parameters.\n");
>@@ -82,7 +81,7 @@ rte_table_hash_cuckoo_create(void *params,
> int socket_id,
> uint32_t entry_size)
> {
>- struct rte_table_hash_params *p = params;
>+ struct rte_table_hash_cuckoo_params *p = params;
I think a proper solution will have to get rid of the void * params...
>- .hash_func = (rte_hash_function)(p->f_hash),
>+ .hash_func = p->f_hash,
-Andy
next prev parent reply other threads:[~2018-05-08 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 14:17 Jasvinder Singh
2018-05-08 14:30 ` Dumitrescu, Cristian
2018-05-08 14:34 ` Andy Green [this message]
2018-05-08 16:46 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B025C4A8-9C5D-4873-940D-833F98AEB4B4@warmcat.com \
--to=andy@warmcat.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).