From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range
Date: Thu, 3 Dec 2015 12:14:17 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2023CC9B0@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <aa1719d759d44dd62166432ed2179ac2c66e79b5.1449075047.git.pmatilai@redhat.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
> Sent: Wednesday, December 2, 2015 4:51 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] scripts: support any legal git revisions as
> abi validation range
>
> In addition to git tags, support validating abi between any legal
> gitrevisions(7) syntaxes, such as "validate-abi.sh . -1 <target>"
> "validate-abi.sh master mybrach <target>" etc in addition to validating
> between tags. Makes it easier to run the validator for in-development
> work.
Hi Panu,
+1 for this.
You might also change the ABI validation section of the docs to go along
with this. Something like the patch below. If not I'll submit it
afterwards.
Also, if someone has some bandwidth it would be good to add an option
to pass -j with an optional number to "make" in the script.
John
$ git diff
diff --git a/doc/guides/contributing/versioning.rst b/doc/guides/contributing/versioning.rst
index 653c7d0..5ce5f9d 100644
--- a/doc/guides/contributing/versioning.rst
+++ b/doc/guides/contributing/versioning.rst
@@ -465,19 +465,23 @@ utilities which can be installed via a package manager. For example::
sudo yum install abi-compliance-checker
sudo yum install abi-dumper
+ sudo yum install greadelf
The syntax of the ``validate-abi.sh`` utility is::
- ./scripts/validate-abi.sh <TAG1> <TAG2> <TARGET>
+ ./scripts/validate-abi.sh <REV1> <REV2> <TARGET>
-Where ``TAG1`` and ``TAG2`` are valid git tags on the local repo and target is
-the usual DPDK compilation target.
+Where ``REV1`` and ``REV2`` are valid `gitrevisions(7)
+<https://www.kernel.org/pub/software/scm/git/docs/gitrevisions.html>`_ on the
+local repo and ``TARGET`` is the usual DPDK compilation target.
-For example to test the current committed HEAD against a previous release tag
-we could add a temporary tag and run the utility as follows::
+For example::
- git tag MY_TEMP_TAG
- ./scripts/validate-abi.sh v2.0.0 MY_TEMP_TAG x86_64-native-linuxapp-gcc
+ # Check between the previous and latest commits:
+ ./scripts/validate-abi.sh HEAD~1 HEAD x86_64-native-linuxapp-gcc
+
+ # Check between two tags:
+ ./scripts/validate-abi.sh v2.1.0 v2.2.0 x86_64-native-linuxapp-gcc
After the validation script completes (it can take a while since it need to
compile both tags) it will create compatibility reports in the
next prev parent reply other threads:[~2015-12-03 12:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 16:50 Panu Matilainen
2015-12-02 18:23 ` Neil Horman
2015-12-03 12:14 ` Mcnamara, John [this message]
2015-12-03 13:28 ` Thomas Monjalon
2015-12-03 13:44 ` Panu Matilainen
2015-12-03 13:49 ` Richardson, Bruce
2015-12-03 15:46 ` Mcnamara, John
2015-12-03 13:39 ` Panu Matilainen
2015-12-03 13:41 ` Thomas Monjalon
2015-12-03 14:05 ` [dpdk-dev] [PATCH v2] " Panu Matilainen
2015-12-07 14:09 ` Panu Matilainen
2015-12-07 14:32 ` Thomas Monjalon
2015-12-07 16:08 ` Panu Matilainen
2015-12-07 22:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2023CC9B0@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).