From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] version: switch to year/month version numbers
Date: Wed, 10 Feb 2016 17:11:57 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2024518DC@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1455123732-1705-1-git-send-email-john.mcnamara@intel.com>
> -----Original Message-----
> From: Mcnamara, John
> Sent: Wednesday, February 10, 2016 5:02 PM
> To: dev@dpdk.org
> Cc: thomas.monjalon@6wind.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Mcnamara, John <john.mcnamara@intel.com>
> Subject: [PATCH v3 1/2] version: switch to year/month version numbers
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index
> ffa5730..fd4dd39 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -1070,9 +1070,7 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> };
>
> dev_info->reta_size = NFP_NET_CFG_RSS_ITBL_SZ;
>-#if RTE_VER_MAJOR == 2 && RTE_VER_MINOR >= 1
> dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
>-#endif }
>
Hi Alejandro,
Please note the above change to the nfp_net.c code due to the name change
in the version macro names.
I was originally going to change it to this:
#if RTE_VER_YEAR == 2 && RTE_VER_MONTH >= 1
dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
#endif
Or better:
#if RTE_VERSION >= 0x02010000
dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
#endif
However, since the code was added in DPDK 2.2 the version check doesn't seem
necessary, so I removed it. If you need it back in for some reason let me know.
John
next prev parent reply other threads:[~2016-02-10 17:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 13:26 [dpdk-dev] [PATCH 0/3] switch to using YY.MM " Bruce Richardson
2015-12-21 13:26 ` [dpdk-dev] [PATCH 1/3] version: switch to year/month " Bruce Richardson
2016-02-10 14:33 ` [dpdk-dev] [PATCH v2 1/2] " John McNamara
2016-02-10 14:33 ` [dpdk-dev] [PATCH v2 2/2] doc: rename release notes 2.3 to 16.04 John McNamara
2016-02-10 15:11 ` [dpdk-dev] [PATCH v2 1/2] version: switch to year/month version numbers Thomas Monjalon
2016-02-10 15:31 ` Bruce Richardson
2016-02-10 16:52 ` Mcnamara, John
2015-12-21 13:26 ` [dpdk-dev] [PATCH 2/3] version: adjust printing for new version scheme Bruce Richardson
2015-12-28 22:25 ` Thomas Monjalon
2016-02-10 14:28 ` Mcnamara, John
2015-12-21 13:26 ` [dpdk-dev] [PATCH 3/3] doc: rename release 2.3 to 16.04 Bruce Richardson
2016-02-10 17:02 ` [dpdk-dev] [PATCH v3 1/2] version: switch to year/month version numbers John McNamara
2016-02-10 17:02 ` [dpdk-dev] [PATCH v3 2/2] doc: rename release notes 2.3 to 16.04 John McNamara
2016-02-10 17:11 ` Mcnamara, John [this message]
2016-02-10 17:20 ` [dpdk-dev] [PATCH v3 1/2] version: switch to year/month version numbers Thomas Monjalon
2016-02-10 21:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2024518DC@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).