DPDK patches and discussions
 help / color / mirror / Atom feed

From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] tools/dpdk_nic_bind: fix flake8 warnings
Date: Fri, 19 Feb 2016 14:02:32 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE20245C20B@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1455834773-5584-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mauricio Vasquez B
> Sent: Thursday, February 18, 2016 10:33 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] tools/dpdk_nic_bind: fix flake8 warnings
> 
> flake8 checks were run for both python 2.7 and 3.4
> 
> There were some style issues as:
> - Line width > 79
> - No double blank line before function definition
> - No double blank space before inline comment
> - Some other minor issues
> 
> Signed-off-by: Mauricio Vasquez B
> <mauricio.vasquezbernal@studenti.polito.it>

Hi,

Thanks for that. A lot of these issues were introduced with patch:

    16c1814c802c ("tools: support Python 3 in bind script")

I meant to comment on the previous patch but it was merged before I
got a chance.

>      dev_lines = check_output(["lspci", "-Dvmmn"]).splitlines()
>      for dev_line in dev_lines:
>          if (len(dev_line) == 0):
>              if dev["Class"] == ETHERNET_CLASS:
>                  #convert device and vendor ids to numbers, then add to

There is still one pep8 issue reported here:

   $ pep8 tools/dpdk_nic_bind.py 
   tools/dpdk_nic_bind.py:252:17: E265 block comment should start with '# '

Perhaps you can submit a v2 with that minor change. Otherwise:

Acked-by: John McNamara <john.mcnamara@intel.com>

next prev parent reply	other threads:[~2016-02-19 14:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 22:32 Mauricio Vasquez B
2016-02-19 14:02 ` Mcnamara, John [this message]
2016-02-19 17:03 ` [dpdk-dev] [PATCH v2] " Mauricio Vasquez B
2016-02-19 17:25   ` Mcnamara, John
2016-03-24 20:27     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE20245C20B@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=mauricio.vasquezbernal@studenti.polito.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).