DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it>,
	"Xie, Huawei" <huawei.xie@intel.com>,
	"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: fix vhost bad section number references
Date: Mon, 22 Feb 2016 09:56:08 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE20245D86D@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1455966770-6206-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mauricio Vasquez B
> Sent: Saturday, February 20, 2016 11:13 AM
> To: Xie, Huawei <huawei.xie@intel.com>; yuanhan.liu@linux.intel.com
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: fix vhost bad section number references
> 
> Section numbers were "hard-coded". This patch adds them as hyperlinks.
> 
> Signed-off-by: Mauricio Vasquez B
> <mauricio.vasquezbernal@studenti.polito.it>

Acked-by: John McNamara <john.mcnamara@intel.com>

Thanks.

It is probably best to include some reference to the file or doc section in
the target name since they are shared across all of the Html documentation.
For example _vhost_running_the_vm instead of _running_the_vm. 

Btw, I was surprised this issue hadn't be fixed in an earlier doc patchset.
Checking the docs there are around 20 other hardcoded references like this.
If you have some time it would be could if you could fix those in the same
way.

John

  parent reply	other threads:[~2016-02-22  9:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20 11:12 Mauricio Vasquez B
2016-02-22  5:46 ` Yuanhan Liu
2016-02-22  9:56 ` Mcnamara, John [this message]
2016-02-22 10:30   ` Mauricio Vásquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE20245D86D@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=mauricio.vasquezbernal@studenti.polito.it \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).