From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: add doc for i40e pmd driver introduction
Date: Mon, 22 Feb 2016 15:34:20 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE20245DFC3@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1453971042-16925-1-git-send-email-jingjing.wu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jingjing Wu
> Sent: Thursday, January 28, 2016 8:51 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add doc for i40e pmd driver introduction
>
> A new doc "i40e.rst" is added to introduce i40e pmd driver.
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Thanks for the new doc. Some minor comments below.
> +
> +- Multiple queues for TX and RX
> +- Receiver Side Steering (RSS)
s/Steering/Scaling
> +- MAC/VLAN filtering
> +- Packet type information
> +- flow director
> +- cloud filter
Capitalize these for consistency.
> + ./app/testpmd -c ffff -n 4 -- -i --disable-rss --pkt-filter-
> mode=perfect --rxq=8 --txq=8 --nb-cores=8 --nb-ports=1
> + [...]
Long code lines like this don't wrap in the PDF output and should be restricted to
80 characters. You can add a commandline continuation like the following:
.. code-block:: console
./app/testpmd -c ffff -n 4 -- -i --disable-rss --pkt-filter-mode=perfect \
--rxq=8 --txq=8 --nb-cores=8 --nb-ports=1
Same for the next examples.
> + MODE: PERFECT
> + SUPPORTED FLOW TYPE: ipv4-frag ipv4-tcp ipv4-udp ipv4-sctp ipv4-
> other ipv6-frag ipv6-tcp ipv6-udp ipv6-sctp ipv6-other l2_payload
> + FLEX PAYLOAD INFO:
Some of this information could also be wrapped/omitted while retaining the
same information. I'll send you on an example.
John.
--
next prev parent reply other threads:[~2016-02-22 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 8:50 Jingjing Wu
2016-02-22 5:49 ` Lu, Wenzhuo
2016-02-22 15:34 ` Mcnamara, John [this message]
2016-02-23 1:23 ` [dpdk-dev] [PATCH v2] " Jingjing Wu
2016-02-23 10:21 ` Mcnamara, John
2016-03-06 22:39 ` Thomas Monjalon
2016-03-07 2:37 ` Wu, Jingjing
2016-03-07 8:35 ` Thomas Monjalon
2016-03-07 8:38 ` Wu, Jingjing
2016-03-09 7:28 ` [dpdk-dev] [PATCH v3 0/2] doc: add " Jingjing Wu
2016-03-09 7:28 ` [dpdk-dev] [PATCH v3 1/2] doc: add doc for " Jingjing Wu
2016-03-09 7:28 ` [dpdk-dev] [PATCH v3 2/2] doc: add i40e to overview table Jingjing Wu
2016-03-09 17:01 ` [dpdk-dev] [PATCH v3 0/2] doc: add i40e pmd driver introduction Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE20245DFC3@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).