From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] testpmd: fix typo when closing port
Date: Wed, 8 Jun 2016 17:18:27 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE20257DD57@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <43127148.6njRUyVk9W@xps13>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, June 8, 2016 5:29 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] testpmd: fix typo when closing port
>
> 2016-06-08 16:20, Pablo de Lara:
> > if (rte_atomic16_cmpset(&(port->port_status),
> > RTE_PORT_HANDLING, RTE_PORT_CLOSED) == 0)
> > - printf("Port %d can not be set into stopped\n", pi);
> > + printf("Port %d can not be set into closed\n", pi);
>
> My english would say "Port cannot be closed".
> Am I wrong?
Yes, that is better or "Port cannot be set to closed" if "closed" is a
state like here.
next prev parent reply other threads:[~2016-06-08 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 15:20 Pablo de Lara
2016-06-08 16:28 ` Thomas Monjalon
2016-06-08 17:18 ` Mcnamara, John [this message]
2016-06-08 17:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE20257DD57@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).