DPDK patches and discussions
 help / color / mirror / Atom feed

From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Liu, Yong" <yong.liu@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] doc: flow bifurcation guide on Linux
Date: Sun, 17 Jul 2016 19:31:18 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2025A0015@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1468483465-29135-1-git-send-email-jingjing.wu@intel.com>

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Thursday, July 14, 2016 9:04 AM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Liu, Yong
> <yong.liu@intel.com>; Zhang, Helin <helin.zhang@intel.com>
> Subject: [PATCH v3] doc: flow bifurcation guide on Linux
> 
> Flow bifurcation is a mechanism which depends the advanced Ethernet device
> to split traffic between queues. It provides the capability to let the
> kernel driver and DPDK driver co-exist and take their advantages.
> It is achieved by using SRIOV and NIC's advanced filtering. This patch
> describes it and adds the user guide on ixgbe and i40 NICs.

Hi Jingjing,

Thanks for the nice clear document with clear examples and images.

Some minor comments below.

> +Other than KNI, the SW is just required to device configuration, no
> +need to take care of the packet movement during the traffic split. This
> +can get more performance with less CPU overhead.

It isn't clear here what KNIs involvement is, if any, or why it is different.
I'd suggest clarifying if it is important or just omitting otherwise.


> +.. _figure_flow_bifurcation_overview:
> +
> +.. figure:: img/flow_bifurcation_overview.*
> +
> +   Flow Bifucation Overview

s/Bifucation/Bifurcation/

Also, I'd suggest using capitalized "Flow Bifurcation" consistently throughout the doc.

> +    .. code-block:: console
> +
> +        ethtool -K eth1 ntuple on
> +        ethtool -N eth1 flow-type udp4 src-ip 192.0.2.2 dst-ip
> 198.51.100.2 \
> +		        action $queue_index_in_VF0
> +        ethtool -N eth1 flow-type udp4 src-ip 198.51.100.2 dst-ip
> 192.0.2.2 \
> +                action $queue_index_in_VF1
> +
> +    where:
> +
> +        *   $queue_index_in_PF: [queue index]

I don't see '$queue_index_in_PF' used in this example.


> +#.  Enable and set flow filters:
> +
> +    *   L3 VEB filter, route whose dest IP = 192.168.50.108 to VF 0's
> queue 2.
> +
> +    .. code-block:: console
> +
> +        ethtool -N <dev_name> flow-type ip4 dst-ip 192.168.50.108 \
> +                user-def 0xffffffff00000000 action 2 loc 8
> +


I think the code-block level is wrong in these sections.

I'll send you on some other minor grammatical changes.

Thanks,

John

next prev parent reply	other threads:[~2016-07-17 19:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23  3:02 [dpdk-dev] [PATCH v2 1/2] doc: add bifurcated driver guide on ixgbe nic Jingjing Wu
2016-06-23 12:58 ` Thomas Monjalon
2016-07-08  8:42   ` Wu, Jingjing
2016-07-08  9:14     ` Thomas Monjalon
2016-07-08  9:24       ` Mcnamara, John
2016-07-11  5:50       ` Wu, Jingjing
2016-07-14  8:04 ` [dpdk-dev] [PATCH v3] doc: flow bifurcation guide on Linux Jingjing Wu
2016-07-17 19:31   ` Mcnamara, John [this message]
2016-07-19  3:31   ` [dpdk-dev] [PATCH v4] " Jingjing Wu
2016-07-19 16:34     ` Mcnamara, John
2016-07-20  0:59       ` Wu, Jingjing
2016-07-22 17:23       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE2025A0015@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).