From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Loftus, Ciara" <ciara.loftus@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Liu, Yuanhan" <yuanhan.liu@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id.
Date: Wed, 28 Sep 2016 16:59:03 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2026254FC@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <28342659.xFrdpVFeBf@xps13>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, September 13, 2016 4:10 PM
> To: Loftus, Ciara <ciara.loftus@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/vhost: Add function to retreive the
> 'vid' for a given port id.
>
> 2016-09-13 14:47, Ciara Loftus:
> > In some cases when using the vHost PMD, certain vHost library
> > functions may still need to be accessed. One such example is the
> > rte_vhost_get_queue_num function which returns the number of
> > virtqueues reported by the guest - information which is not exposed by
> the PMD.
> >
> > This commit introduces a new rte_eth_vhost function that returns the
> > 'vid' associated with a given port id. This allows the PMD user to
> > call vHost library functions which require the 'vid' value.
>
> I think we should not add any API to the PMDs.
> Maybe you are looking for a generic API in ethdev.
Hi,
This patch got a little lost in a general discussion on generic versus specific APIs.
As far as I can see this is a PMD specific API and the general consensus by the end of the thread was that this would be acceptable. Is that the case or are there still objections to this patch.
The patch is critical for integration of the Vhost PMD into OvS so I'd like to make sure that we consider it as such. See the discussion here:
http://openvswitch.org/pipermail/dev/2016-August/076887.html
John
next prev parent reply other threads:[~2016-09-28 16:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 13:47 Ciara Loftus
2016-09-13 15:10 ` Thomas Monjalon
2016-09-14 4:43 ` Yuanhan Liu
2016-09-14 7:10 ` Thomas Monjalon
2016-09-14 7:21 ` Yuanhan Liu
2016-09-14 8:35 ` Thomas Monjalon
2016-09-18 8:27 ` Yuanhan Liu
2016-09-21 13:07 ` Thomas Monjalon
2016-09-22 2:36 ` Yuanhan Liu
2016-09-22 16:43 ` Thomas Monjalon
2016-09-23 4:26 ` Yuanhan Liu
2016-09-23 8:43 ` Thomas Monjalon
2016-09-23 9:16 ` Yuanhan Liu
2016-09-23 9:26 ` Loftus, Ciara
2016-09-23 21:23 ` Wiles, Keith
2016-09-26 3:19 ` Yuanhan Liu
2016-09-26 13:12 ` Thomas Monjalon
2016-09-26 13:18 ` Bruce Richardson
2016-09-26 14:26 ` Thomas Monjalon
2016-09-26 14:34 ` Bruce Richardson
2016-09-26 16:24 ` Iremonger, Bernard
2016-09-26 16:55 ` Thomas Monjalon
2016-09-26 17:05 ` Wiles, Keith
2016-09-28 16:59 ` Mcnamara, John [this message]
2016-09-29 9:21 ` Mcnamara, John
2016-09-29 9:30 ` Thomas Monjalon
2016-09-29 12:08 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2026254FC@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).