From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: unify help strings
Date: Fri, 2 Dec 2016 10:55:48 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE20266D23D@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20161202015845.7121-1-ferruh.yigit@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Friday, December 2, 2016 1:59 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: unify help strings
>
> Formatted as:
> cmd fixed_string fixed|string|options <variable>: Description
>
> If there is no description, final colon emitted.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Good refactoring work to give consistency. It might be worth having a look at the testpmd docs to see if some of the same improvements can be made there as well. That could be a separate patch.
> .f = cmd_config_rss_hash_key_parsed,
> .data = NULL,
> - .help_str =
> - "port config X rss-hash-key ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|"
> - "ipv4-sctp|ipv4-other|ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|"
> - "ipv6-sctp|ipv6-other|l2-payload|"
> - "ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex "
> - "<string of hexa digits (variable length, NIC dependent)>\n",
> + .help_str = "port config <port_id> rss-hash-key "
> + "ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|"
> + "ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|"
> + "l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex "
> + "<string of hexa digits (variable length, NIC dependent)>",
/hex/hexa/
Apart from that:
Acked-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2016-12-02 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 1:37 [dpdk-dev] [PATCH] " Ferruh Yigit
2016-12-02 1:58 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-12-02 10:55 ` Mcnamara, John [this message]
2016-12-06 13:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE20266D23D@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).